Re: [PATCH 06/25] soc: ti: knav_qmss_queue: Remove set but unchecked variable 'ret'

santosh.shilimkar
2020-11-12T19:48:42Z

On 11/12/20 11:02 AM, Lee Jones wrote:
> On Thu, 12 Nov 2020, santosh.shilimkar@oracle.com wrote:
>
>> On 11/12/20 5:21 AM, Lee Jones wrote:
>>> On Thu, 12 Nov 2020, Tero Kristo wrote:
>>>
>>>> On 12/11/2020 12:31, Lee Jones wrote:
>>>>> Cc:ing a few people I know.
>>>>>
>>>>> On Tue, 03 Nov 2020, Lee Jones wrote:
>>>>>
>>>>>> Fixes the following W=1 kernel build warning(s):
>>>>>>
>>>>>> drivers/soc/ti/knav_qmss_queue.c: In function ‘knav_setup_queue_pools’:
>>>>>> drivers/soc/ti/knav_qmss_queue.c:1310:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>>>>>>
>>>>>> Cc: Santosh Shilimkar <ssantosh@kernel.org>
>>>>>> Cc: Sandeep Nair <sandeep_n@ti.com>
>>>>>> Cc: Cyril Chemparathy <cyril@ti.com>
>>>>>> Signed-off-by: Lee Jones <lee.jones@linaro.org>
>>>>>> ---
>>>>>> drivers/soc/ti/knav_qmss_queue.c | 3 +--
>>>>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>>>
>>>>> Any idea who will take these TI patches?
>>>>>
>>>>> https://urldefense.com/v3/__https://lore.kernel.org/linux-arm-kernel/20201111052540.GH173948@builder.lan/__;!!GqivPVa7Brio!KEeMCT-GwmLNnDFCOqxnunXXiCrCpj3ZFXpiMzj55VmlOJ-FVhKmom-O7sq-CkL8s0sjAg$
>>>>>
>>>>
>>>> (Dropped a few inactive emails from delivery.)
>>>>
>>>> Santosh is the maintainer for the subsystem, so my vote would go for him.
>>>
>>> Thanks for your prompt reply Tero.
>>>
>>> It looks as though Santosh has been on Cc since the start. He must
>>> just be busy. I'll give him a little while longer before submitting a
>>> [RESEND].
>>>
>> Go ahead and re-post. These seems to be trivial so will pick
>> it up.
>
> If you are in receipt of the first iteration, there shouldn't be any
> requirement for a [RESEND]. Unless you deleted them from your inbox?
>
I haven't deleted anything. I thought you are going to repost based
on "I'll give him a little while longer before submitting a [RESEND]"
:-)

Regards,
Santosh

Regards,
Santosh