From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80462C388F7 for ; Fri, 13 Nov 2020 12:01:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 115232224C for ; Fri, 13 Nov 2020 12:01:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LadlEeat" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 115232224C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=o7xN3CWVsduyy1Zj6MLrsMMNYefN9p0EUUYouAXbfsE=; b=LadlEeat7kpe2o0BqBv1It9vj +rtbTHV2jvcBmUpmJ8g09hK6vo8LDbQgTYNfPbaWtjHwNf1YwYlyZFitkZGcQwUoD+K5LybHW7KwY g6EU4qvu1WY33GICp9ugjBNNZlxo54K1RbkIwuJEoYPgQR0q6rzvGXTl8wwGEIJWAnOutvhLfcMbh 3C/i08D0zWbJ7x3UG67JrcmcUT2MWM+nLouLzgGOhb8BYFE4FscxQD7JOl53bzeG6TApi/zJokJtf WoEDOytIFQwNSlLSRhScFWM1W9NrVIiZh30TdJe9T/PLcqaJUS/LcuPxVsrmy3APmWnBWftoy/xnF keWwZhApA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdXkQ-00049h-4Y; Fri, 13 Nov 2020 12:00:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdXkN-000496-0E for linux-arm-kernel@lists.infradead.org; Fri, 13 Nov 2020 12:00:07 +0000 Received: from gaia (unknown [2.26.170.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7FD642224B; Fri, 13 Nov 2020 12:00:03 +0000 (UTC) Date: Fri, 13 Nov 2020 12:00:01 +0000 From: Catalin Marinas To: Vincenzo Frascino Subject: Re: [PATCH v9 30/44] arm64: kasan: Allow enabling in-kernel MTE Message-ID: <20201113120000.GB3212@gaia> References: <5ce2fc45920e59623a4a9d8d39b6c96792f1e055.1605046192.git.andreyknvl@google.com> <20201112094354.GF29613@gaia> <66ef4957-f399-4af1-eec5-d5782551e995@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <66ef4957-f399-4af1-eec5-d5782551e995@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201113_070007_127136_A621D188 X-CRM114-Status: GOOD ( 17.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Marco Elver , Andrey Konovalov , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 13, 2020 at 11:17:15AM +0000, Vincenzo Frascino wrote: > On 11/12/20 9:43 AM, Catalin Marinas wrote: > > On Tue, Nov 10, 2020 at 11:10:27PM +0100, Andrey Konovalov wrote: > >> From: Vincenzo Frascino > >> > >> Hardware tag-based KASAN relies on Memory Tagging Extension (MTE) > >> feature and requires it to be enabled. MTE supports > >> > >> This patch adds a new mte_init_tags() helper, that enables MTE in > >> Synchronous mode in EL1 and is intended to be called from KASAN runtime > >> during initialization. > > > > There's no mte_init_tags() in this function. > > During the rework, I realized that the description of mte_init_tags() in this > patch refers to mte_enable_kernel(). In fact the only thing that mte_init_tags() > does is to configure the GCR_EL1 register, hence my preference would be to keep > all the code that deals with such a register in one patch. Fine by me as long as the commit text is consistent with the diff. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel