From: Ionela Voinescu <ionela.voinescu@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
sudeep.holla@arm.com, will@kernel.org, morten.rasmussen@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: abort counter_read_on_cpu() when irqs_disabled()
Date: Fri, 13 Nov 2020 16:58:43 +0000 [thread overview]
Message-ID: <20201113165843.GA6973@arm.com> (raw)
In-Reply-To: <20201113160234.GB44988@C02TD0UTHF1T.local>
On Friday 13 Nov 2020 at 16:02:34 (+0000), Mark Rutland wrote:
> On Fri, Nov 13, 2020 at 03:53:28PM +0000, Ionela Voinescu wrote:
> > Given that smp_call_function_single() can deadlock when interrupts are
> > disabled, abort the SMP call if irqs_disabled(). This scenario is
> > currently not possible given the function's uses, but safeguard this for
> > potential future uses.
>
> Sorry to contradict earlier feedback, but I think this is preferable
> as-is, since smp_call_function_single() will
> WARN_ON_ONCE(irqs_disabled())), but this will silently mask any dodgy
> usage.
Probably it only contradicts the chosen implementation.
>
> If we want a separate check here, I reckon we should wrap it with a
> WARN_ON_ONCE(), and only relax that if/when we have a legitimate case
> for calling this with IRQs disabled.
>
That's fair. I'll replace the condition below with:
if (!cpu_has_amu_feat(cpu))
return -EOPNOTSUPP;
if (WARN_ON_ONCE(irqs_disabled())
return -EPERM;
Thanks for your time,
Ionela.
> Thanks,
> Mark.
>
> >
> > Signed-off-by: Ionela Voinescu <ionela.voinescu@arm.com>
> > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > Cc: Will Deacon <will@kernel.org>
> > ---
> > arch/arm64/kernel/topology.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c
> > index 3a083a9a8ef2..e387188741f2 100644
> > --- a/arch/arm64/kernel/topology.c
> > +++ b/arch/arm64/kernel/topology.c
> > @@ -343,7 +343,11 @@ static void cpu_read_constcnt(void *val)
> > static inline
> > int counters_read_on_cpu(int cpu, smp_call_func_t func, u64 *val)
> > {
> > - if (!cpu_has_amu_feat(cpu))
> > + /*
> > + * Abort call on counterless CPU or when interrupts are
> > + * disabled - can lead to deadlock in smp sync call.
> > + */
> > + if (!cpu_has_amu_feat(cpu) || unlikely(irqs_disabled()))
> > return -EOPNOTSUPP;
> >
> > smp_call_function_single(cpu, func, val, 1);
> > --
> > 2.17.1
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-13 16:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 12:53 [PATCH v4 0/3] arm64: cppc: add FFH support using AMUs Ionela Voinescu
2020-11-06 12:53 ` [PATCH v4 1/3] arm64: wrap and generalise counter read functions Ionela Voinescu
2020-11-13 14:11 ` Sudeep Holla
2020-11-06 12:53 ` [PATCH v4 2/3] arm64: split counter validation function Ionela Voinescu
2020-11-13 14:12 ` Sudeep Holla
2020-11-06 12:53 ` [PATCH v4 3/3] arm64: implement CPPC FFH support using AMUs Ionela Voinescu
2020-11-12 18:00 ` Catalin Marinas
2020-11-13 12:28 ` Ionela Voinescu
2020-11-13 12:54 ` Catalin Marinas
2020-11-13 14:16 ` Sudeep Holla
2020-11-13 16:37 ` Ionela Voinescu
2020-11-13 20:03 ` Catalin Marinas
2020-11-13 15:53 ` [PATCH] arm64: abort counter_read_on_cpu() when irqs_disabled() Ionela Voinescu
2020-11-13 16:02 ` Mark Rutland
2020-11-13 16:58 ` Ionela Voinescu [this message]
2020-11-13 17:30 ` Mark Rutland
2020-11-13 19:55 ` Catalin Marinas
2020-11-13 20:26 ` [PATCH v4 0/3] arm64: cppc: add FFH support using AMUs Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113165843.GA6973@arm.com \
--to=ionela.voinescu@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=morten.rasmussen@arm.com \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).