From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65839C388F7 for ; Fri, 13 Nov 2020 17:53:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDB3E20791 for ; Fri, 13 Nov 2020 17:53:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KkRWPYfW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="PDEdUPWc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDB3E20791 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Tg9vMNVWQzFYQ63IbFd6Akapyvg8nc2Ga4ztKCCMFJ8=; b=KkRWPYfWiE12JnyG62x542rJR OGqnuxCzNFFYvxig1IJNsB963gFxOC5EUbRl/huwcJEqVYijFMQh4KRM02kKJ3b/nSHRlVwJaAyMR MRFeazJwRtmihWmC0eQyrOkTO+Yl3jmJI8ROvuMdqEMIpFJRjwQbX9RiKgA/2AqZHRLJdhacZ3+G4 k+lOO3I/baaJ5qa4ssIy9d29OdHg1GO/uhPI0YAZN/GMl+BPqFA/eZ5Foj88hNpkyaJOpgU4XiWxZ nbMHN/vkRz10QWwHm4cagtTekT2s7yxQFyXAG3zmHU7371dcJ2bJf/c2NnXMNm7XGS6FcWZA6L1pZ F5PGdLFBw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kddG1-0007kf-HM; Fri, 13 Nov 2020 17:53:09 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kddFy-0007jm-Gl for linux-arm-kernel@lists.infradead.org; Fri, 13 Nov 2020 17:53:07 +0000 Received: by mail-wr1-x443.google.com with SMTP id k2so10897794wrx.2 for ; Fri, 13 Nov 2020 09:53:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zuo3X1dUSZS5dZ8jl01PZiwsfvErikn3kiTlWYen878=; b=PDEdUPWc7YyVIg3Th+DIE6NoE2WAMuqAu9fM45HMRdj0lXPDGNKLcCyrkkeH6nW1oV bkyC+jfadDn+VRAA+1YMjmozcPoMKNyuyuFo58Rbe1Fm95uHf+OObYzsUueI87+2GTy1 mX7oAZmLT6dT8cN5G4dMLEpjh1bVhCUH/qvYCs1cxqhvBQot6qH1yFjxkdDUmDI5a9V4 yASHI1ag0Gd2ZJHgxGtCPX4o2uXbjFaXLXFeLB4mrYa+kB74GUSbEf30OSpRhP45fXHm NQ7sz7TIz+O/61FIG4IFAdyokMshSG8AoLRxztH3Q6V8GjbfKrnL757YAzYJTSJexrX8 DEWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zuo3X1dUSZS5dZ8jl01PZiwsfvErikn3kiTlWYen878=; b=STj9UPnphwsX1TY+nMZWVUWTcabS2FS59gDBHqZJoTHcExEODgiFaUvRDymMEmH2po zp3M90cUt/Z+EXDzxfb+32TRwwit5e4cjwJGui3+8jxFzFaiR+vswhC/4YvWZBph69n8 orma7fEVjWgdG85tLQf4lDDM0ExFv4+873YMkwuqg0QeIeiQcffSAosIMULCUn1EwGrw 2Mau6xMhIkoBDakVnxS/y6SUyObCaoHbANVqx9OPDCxPPV7zUxzEUWDcP8+gISeutbGy iuG6fyVkzbW8Dfra//5Wv4+Yd7mT4+gejTbhi9K+BrPHWr0eIkjpQ5WwJulnPCq3Gn/Y URQw== X-Gm-Message-State: AOAM53371eBscLsARCEkrHudLe/DvxYDr+FjqIYA7t6z5HNR2ag/nv7h VFMqNBKoGZabtwYJL4Ps7/WFxQ== X-Google-Smtp-Source: ABdhPJyy3j3c0nQwCUqaxX+Yji7YWkR4PFHt86kgu+OkmAeluHcJ0MZ7sl7fPzDdZOXBpU20INn55w== X-Received: by 2002:a5d:488f:: with SMTP id g15mr4844283wrq.151.1605289981187; Fri, 13 Nov 2020 09:53:01 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:f693:9fff:fef4:2449]) by smtp.gmail.com with ESMTPSA id c6sm12676849wrh.74.2020.11.13.09.52.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2020 09:53:00 -0800 (PST) Date: Fri, 13 Nov 2020 18:52:54 +0100 From: Marco Elver To: Andrey Konovalov Subject: Re: [PATCH v2 11/20] kasan: add and integrate kasan boot parameters Message-ID: <20201113175254.GA3175464@elver.google.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.14.6 (2020-07-11) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201113_125306_585032_DECC89CC X-CRM114-Status: GOOD ( 16.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Branislav Rankov , Catalin Marinas , Kevin Brodsky , Will Deacon , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Evgenii Stepanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 10, 2020 at 11:20PM +0100, 'Andrey Konovalov' via kasan-dev wrote: [...] > +/* kasan.mode=off/prod/full */ > +static int __init early_kasan_mode(char *arg) > +{ > + if (!arg) > + return -EINVAL; > + > + if (!strcmp(arg, "off")) > + kasan_arg_mode = KASAN_ARG_MODE_OFF; > + else if (!strcmp(arg, "prod")) > + kasan_arg_mode = KASAN_ARG_MODE_PROD; > + else if (!strcmp(arg, "full")) > + kasan_arg_mode = KASAN_ARG_MODE_FULL; > + else > + return -EINVAL; > + > + return 0; > +} > +early_param("kasan.mode", early_kasan_mode); > + > +/* kasan.stack=off/on */ > +static int __init early_kasan_flag_stacktrace(char *arg) > +{ > + if (!arg) > + return -EINVAL; > + > + if (!strcmp(arg, "off")) > + kasan_arg_stacktrace = KASAN_ARG_STACKTRACE_OFF; > + else if (!strcmp(arg, "on")) > + kasan_arg_stacktrace = KASAN_ARG_STACKTRACE_ON; > + else > + return -EINVAL; > + > + return 0; > +} > +early_param("kasan.stacktrace", early_kasan_flag_stacktrace); > + > +/* kasan.fault=report/panic */ > +static int __init early_kasan_fault(char *arg) > +{ > + if (!arg) > + return -EINVAL; > + > + if (!strcmp(arg, "report")) > + kasan_arg_fault = KASAN_ARG_FAULT_REPORT; > + else if (!strcmp(arg, "panic")) > + kasan_arg_fault = KASAN_ARG_FAULT_PANIC; > + else > + return -EINVAL; > + > + return 0; > +} [...] The above could be simplified, see suggestion below. Thanks, -- Marco ------ >8 ------ diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c index c91f2c06ecb5..71fc481ad21d 100644 --- a/mm/kasan/hw_tags.c +++ b/mm/kasan/hw_tags.c @@ -64,10 +64,8 @@ static int __init early_kasan_mode(char *arg) kasan_arg_mode = KASAN_ARG_MODE_PROD; else if (!strcmp(arg, "full")) kasan_arg_mode = KASAN_ARG_MODE_FULL; - else - return -EINVAL; - return 0; + return -EINVAL; } early_param("kasan.mode", early_kasan_mode); @@ -81,10 +79,8 @@ static int __init early_kasan_flag_stacktrace(char *arg) kasan_arg_stacktrace = KASAN_ARG_STACKTRACE_OFF; else if (!strcmp(arg, "on")) kasan_arg_stacktrace = KASAN_ARG_STACKTRACE_ON; - else - return -EINVAL; - return 0; + return -EINVAL; } early_param("kasan.stacktrace", early_kasan_flag_stacktrace); @@ -98,10 +94,8 @@ static int __init early_kasan_fault(char *arg) kasan_arg_fault = KASAN_ARG_FAULT_REPORT; else if (!strcmp(arg, "panic")) kasan_arg_fault = KASAN_ARG_FAULT_PANIC; - else - return -EINVAL; - return 0; + return -EINVAL; } early_param("kasan.fault", early_kasan_fault); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel