From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02A63C55ABD for ; Fri, 13 Nov 2020 18:42:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99505208D5 for ; Fri, 13 Nov 2020 18:41:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oFstSJ2e"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="eH+KktJS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99505208D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TJnioG6d+GsJcre6RxvhXQ6m9Tbx2yuDor5LedvHKak=; b=oFstSJ2em/pgx5QBOra/63tRd yRfpFVIRkeWmR/gmjX9T0XhlH4LR0yUOilqvWgsXty5xdsm2jsuhHyHOdw5LbYL6lfdANfIK6NY1D 839uwVKR3alMCtuMfO1cP0x/2irUIDEHzzXpCPLYcG6UM21UD5OrNx6QOhar9LbSmhgp67anhhSmh I7kmkngc4oTf4aliq/euE8oGXpPfq0JEoOxjBqtb3Fza9TQG0tdBp+KBuqvjU7cAomEnVWyq1kE0u gwhxJd40z61lxf+L9dvptZk5smDeZEg+3V5nbaJoDDR4gmfV+AA+T92sAKgerqfeIUfuNL9a2ezUP vXgSP8nfQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kddzn-000664-Bc; Fri, 13 Nov 2020 18:40:27 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kddzi-00065i-VY for linux-arm-kernel@lists.infradead.org; Fri, 13 Nov 2020 18:40:24 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0ADIeLH6056023; Fri, 13 Nov 2020 12:40:21 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1605292821; bh=65UFRQeYElHDRkzVjdvoo314CxPOa/467VA1i7mcb40=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=eH+KktJSQAHJb6XkWc7ipRKxZWz3vTE17QmNDQsRomN5HGKBHm6nR4suBK7nogbz4 Kl7dImz5SvgVSfP3r1T9sK7RnB4bGgzWg7GWQzOY3paWFtF+ViFd/LIXycAoJ9yHw0 7JuyeOC23/UHcNA2SfKwlirnghRvcSdvEWlmua78= Received: from DLEE101.ent.ti.com (dlee101.ent.ti.com [157.170.170.31]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0ADIeL3R008484 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 13 Nov 2020 12:40:21 -0600 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Fri, 13 Nov 2020 12:40:20 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Fri, 13 Nov 2020 12:40:20 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0ADIeKM3066194; Fri, 13 Nov 2020 12:40:20 -0600 Date: Fri, 13 Nov 2020 12:40:20 -0600 From: Nishanth Menon To: Sekhar Nori , Lokesh Vutla Subject: Re: [PATCH 1/3] arm64: dts: ti: k3-j7200-main: Add gpio nodes in main domain Message-ID: <20201113184020.drntugqsnj7dzsnh@ultimatum> References: <20201102191120.20380-1-faiz_abbas@ti.com> <20201102191120.20380-2-faiz_abbas@ti.com> <20201112163953.soia5cje4ry42ujf@kahuna> <6ce6de4b-6e4d-1d2d-aa7a-570d1796d668@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6ce6de4b-6e4d-1d2d-aa7a-570d1796d668@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201113_134023_139297_E334B850 X-CRM114-Status: GOOD ( 15.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Grygorii Strashko , linux-kernel@vger.kernel.org, robh+dt@kernel.org, t-kristo@ti.com, Faiz Abbas , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23:59-20201113, Sekhar Nori wrote: [..] > > dtbs_check: we added: > > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi: /bus@100000/gpio@600000: Missing #address-cells in interrupt provider > > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi: /bus@100000/gpio@610000: Missing #address-cells in interrupt provider > > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi: /bus@100000/gpio@620000: Missing #address-cells in interrupt provider > > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi: /bus@100000/gpio@630000: Missing #address-cells in interrupt provider > > Hmm, running dtbs_check, I did not really see this. These are all the > warnings I see for TI platforms: https://pastebin.ubuntu.com/p/m2my62mjQq/ Here is the full list of checks I ran through with kernel_patch_verify (docker) https://pastebin.ubuntu.com/p/tcnWw89CMD/ See lines 128 onwards for this series. kernel_patch_verify does'nt complain on existing warnings, but just prints when there are additional ones added in. Also make sure we have the right dtc as well dtc 1.6.0 and dt_schema 2020.8.1 was used. > > The tree I am testing is linux-next of 12th Nov + these three patches > applied. > > Also, #address-cells for interrupt provider being compulsory does not > make full sense to me. Nothing in > Documentation/devicetree/bindings/interrupt-controller/interrupts.txt or > Documentation/devicetree/bindings/gpio/gpio-davinci.txt suggests that as > well. > > Existing GPIO nodes for AM654 or J721E does not have #address-cells as well. > > Adding Grygorii as well, in case he knows more about this. Yes - we need to have this conversation in the community :) I had tagged this internally already during the 5.10 merge cycle that we need to clean up the #address-cells warning and in some cases, maybe the bindings are probably not accurate to attempt an enforcement. I'd really like a conclusion on the topic as I recollect Lokesh and Grygorii had a debate internally, but reached no conclusion, lets get the wisdom of the community to help us here. [1] https://github.com/nmenon/kernel_patch_verify/blob/master/kpv -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel