From: Krzysztof Kozlowski <krzk@kernel.org>
To: xiakaixu1987@gmail.com
Cc: linux-samsung-soc@vger.kernel.org,
Kaixu Xia <kaixuxia@tencent.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: samsung: remove the unused variable value assignment
Date: Sat, 14 Nov 2020 16:49:36 +0100 [thread overview]
Message-ID: <20201114154936.GC14208@kozik-lap> (raw)
In-Reply-To: <1605279079-6416-1-git-send-email-kaixuxia@tencent.com>
On Fri, Nov 13, 2020 at 10:51:19PM +0800, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> The value of variable ret is overwritten by the following call
> devm_snd_soc_register_card(), so here the value assignment is useless.
> Remove it.
>
> Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Where can we find the report?
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
> ---
> sound/soc/samsung/smdk_wm8994.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/samsung/smdk_wm8994.c b/sound/soc/samsung/smdk_wm8994.c
> index 64a1a64..1db5b59 100644
> --- a/sound/soc/samsung/smdk_wm8994.c
> +++ b/sound/soc/samsung/smdk_wm8994.c
> @@ -160,11 +160,9 @@ static int smdk_audio_probe(struct platform_device *pdev)
> smdk_dai[0].cpus->dai_name = NULL;
> smdk_dai[0].cpus->of_node = of_parse_phandle(np,
> "samsung,i2s-controller", 0);
> - if (!smdk_dai[0].cpus->of_node) {
> + if (!smdk_dai[0].cpus->of_node)
> dev_err(&pdev->dev,
> "Property 'samsung,i2s-controller' missing or invalid\n");
> - ret = -EINVAL;
This should jump to out/return instead.
Please use script get_maintainers.pl to get the list of people and
mailing lists to Cc. No one would apply this patch otherwise...
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-11-14 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 14:51 [PATCH] ASoC: samsung: remove the unused variable value assignment xiakaixu1987
2020-11-14 15:49 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201114154936.GC14208@kozik-lap \
--to=krzk@kernel.org \
--cc=kaixuxia@tencent.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=xiakaixu1987@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox