From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B57BC5519F for ; Sat, 14 Nov 2020 15:50:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00B3F22254 for ; Sat, 14 Nov 2020 15:50:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VX5ulTsT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00B3F22254 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mYpYEu9y75yiH56izVW5QQfe8+h7ZxEQ932zHrS6hIk=; b=VX5ulTsTZqUTBtqH/K+baFV6p hQK0Hzllp3/3V0v8YvS5iC5zM+a6/OrbAFdiwa4coI0KIjpVxQrQcxcidD2/I/5JFEedoIf2mceHp dLlB8TX52s4xq48KSHztXv3KbR6DLwco2yW2VwLBkVriLoYeNBeySiAN220SHvd+BskvZYb3vde1I Ipn6rYl9r14OCbaCwroTJvRUBRtDL+9YGDKHCnDsUS24Kr8mHHqCIXJ1aT1JG7taGa4SbkEY3CjkN lBddBFuBdgwFCEDy6FhzQCXE2ohxif/2HjWJ93nu6engkRoSam6X5dL3C8+2rctRW5U/ul5ZD5zYN O7swNsUtA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdxo8-0006Av-Jw; Sat, 14 Nov 2020 15:49:44 +0000 Received: from mail-wr1-f68.google.com ([209.85.221.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdxo6-0006A6-8E for linux-arm-kernel@lists.infradead.org; Sat, 14 Nov 2020 15:49:43 +0000 Received: by mail-wr1-f68.google.com with SMTP id k2so13687623wrx.2 for ; Sat, 14 Nov 2020 07:49:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EQ8r5pJttfECMbi7klz393g0n/5XRY+5UKG5qivG/ww=; b=Kkf27UEe3uMmbQFzGvMXkgjh1c1EwFO5YYBLXoT0SfQUnVuviWHnP6VFuEZ2TLONaj Zu15o6gCKHMCV1NsX8T/T2NKIS4Ju1JCSfFSFVcIi51ZHt2m9QfojoxEcjZZylqAGxWs L+63T+DK0dWMTSY66WXZLan+RWcERlqkxtXagPIN2OESvk3ktiScTJUmyP7xjNhhosN5 Q+0VEVLGrUdGKVByFMOkbRqlD8L8b2lq2t9CNgntlLSEG6Y1WgpfFyS0vD8KXv21hafA Gc4SfJljrSmszNqQJ0shZvRsqLRkrjjrNpdO7F/8jJ4+1YtLuuTouU3Ytyqtyyf0Nbuq XJHQ== X-Gm-Message-State: AOAM533TNbvgkDAYJCPo2Lk0RqBgcfKrwJrlTHANOF1Gbm2J2/8JDuGL bVM9B/jjz0jXQaw5HhMuoJw84Y7rR1CVdg== X-Google-Smtp-Source: ABdhPJxrJddT5J8YjMMsQDwJ9FyUwP9ykncQpw8kMv9gUdf9CRy0f46zk3qwOMdEViRo40kcUlKWqA== X-Received: by 2002:adf:e607:: with SMTP id p7mr9885500wrm.93.1605368979245; Sat, 14 Nov 2020 07:49:39 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id w186sm14037275wmb.26.2020.11.14.07.49.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Nov 2020 07:49:38 -0800 (PST) Date: Sat, 14 Nov 2020 16:49:36 +0100 From: Krzysztof Kozlowski To: xiakaixu1987@gmail.com Subject: Re: [PATCH] ASoC: samsung: remove the unused variable value assignment Message-ID: <20201114154936.GC14208@kozik-lap> References: <1605279079-6416-1-git-send-email-kaixuxia@tencent.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1605279079-6416-1-git-send-email-kaixuxia@tencent.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201114_104942_315857_186300B0 X-CRM114-Status: GOOD ( 18.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Kaixu Xia , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 13, 2020 at 10:51:19PM +0800, xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > The value of variable ret is overwritten by the following call > devm_snd_soc_register_card(), so here the value assignment is useless. > Remove it. > > Reported-by: Tosk Robot Where can we find the report? > Signed-off-by: Kaixu Xia > --- > sound/soc/samsung/smdk_wm8994.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/sound/soc/samsung/smdk_wm8994.c b/sound/soc/samsung/smdk_wm8994.c > index 64a1a64..1db5b59 100644 > --- a/sound/soc/samsung/smdk_wm8994.c > +++ b/sound/soc/samsung/smdk_wm8994.c > @@ -160,11 +160,9 @@ static int smdk_audio_probe(struct platform_device *pdev) > smdk_dai[0].cpus->dai_name = NULL; > smdk_dai[0].cpus->of_node = of_parse_phandle(np, > "samsung,i2s-controller", 0); > - if (!smdk_dai[0].cpus->of_node) { > + if (!smdk_dai[0].cpus->of_node) > dev_err(&pdev->dev, > "Property 'samsung,i2s-controller' missing or invalid\n"); > - ret = -EINVAL; This should jump to out/return instead. Please use script get_maintainers.pl to get the list of people and mailing lists to Cc. No one would apply this patch otherwise... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel