From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8089C61DD8 for ; Sat, 14 Nov 2020 16:01:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E0BA22263 for ; Sat, 14 Nov 2020 16:01:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OpG4mV1B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E0BA22263 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PReFMSjOjPnnohmqJBcTp7S0ja7IJiv7qLRilaaWQio=; b=OpG4mV1BG7GMgDmG6zE/dab+2 07Hr/mXVAg8BN6TRTcRzVl7t5ZrE6Cwu0+7Lrt1E5uB60njM3Jd1JJbmzWkueQ3XZo1eOCjh42JXi Wg9KMQrw+pBhE3VgnXgZc3ffP6oBpNfnYFtIGAOP+R/Frw87raNlazg1Iuyv57rB6LnGCDPRRZwzz lg/yUSs2moxApIGri6EW2P2zRyNdm9xEO5MhuJtB2pJ8lBitsaiZL0qSxY5WI0s/KC67LlvVF1eez LO6yVslh03wTNlNHe9iNLxy61CCAUI/AoGyb0jzO3OuwtwVgEN/GN5NwkwYAUyfAagTvlPoVdh66x WrmlD6E2A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdxz1-0007Le-Ob; Sat, 14 Nov 2020 16:00:59 +0000 Received: from mail-wm1-f68.google.com ([209.85.128.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdxyz-0007LD-Fa for linux-arm-kernel@lists.infradead.org; Sat, 14 Nov 2020 16:00:58 +0000 Received: by mail-wm1-f68.google.com with SMTP id c16so19100290wmd.2 for ; Sat, 14 Nov 2020 08:00:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ktcJH8TIO4zsVVKEg+gtHPaiImzQ8Lzm0V35yxlND+Q=; b=oWK17wzLGuwn9mIWclzy0WQH5K18FcEqO4hH+EdG5Q5+5P93A1/41LsAfKN5pqT4TA GLS0STYufWLKY7ayHuxopxsZTWqexBjMIy5x7SI+Hx4QM6vE+h3Y5KiF21c1b1w0VrMV gnRv4S8VzXJl1kMHrILWbOqqzjX64OwD+mx9ToncxC3U/quQnKdCqBsRRChKvWC4Jfrf iX/uYfOaQ0G8Tsz0x6X9DNAHokrKxt8Ky6Y3tBN1D9SHiNIwwPaBpBEohyFfYpGWESAC 01vG34IfQfr2mb8VwhXazSL9fCtZo05p0+EoGChsO79foS5jdo89fp26RezJ9HosGua+ WNtA== X-Gm-Message-State: AOAM53030VXcYEASymxAEH/kUfjGulF5odxnKMv13EDp8vKLT5Vtfkyn XfJfFr7y0PYD3mLXfS5iC4Y= X-Google-Smtp-Source: ABdhPJxdgy7ENtxm9ZZKd5kxwXE3hq/x/9jC8C9fx9r2p4SlZOO+6axS+nbGnOgTfE+9mgni8wMIkg== X-Received: by 2002:a1c:6456:: with SMTP id y83mr7697917wmb.59.1605369655021; Sat, 14 Nov 2020 08:00:55 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id g131sm14364836wma.35.2020.11.14.08.00.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Nov 2020 08:00:53 -0800 (PST) Date: Sat, 14 Nov 2020 17:00:52 +0100 From: Krzysztof Kozlowski To: Alice Guo Subject: Re: [PATCH v3 3/4] arm64: dts: imx8m: add nvmem-cell related stuff Message-ID: <20201114160052.GC14989@kozik-lap> References: <20201113110409.13546-1-alice.guo@nxp.com> <20201113110409.13546-3-alice.guo@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201113110409.13546-3-alice.guo@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201114_110057_552692_A5F71F15 X-CRM114-Status: GOOD ( 13.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, peng.fan@nxp.com, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-imx@nxp.com, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 13, 2020 at 07:04:08PM +0800, Alice Guo wrote: > Add nvmem-cell related stuff for the soc unique ID. Do not silently ignore comments during review. Let me repeat my comment from v1: Subject and commit msg: please do not add "stuff" but describe what are you adding and why (what is the purpose, feature, benefit). "Stuff" is too generic. I can rephrase it, since maybe I was not understood. Do not use words like "stuff" or "thing". Instead describe exactly what you are adding and answer to the most important question: why are you adding it. Best regards, Krzysztof > > Signed-off-by: Alice Guo > --- > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 6 ++++++ > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 6 ++++++ > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 6 ++++++ > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 6 ++++++ > 4 files changed, 24 insertions(+) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel