From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7852C5519F for ; Sat, 14 Nov 2020 20:03:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6AF8822370 for ; Sat, 14 Nov 2020 20:03:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="d+f/icKR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AF8822370 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mHrrwM4Wf6ri0/cGkLj3+oL9NIwdYMPd/aCTiOlgZl8=; b=d+f/icKRN7Rfnr76OXQERztpF eXhPOuyanIEHQWYQXgMJuoMZpjYSquH9xn2equozdZYgc9MttX0RJdb9j46mf0wjU2E26aGiuY6YS nQWmD6M+mKfm4m3LqQl1AuiYYrMKqXpzSYJPcqA6/NlS+uiH4Jtbh6K15hhxESi9ijh/K5dNpAgks xoLYV7Ps42rsHTmbLYzST0247Nsg9SyWtLm7X4n6koOBRlB8o7U1Y3ESholBAEJy/0U/OLKXgI9xz fvu7xUSd+xwMfK0MNdFdAS8HHU5XvtdLnGvSLahsK03mnRdNKATM8Ag5hpLFp2shX5TmTXKXLV5uV EuKgjb1ow==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ke1lM-0004aR-Al; Sat, 14 Nov 2020 20:03:08 +0000 Received: from asavdk4.altibox.net ([109.247.116.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ke1lI-0004Vn-Ok for linux-arm-kernel@lists.infradead.org; Sat, 14 Nov 2020 20:03:06 +0000 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 9F7B08054C; Sat, 14 Nov 2020 21:02:52 +0100 (CET) Date: Sat, 14 Nov 2020 21:02:51 +0100 From: Sam Ravnborg To: Linus Walleij Subject: Re: [PATCH v2] dt-bindings: display: mcde: Convert to YAML schema Message-ID: <20201114200251.GD3900471@ravnborg.org> References: <20201111130754.2283993-1-linus.walleij@linaro.org> <20201111205857.GB3013948@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VafZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=1O0MGL_9nWPLu35SrL0A:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=AjGcO6oz07-iQ99wixmX:22 a=cvBusfyB2V15izCimMoJ:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201114_150305_090914_0594B6A9 X-CRM114-Status: GOOD ( 27.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Maarten Lankhorst , Maxime Ripard , Rob Herring , "open list:DRM PANEL DRIVERS" , Sean Paul , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 12, 2020 at 01:19:34PM +0100, Linus Walleij wrote: > On Wed, Nov 11, 2020 at 9:59 PM Sam Ravnborg wrote: > > On Wed, Nov 11, 2020 at 02:07:54PM +0100, Linus Walleij wrote: > > > > -- clocks: an array of the MCDE clocks in this strict order: > > > - MCDECLK (main MCDE clock), LCDCLK (LCD clock), PLLDSI > > > - (HDMI clock), DSI0ESCLK (DSI0 energy save clock), > > > > > - DSI1ESCLK (DSI1 energy save clock), DSI2ESCLK (DSI2 energy > > > - save clock) > > > > I did not find these two clocks in the binding below. > > The old bindings are wrong. These clocks belong on the DSI > host adapters, so they are in this part of the binding: Please include this info in the changelog to avoid confusing others. > > + clocks: > + description: phandles to the high speed and low power (energy > save) clocks > + the high speed clock is not present on the third (dsi2) block, so it > + should only have the "lp" clock > + minItems: 1 > + maxItems: 2 > + > + clock-names: > + oneOf: > + - items: > + - const: hs > + - const: lp > + - items: > + - const: lp > > All device trees have these in the right place, we just didn't notice that > the bindings were wrong exactly because we weren't using > formal YAML syntax. Now the strictness of this parser makes me > fix my bugs... > > > > + port: > > > + type: object > > > + description: > > > + A DPI port node with endpoint definitions as defined in > > > + Documentation/devicetree/bindings/media/video-interfaces.txt > > > + > > > + "#address-cells": > > > + const: 1 > > > + > > > + "#size-cells": > > > + const: 1 > > > + > > > + ranges: true > > > > This is a transition from .txt to DT Schema so OK with this sub-node. > > But otherwise the dsi node should have been linked using graph nodes. > > So OK - just thinking out loud. > > Actually when I introduced the MCDE DSI last year at first I used port > and graphs: > https://lore.kernel.org/dri-devel/20190207083647.20615-3-linus.walleij@linaro.org/ > Then Rob asked "why?": > https://lore.kernel.org/dri-devel/20190225223124.GA29057@bogus/ > And then I removed it, as having a panel directly under a > DSI host is fine. OK, thanks for the explanation. > > > > +patternProperties: > > > + "^dsi@[0-9a-f]+$": > > > + description: subnodes for the three DSI host adapters > > > + type: object > > > + allOf: > > > + - $ref: dsi-controller.yaml# > (...) > > The dsi nodes needs the #address-cells and #size-cells - at least if a > > panel node is specified. > > This is specified in the referenced schema dsi-controller.yaml. > > > > +required: > > > + - compatible > > > + - reg > > > + - interrupts > > > + - clocks > > > + - clock-names > > > + - epod-supply > > > + - vana-supply > > > + > > > +additionalProperties: true > > > > Why are additional properties allowed here? > > It's because the SoC peripherals have things like pin control > (currently handled by a quirk in the YAML validator I think) and > resets is something else I will likely add at some point, and then > this would result in warnings unless I lock-step changes in the > schema and DTS files. > > I *can* disallow this if you insist. Add reset now as an optional property and you are covered. The HW does not change, and this describes the HW and not the drivers. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel