From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9811C5519F for ; Mon, 16 Nov 2020 12:47:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A9142137B for ; Mon, 16 Nov 2020 12:47:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vOQMpjng" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A9142137B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QP7iwlrBeL6o0LB/Q/yz9ZRFu5HtH3KSLEE5wxRBD6g=; b=vOQMpjngfQxCrJz2y+KMI04TA hCGZ1gAKtWDrZsJ4vJGyF4KVk7MCdLy5JXILnz5SrLDKd9GdCG0mseCgA7z9PwIgoLbdo75NZ9xxc UxAZ+BWQ0BvyV+Y9cjGS+NVKvlV+ubCStwjvh953RLhkKbP3IqxWC8zqvJwdOySFaZZXvLh88ZHSR CCWR6gWBklOk/l3DnJp9l2xH0Kwl/wLT4SVKTU5dLuj7LyKedfzKKQ+r2dpPlTIvOIEe1TU4DAcPS vTDy9O+xid5pjRsQSXN3NxqwVF4OP9ctRiR/wBfA0TTj8fWqQB2VE+FHM5Ij8DKARj5QB1jHGTDDF JL+WHwpeA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kedaC-0006xe-9Y; Mon, 16 Nov 2020 12:26:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kedaA-0006ws-Nk for linux-arm-kernel@lists.infradead.org; Mon, 16 Nov 2020 12:26:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4F6B91042; Mon, 16 Nov 2020 04:26:04 -0800 (PST) Received: from C02TD0UTHF1T.local (unknown [10.57.54.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A5EF93F70D; Mon, 16 Nov 2020 04:26:02 -0800 (PST) Date: Mon, 16 Nov 2020 12:25:59 +0000 From: Mark Rutland To: Christoph Hellwig Subject: Re: [PATCHv4 08/17] arm64: uaccess: move uao_* alternatives to asm-uaccess.h Message-ID: <20201116122559.GB1381@C02TD0UTHF1T.local> References: <20201113124937.20574-1-mark.rutland@arm.com> <20201113124937.20574-9-mark.rutland@arm.com> <20201114092215.GA18650@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201114092215.GA18650@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201116_072606_832454_76A6A71A X-CRM114-Status: GOOD ( 11.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, will@kernel.org, james.morse@arm.com, linux-arm-kernel@lists.infradead.org, robin.murphy@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Nov 14, 2020 at 10:22:15AM +0100, Christoph Hellwig wrote: > > +#ifdef CONFIG_ARM64_UAO > > + .macro uao_ldp l, reg1, reg2, addr, post_inc > > + alternative_if_not ARM64_HAS_UAO > > +8888: ldp \reg1, \reg2, [\addr], \post_inc; > > +8889: nop; > > No actually new in this patch, but that is the reason for these horrible > label names? It's a historic way of having non-conflicting labels. I also hate it, and intend to clean it up subsequently. The new/preferred way for labels in asm macros is to use a descriptive local label with a '\@' suffix to ensure true uniqueness, e.g. | .macro foo | cbz x0, .Lskip\@ | mov x0, x1 | .Lskip\@: | .endm ... which I assume is what you'd also like here. Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel