From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD4EEC388F9 for ; Tue, 17 Nov 2020 03:19:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41E572469D for ; Tue, 17 Nov 2020 03:19:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YaPJA/A6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=Synaptics.onmicrosoft.com header.i=@Synaptics.onmicrosoft.com header.b="nOz6BlLj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41E572469D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=synaptics.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rxTDf2fWu5OzqS26XFDnwAT1H3EPgGciJV6CC60qWog=; b=YaPJA/A6XtvPb+6eCdEl8nzS8 CpG4iRxNBRbksJfSXXjxaOW0sIq7g1y4R22hM9iv+GG2tW4eEU4FhQZJnzNTAx27bLQZ4n7afSja8 +2FlFhhdfRhlbJ2J3GjEVG32O6dkSxj0Q9tvZAukCtJYCFU7EWagVDJS3jMkNmj49DOkHQzCYKWtB JJ6sIv3RLhIICz2SR6fqsJkUcAMHnOSeHNxHAEv1teL9g8qfYW+ri7KVlUtwFTwt8gd2flLkDCJdC 96u6Cn+sjTvAZ4JnGr7rzGjUWbjgRUZsmuYIZk47Mx8InyHpSqh5kxTAyaNqopM9m4G947IlrRza7 Nai486rRA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kerWS-0004Ra-O8; Tue, 17 Nov 2020 03:19:12 +0000 Received: from mail-eopbgr690041.outbound.protection.outlook.com ([40.107.69.41] helo=NAM04-CO1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kerWP-0004Pu-FH for linux-arm-kernel@lists.infradead.org; Tue, 17 Nov 2020 03:19:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oPsBmA8XmWtcQqiU4bjm0fWdkaCebmCODPno0+8PJ5L/Y8kkN1tNB3B+LeUj1KVUEBwMAklCM0AyMV3bD26oF+lzZHDcylQdNU9L1qEKtCT3iiOVZUC/TDLxv5XAbATphGvtvVI+K23hiJP0V22t2zLD60ypd7PupmcQCtK7ml82ERUNQe1uJNxZ/+pA6gBtspRR9izZmOZeT8r96+MIuP8jRrMxSlNuSx0BCTVMgGCYmMc6gUL4FMRmRmzvSTlcqg7HtrjQ3SMXsX0J6RfMw/JyMgbqEI+wDYAnvGSppeh9v16zhqKNQY5MXVHI+ysy9OvXxS+T+kEFLv4MEgcEMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kUnWaaapdjkRsN1w6IHXbyggmBVOYC6auz8XwJuUDYA=; b=Akc863HhZ1gnPs/gRV4BQbb6fUrF2w4wdJK9AXz8Kz5NK39dRVgYxPlNPt0S8j4Ew6edkPCB1emMNGR++M/Iap2xPZtTbUZis/kgxj2juKuO81718BUQljdqYb3kBgu8X0hEZXsonTifOSLY1wKpvwSUtZVSykL1s2NYRhmpKjpDAZVo6q8QA20iihUo7+a3XXlBx0YXboc0UJR2yPY7M/xa0YLfoFzhZxCxfNEg9Asro8aKnDRMZmNFlJG8zL7dDWUcnUQVnoFWkKYv+at41a35lsVU0W9gyUkBtklFT6ePHMXLGhBkUJoNIDwqAROckbrdA8senkvM6TmAyzdhfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=synaptics.com; dmarc=pass action=none header.from=synaptics.com; dkim=pass header.d=synaptics.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Synaptics.onmicrosoft.com; s=selector2-Synaptics-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kUnWaaapdjkRsN1w6IHXbyggmBVOYC6auz8XwJuUDYA=; b=nOz6BlLjonHHSkOTxHszIz/5jv+76GBZy9K8OuqgUpyrcbr1wVTSSdF1JZrQpQynRqE1OAKd/GLeFaXHmnD3f0vnOMz5Fm/T18aJcGNQyfDfCVF0cU+lhTBgJRjBimYF9EzLp4SyRy9IEsMmTrnM5Y8sf5AmXdpcz7x5up4p6Gs= Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=synaptics.com; Received: from SN2PR03MB2383.namprd03.prod.outlook.com (2603:10b6:804:d::23) by SN6PR03MB4287.namprd03.prod.outlook.com (2603:10b6:805:bb::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.28; Tue, 17 Nov 2020 03:19:04 +0000 Received: from SN2PR03MB2383.namprd03.prod.outlook.com ([fe80::412b:8366:f594:a39]) by SN2PR03MB2383.namprd03.prod.outlook.com ([fe80::412b:8366:f594:a39%9]) with mapi id 15.20.3564.028; Tue, 17 Nov 2020 03:19:03 +0000 Date: Tue, 17 Nov 2020 11:18:55 +0800 From: Jisheng Zhang To: Wonhyuk Yang Subject: Re: [Question] arm64: head: invalidating stale cache with mmu off Message-ID: <20201117111855.0298e544@xhacker.debian> In-Reply-To: References: X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) X-Originating-IP: [192.147.44.204] X-ClientProxiedBy: BY3PR04CA0001.namprd04.prod.outlook.com (2603:10b6:a03:217::6) To SN2PR03MB2383.namprd03.prod.outlook.com (2603:10b6:804:d::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from xhacker.debian (192.147.44.204) by BY3PR04CA0001.namprd04.prod.outlook.com (2603:10b6:a03:217::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Tue, 17 Nov 2020 03:19:02 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fc2796c6-e2eb-47c7-cd95-08d88aa788f1 X-MS-TrafficTypeDiagnostic: SN6PR03MB4287: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3826; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2kE2UBlRUdd1hk7ft9WLeyePhkc7lO5jQlX0H0UUVdesgq+7R67uhxfa/7j6SqWUGAsmn7/WJ6p3dey9dcRwJ3FTf1fG3E6pvO13G8qZ2agNKznaInYQuI8LdwKlAbBUa/5cR2X84z7gVbSfpfOTQ2g2eE189Gbok6sUQs+Q289HvK872me+ykko9BmiyVEqtU9ouzA18YowK66O0ZoYWcrNzLTPnIhAonvqfz8beIE3tFq0I7mmoxz/CcYCEtS8gmAajm6wC+PEn6nxflLiHb8S0elHb9y1fIHZx62jTcNuZuB44ypeXHyOkq/F8gOYQh0omVMrtSriXvxAZm3GWw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN2PR03MB2383.namprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(346002)(366004)(136003)(39860400002)(956004)(7696005)(16526019)(55016002)(4326008)(52116002)(26005)(6506007)(83380400001)(186003)(9686003)(66476007)(478600001)(6916009)(5660300002)(316002)(54906003)(86362001)(8676002)(1076003)(2906002)(6666004)(66556008)(8936002)(66946007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: N+xDgvS84zC/g1b9uVpbUZkPWtIx52CZnndr9s6mYMuqpcGsYo8TDRGokjaBanP7tn9XWL/sJm/3nrcRPxccWnSt1RmFBxaFGLvYAaGX3uCCEmHg46tzA/ReM/l558JAoPjhFJIavdKZLpVT+8XeJQffSSWA7/E7DYBqYstJDTqyYGCeTpNbCnrrc7QBkPSuZ1Pio8tEiM4cghnizqb87z2rYzuNePIFQQ2Kw4ofgCacRboaTGz3wzg3xvfjsxAA/m2s2/IfEowcdvllq3h7Xa5k/mGlzBkLUP4lHGkdwgcCV0AQNgC20rZIu5BsGp2njmt1dw4dualr+WoGEmyWoo0GRzrt/K6DrazqnYfcZ3BatweBNbE0hwIeW2C0EDhkZFmrOvUQ6jXII1IqWrwP0EkwULUFE+wTe7glGoutCeF7s1N7kAwL/hGROCg/nRlgfT467zeazNN6rvXwvi0E1l1CN1MSXFrqnhSCkNsGmHDspFDHasApcVP0pIAGKQZIS/g41+P3Z6PbM5mx3Famd7ldF0mgiQi7FTIcUJ5oQoFZvB8WWdMKQoNRETDuwDZ3rt7Wmh349qdjCaGYqFJoy3xidyLStFTxkdpps6H0dGJHq3Xm7QQ3lIVo52wObTPnCaXNJsuWQVyruNKkgtkOVA== X-OriginatorOrg: synaptics.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc2796c6-e2eb-47c7-cd95-08d88aa788f1 X-MS-Exchange-CrossTenant-AuthSource: SN2PR03MB2383.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2020 03:19:03.7463 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335d1fbc-2124-4173-9863-17e7051a2a0e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3nWfyLgr8HsP1tevcQvMyNSrcNzxkCLZLcUbSSoT+ZlIWTWrC/4iFGAJH5V+H76kCtR5PQLtGJyf/nl5305cyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4287 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201116_221909_716812_67D6DABD X-CRM114-Status: GOOD ( 17.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Will Deacon , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 17 Nov 2020 09:52:10 +0900 Wonhyuk Yang wrote: > > > Hi, I have a question about dmb barriers in arm64's head.S. > In the head.S, I could see the pattern below several times. > > str w0, [x1] > dmb sys > dc ivac, x1 // Invalidate potentially stale cache line > > I found that, > arm64: head: fix cache flushing and barriers in set_cpu_boot_mode_flag > commit: d0488597a1b71 > explained this code. > > > This patch reworks the broken flushing code so that we: > > > > (1) Use a DMB to order the strongly-ordered write of the cacheline > > against the subsequent cache-maintenance operation (by-VA > > operations only hazard against normal, cacheable accesses). > > > > (2) Use a single dc ivac instruction to invalidate any clean lines > > containing a stale copy of the line after it has been updated. > > Use a DMB to order the strongly-> ordered write of the cacheline > > But I still don't understand why the store operation should precede the > dc operation. > > Is there any problem, if the dc operation precedes the store operation? > Just my opinion: If dc op precedes the store, speculatively fetch of system cache or arch cache for guest os after the dc could still bring coherence problems when the var is checked later. I.E consider below sequence: dc ivac speculatively fetch of system cache or arch cache for guest os str w20, [x1] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel