From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6CC3C5519F for ; Wed, 18 Nov 2020 03:13:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 353C024698 for ; Wed, 18 Nov 2020 03:13:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TJTSzOdx"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CWX89Bo+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 353C024698 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=o+/QbXXPlNW8RCDMjAs2qmgVdaxLwFOPcI+L2BsEv1w=; b=TJTSzOdx+2c22L/cdYAYBR+5u dZl+dcQD2geX+KzCrcRb7s4zkZ4sYKKRB1ZjtVEmMclGgBYGuIcK3x1st6KTL/9dkBu1Uh6lrmAD3 OMC5Va5RBDDc7AHTiHYuTXr+mfjiYEB73hu4MZImJ5LRmkoljbZIYWvpb+OP1pGwCoZkDevTarFUV hwpH2uoq8RhntxXEd0+Q5M7QeLtjN5ciHD9QhPHy3SwIJRp+o9jUFSgyLR9YxPzo4/Xv+W8mignWZ 9njMpx26ULW6wXQj1K6o/k9hA6RMhtc45hXuXNyJ/XBLbSzEtlAQi1K8D1odVvYoaAmksKr0/+suH vczK031mA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfDu3-0006ef-Gz; Wed, 18 Nov 2020 03:13:03 +0000 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfDu0-0006dx-W2 for linux-arm-kernel@lists.infradead.org; Wed, 18 Nov 2020 03:13:02 +0000 Received: by mail-qt1-x843.google.com with SMTP id b16so647918qtb.6 for ; Tue, 17 Nov 2020 19:13:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HgvttKSz6Ny3sSVlQN/E9G/7G2kWLjw/Bo0sdK0fdRk=; b=CWX89Bo+RFqfV61MMdOpdtn/KsRiAv0G0nWF2X55CWUA3vxzkGmwgNiYrMRFCHUiB/ o0l8A6oe7FDsV+fo36st+m1IqF34qmR/K5FK0pDOVozjatjBMqp+aiaYhnVO0JMvUfmW 97CpMbMaCSWeQsTkCc7Y5BqlIGPIRHqIJ8MMyLx0f2BZz29e282yoOJyhPQM7GjwI+0B XFIC5yRLu6obhArZoDhs4yD0XZ1ZfH5DHBWQytkK5H1wp0zeG5ZF5Fud9EKQk8dX9LqT PSdC1hq90vaC4bpCLuG0I8nY+S/q1MaNGb/xdIbbSpX8361oQ6V/d1/NUfKzZ9vwAtDU 82Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HgvttKSz6Ny3sSVlQN/E9G/7G2kWLjw/Bo0sdK0fdRk=; b=o2ZnBaicNEqC5K1kmdeRvK2WQLKTVOAnqC6BAdyQ1oq/0VSTjOvz5s5R24bUIT8/4t Z0AzLygYe5zb9max2lajBUU7Ouw3nSm5AzO0ZwQOxjz9ObmWNmJKfKNdhpuJq6JQnA2y q8Q0NAMhC2ZLZZmif2DyaC2FpYlrHCfzngCEtbzsYwS7uYRUnIAemWXAUyhNNVZ2VVJi Vavz0Q1GFWwvyuq2syl96O4D63TAi+n7EuSHRamFcZGTP2yrlNOs/d/QE9ejw6N9ylTT Fgg0aOFvefGvB/ZR0nujGt0+gfghPUKsnZmWQ4pUV+bD0csDggFAjnLkEwEXUw78/xyK 0EEA== X-Gm-Message-State: AOAM532pUl+UT0Zx+Ti/xhUhSY/vN9kfcM+dif/uIo2Gy2XZVZ7uvWcN eQiFVqj7J8wZek415i633Ug= X-Google-Smtp-Source: ABdhPJzuIDnMCVG5Tuz116cq6Z1nlyfDBVH+eUiGr+rwEJQdkH3cFq7bPI+slF+97TRva76BZFWfMA== X-Received: by 2002:aed:2051:: with SMTP id 75mr2388981qta.332.1605669179405; Tue, 17 Nov 2020 19:12:59 -0800 (PST) Received: from ubuntu-m3-large-x86 ([2604:1380:45f1:1d00::1]) by smtp.gmail.com with ESMTPSA id h11sm15438617qtr.13.2020.11.17.19.12.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 19:12:58 -0800 (PST) Date: Tue, 17 Nov 2020 20:12:57 -0700 From: Nathan Chancellor To: Kees Cook Subject: Re: [PATCH 2/2] kbuild: Disable CONFIG_LD_ORPHAN_WARN for ld.lld 10.0.1 Message-ID: <20201118031257.GB1001457@ubuntu-m3-large-x86> References: <20201113195553.1487659-1-natechancellor@gmail.com> <20201113195553.1487659-2-natechancellor@gmail.com> <202011171350.F95127F@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202011171350.F95127F@keescook> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201117_221301_080852_B0095736 X-CRM114-Status: GOOD ( 15.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Marek , "kernelci . org bot" , linux-kbuild@vger.kernel.org, Mark Brown , Catalin Marinas , Masahiro Yamada , x86@kernel.org, Nick Desaulniers , Russell King , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Arvind Sankar , Ingo Molnar , Borislav Petkov , clang-built-linux@googlegroups.com, Michael Ellerman , Thomas Gleixner , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 17, 2020 at 01:51:43PM -0800, Kees Cook wrote: > On Fri, Nov 13, 2020 at 12:55:53PM -0700, Nathan Chancellor wrote: > > config LD_ORPHAN_WARN > > - def_bool ARCH_WANT_LD_ORPHAN_WARN && $(ld-option,--orphan-handling=warn) > > + def_bool ARCH_WANT_LD_ORPHAN_WARN && $(ld-option,--orphan-handling=warn) && (!LD_IS_LLD || LLD_VERSION >= 110000) > > Readability nit-pick... I prefer separate "depends" lines to make things > a little easier to parse, change, etc: > > config LD_ORPHAN_WARN > def_bool y > depends on ARCH_WANT_LD_ORPHAN_WARN > depends on !LD_IS_LLD || LLD_VERSION >= 110000 > depends on $(ld-option,--orphan-handling=warn) > > Otherwise, yeah, looks good to me. With this and the other suggestions, > please consider it: > > Reviewed-by: Kees Cook Thank you, I have updated it locally for v2! Cheers, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel