From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36BCAC5519F for ; Wed, 18 Nov 2020 15:04:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5B5824733 for ; Wed, 18 Nov 2020 15:04:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="W6kaFUFp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5B5824733 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DvFZhbr2VaA/PPfrGmAXUujKcXYGsmiEYaDeXjQ7fbg=; b=W6kaFUFp8EmG6SoxtM/uaCTJ6 kE5JswoCbngnRok2bMPmgjiLrVc+Z26v5/ThCtNxY3xFNkfDTvb5nHWkDpz6YxTuw4RnrMhLEJuYj jRFBUIQFaxXc6egVHmw452lKeuCSuRSAej0f7Svch2MWEqjbT2y8HjrtuYo+i/8krNx04qZkYiQB6 IiCkUc3rV8o3OOz5wSepYAj1CydIsayq1xwhWIrz+3Cj6A8pnyst7Y2xvAaLdxEG8kVdMe2a2xZOe 04381ltH07Ae3ueQBTaRxuL3pQpRe42tMGpIVXBN1QQMMZIUxfQkCUkPJupyG87xubO+MmjI6+DU8 Hk/bZ0gNA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfOzq-0000vC-Jc; Wed, 18 Nov 2020 15:03:46 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfOzo-0000tu-38 for linux-arm-kernel@lists.infradead.org; Wed, 18 Nov 2020 15:03:45 +0000 Received: from sekiro (lfbn-mar-1-625-225.w90-118.abo.wanadoo.fr [90.118.2.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6624D24740; Wed, 18 Nov 2020 15:03:40 +0000 (UTC) Date: Wed, 18 Nov 2020 16:03:36 +0100 From: Ludovic Desroches To: cristian.birsan@microchip.com Subject: Re: [PATCH 0/3] ARM: dts: at91: add pincontrol node for USB Host Message-ID: <20201118150336.g3u3ljuhrbrn2cko@sekiro> References: <20201118120019.1257580-1-cristian.birsan@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201118120019.1257580-1-cristian.birsan@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201118_100344_232324_5F6B5641 X-CRM114-Status: GOOD ( 20.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Cristi, Adding the gpio list. On Wed, Nov 18, 2020 at 02:00:16PM +0200, cristian.birsan@microchip.com wrote: > From: Cristian Birsan > > The pincontrol node is needed for USB Host since Linux v5.7-rc1. Without > it the driver probes but VBus is not powered because of wrong pincontrol > configuration. The patch was tested on SAM9x60EK, SAMA5D4-EK and SAMA5D3-EK. > No problem on my side with this set of patches, it's consistent with what we have. Acked-by: Ludovic Desroches I just want to share the full picture leading to this situation. You told me the breakage appears after this commit: commit 2ab73c6d8323fa1eb02c16c07c40ba2ed17da729 Author: Thierry Reding Date: Thu Mar 19 13:27:29 2020 +0100 gpio: Support GPIO controllers without pin-ranges Wake gpiochip_generic_request() call into the pinctrl helpers only if a GPIO controller had any pin-ranges assigned to it. This allows a driver to unconditionally use this helper if it supports multiple devices of which only a subset have pin-ranges assigned to them. Signed-off-by: Thierry Reding Link: https://lore.kernel.org/r/20200319122737.3063291-2-thierry.reding@gmail.com Tested-by: Vidya Sagar Signed-off-by: Linus Walleij We were used to defining pinctrl for all our pins. That is somewhat redundant when the pin is requested through the gpiolib. The pinctrl-at91 driver doesn't register any pin range. After this commit, the gpio_generic_request() fails. The consequence is if we forgot to define the pinctrl, the pin won't be muxed as a gpio. At first glance, there is no trivial way to register the pin range in the pinctrl-at91 driver. There is one driver for the pinctrl and one for the gpio. I am open to suggestions to fix it in the pinctrl-at91 driver as well if there is an elegant way (I have some in mind, but there are not) without having to refactor the driver. Regards Ludovic > Cristian Birsan (3): > ARM: dts: sam9x60: add pincontrol for USB Host > ARM: dts: at91: sama5d4_xplained: add pincontrol for USB Host > ARM: dts: at91: sama5d3_xplained: add pincontrol for USB Host > > arch/arm/boot/dts/at91-sam9x60ek.dts | 9 +++++++++ > arch/arm/boot/dts/at91-sama5d3_xplained.dts | 7 +++++++ > arch/arm/boot/dts/at91-sama5d4_xplained.dts | 7 +++++++ > 3 files changed, 23 insertions(+) > > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel