From: Will Deacon <will@kernel.org>
To: Youling Tang <tangyouling@loongson.cn>
Cc: Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>, James Morse <james.morse@arm.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
David Brazdil <dbrazdil@google.com>,
Ard Biesheuvel <ardb@kernel.org>, Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH] arm64: vmlinux.lds.S: Drop redundant *.init.rodata.*
Date: Thu, 19 Nov 2020 09:06:39 +0000 [thread overview]
Message-ID: <20201119090639.GD3599@willie-the-truck> (raw)
In-Reply-To: <f1c18bdb-69a5-9260-d931-69f6bc926170@loongson.cn>
On Thu, Nov 19, 2020 at 04:32:48PM +0800, Youling Tang wrote:
> On 11/19/2020 03:18 PM, Ard Biesheuvel wrote:
> > On Thu, 19 Nov 2020 at 02:45, Youling Tang <tangyouling@loongson.cn> wrote:
> > > We currently try to emit *.init.rodata.* twice, once in INIT_DATA, and once
> > > in the line immediately following it. As the two section definitions are
> > > identical, the latter is redundant and can be dropped.
> > >
> > > This patch drops the redundant *.init.rodata.* section definition.
> > >
> > > Signed-off-by: Youling Tang <tangyouling@loongson.cn>
> > .init.rodata.* was added to INIT_DATA in
> > 266ff2a8f51f02b429a987d87634697eb0d01d6a, so removing it here seems
> > reasonable. However, it does conflict with the for-next/lto branch in
> > the arm64 tree.
> >
> The possible causes of the conflict are e35123d83ee submit.
>
> master branch code as follows:
> ...
> INIT_RAM_FS
> *(.init.rodata.* .init.bss) /* from the EFI stub */
>
> for-next/lto branch code as follows:
> ...
> INIT_RAM_FS
> *(.init.altinstructions .init.rodata.* .init.bss) /* from the EFI stub
That looks trivial enough for us to sort out, especially if this patch can
wait until 5.11 (I think it can).
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-19 9:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 1:45 [PATCH] arm64: vmlinux.lds.S: Drop redundant *.init.rodata.* Youling Tang
2020-11-19 7:18 ` Ard Biesheuvel
2020-11-19 8:32 ` Youling Tang
2020-11-19 9:06 ` Will Deacon [this message]
2020-11-19 9:07 ` Will Deacon
2020-11-27 19:12 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119090639.GD3599@willie-the-truck \
--to=will@kernel.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dbrazdil@google.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=rppt@kernel.org \
--cc=tangyouling@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox