From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74539C2D0E4 for ; Thu, 19 Nov 2020 09:19:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C640E221EB for ; Thu, 19 Nov 2020 09:19:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0AE9SCf0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="SiGcoM1Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C640E221EB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kl/6LzNv4uu/034n/f8YWY1GM1peneJm0mhjwWmjPD4=; b=0AE9SCf0C8Sj7dIAgd7ESxYIb z0pJQc9D2OU20ksJ+b4S4NzJuZo45F5ZP5fz/gyn9Mjko0wGsjnOTr4BKbLWJqzXnq8Xr6Ye3uyHV QSNssMP2FmzYAJ18K4c0AZw58vOlTwEf54/RbtgbhJC48xGfijHZXDVk2NQmubQl+ci6z9qy2GiqH E4MfzVFbI/f6/tBTcOjP/GybQWlu4ypeyv5be4PxOiCPjiK4Y7XUJ311VyXIjAI2SzQyTks1baIqN b3lGzEzJ6OtEBxpXxseIjLn0XUyWhY4T+ZRZi9I1/mm5CMQevDKwwHYOlJEBNJ60l+943MDjoQYuE tDnwYWAIA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfg5L-0005k2-JI; Thu, 19 Nov 2020 09:18:35 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfg5D-0005ig-4y for linux-arm-kernel@lists.infradead.org; Thu, 19 Nov 2020 09:18:28 +0000 Received: by mail-wr1-x435.google.com with SMTP id u12so5692070wrt.0 for ; Thu, 19 Nov 2020 01:18:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IdO73wPUtO91VkHNoPsos+au3LYwQYAXfz1yiydAPjw=; b=SiGcoM1Z7UHzA4JfGM1ADc64LSJObWD3rK3mEabHpVq+qsFkyqIgfWSUClkF7e3P0a mKFhGum+0JZb1YcCdG5O/7uy/cMY9n3BY4b9FtY9fAi/OUtd/2O9UfKfYNjDU3lfk1Vv CoNWUnbPdfiklG0Ba6yHoigcezvm5licw9EJO29W6jBElMQmLtDXKCS3blMZdf01ZrfY vqsf9SnELgTdAgJN6Ce32HjjQvSFCGOVbK81+ZgDWGGPvCxUiSuQNEcPZpyXeyUb/HxR xO/UDT0W53dW8agM2LrCrqtWsc6aG5p8xK6BGQr/Xj0LwEgvuha5uXQuwSA3mqO6k4J9 ZKqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IdO73wPUtO91VkHNoPsos+au3LYwQYAXfz1yiydAPjw=; b=uJrYYKBcvpiP58wDZ5x+4PrFGhfb2xHxTs5ZryqF9N5ZMCBQ8rTJGBfEmbdbQZrhLf o8q0L0IF52zbbnasHKe3bNx3qhwt5yKyvW7i0Wg2R4hXfpESAy/Ipjqm3W62RQvKAOtg yFXTbWf8m/MnBmc2r68feWFg6K600eIjdmfcJyap1RFI41MQ79Wr91oakNJtB6wnuhmd xt6PwXMt8qnq7Dz5wH8PU4y4B75EMoghD0BE3zTmfQLkaUebQzPyzoCIMFUFP9F366gf +tusWbF2VsUUe1APLAA1cJYV2jIevhRK8xJoIw30dEqBGOHPx09bIP0BTQ+hRrsXNVpi t/fg== X-Gm-Message-State: AOAM530sWPZ5FQ4cuooRHS/m+rK+gF9RIPb2A2EkegIrezjfGgiMBINQ LaGw9xS3OkC/pTswpPr89ZYA6g== X-Google-Smtp-Source: ABdhPJy9KoqPyLqdoPK1EXUPy9/Ro5D0jFmed6OXcjS8SVZViEddXqKt96daQmNhCN5uascZH3UUww== X-Received: by 2002:adf:d18a:: with SMTP id v10mr8830619wrc.325.1605777504496; Thu, 19 Nov 2020 01:18:24 -0800 (PST) Received: from google.com ([2a00:79e0:d:210:f693:9fff:fef4:a7ef]) by smtp.gmail.com with ESMTPSA id a128sm8935236wmf.5.2020.11.19.01.18.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2020 01:18:23 -0800 (PST) Date: Thu, 19 Nov 2020 09:18:20 +0000 From: Quentin Perret To: Will Deacon Subject: Re: [PATCH v3 07/14] sched: Introduce restrict_cpus_allowed_ptr() to limit task CPU affinity Message-ID: <20201119091820.GA2416649@google.com> References: <20201113093720.21106-1-will@kernel.org> <20201113093720.21106-8-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201113093720.21106-8-will@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_041827_255849_058C30E0 X-CRM114-Status: GOOD ( 16.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Marc Zyngier , kernel-team@android.com, Vincent Guittot , Juri Lelli , Ingo Molnar , Peter Zijlstra , Catalin Marinas , Johannes Weiner , linux-kernel@vger.kernel.org, Qais Yousef , Li Zefan , Greg Kroah-Hartman , Tejun Heo , Suren Baghdasaryan , Morten Rasmussen , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey Will, On Friday 13 Nov 2020 at 09:37:12 (+0000), Will Deacon wrote: > -static int __set_cpus_allowed_ptr(struct task_struct *p, > - const struct cpumask *new_mask, bool check) > +static int __set_cpus_allowed_ptr_locked(struct task_struct *p, > + const struct cpumask *new_mask, > + bool check, > + struct rq *rq, > + struct rq_flags *rf) > { > const struct cpumask *cpu_valid_mask = cpu_active_mask; > unsigned int dest_cpu; > - struct rq_flags rf; > - struct rq *rq; > int ret = 0; Should we have a lockdep assertion here? > - rq = task_rq_lock(p, &rf); > update_rq_clock(rq); > > if (p->flags & PF_KTHREAD) { > @@ -1929,7 +1923,7 @@ static int __set_cpus_allowed_ptr(struct task_struct *p, > if (task_running(rq, p) || p->state == TASK_WAKING) { > struct migration_arg arg = { p, dest_cpu }; > /* Need help from migration thread: drop lock and wait. */ > - task_rq_unlock(rq, p, &rf); > + task_rq_unlock(rq, p, rf); > stop_one_cpu(cpu_of(rq), migration_cpu_stop, &arg); > return 0; > } else if (task_on_rq_queued(p)) { > @@ -1937,20 +1931,69 @@ static int __set_cpus_allowed_ptr(struct task_struct *p, > * OK, since we're going to drop the lock immediately > * afterwards anyway. > */ > - rq = move_queued_task(rq, &rf, p, dest_cpu); > + rq = move_queued_task(rq, rf, p, dest_cpu); > } > out: > - task_rq_unlock(rq, p, &rf); > + task_rq_unlock(rq, p, rf); And that's a little odd to have here no? Can we move it back on the caller's side? > return ret; > } Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel