Re: [PATCH v3 3/6] hwmon: scmi: update hwmon internal scale data type

Cristian Marussi
2020-11-19T12:24:22Z

On Thu, Nov 19, 2020 at 11:40:29AM +0000, Sudeep Holla wrote:
> On Wed, Nov 18, 2020 at 04:29:02PM +0000, Cristian Marussi wrote:
> > Use an int to calculate scale values inside scmi_hwmon_scale() to match
> > the updated scale data type in struct scmi_sensor_info.
> >
> > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> > ---
> > drivers/hwmon/scmi-hwmon.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c
> > index 09ce30cba54b..17d064e58938 100644
> > --- a/drivers/hwmon/scmi-hwmon.c
> > +++ b/drivers/hwmon/scmi-hwmon.c
> > @@ -30,7 +30,7 @@ static inline u64 __pow10(u8 x)
> >
> > static int scmi_hwmon_scale(const struct scmi_sensor_info *sensor, u64 *value)
> > {
> > - s8 scale = sensor->scale;
> > + int scale = sensor->scale;
>
> Can this go independent of the series ? You haven't cc-ed the hwmon maintainer
> and the list. We need their ack if we have to take it as part of the series.
>
Sure, I did not know in fact what's better to in this case (maybe
bouncing/fwd the single patch ? CC the whole series ? ).
I'll split and send to the maintainer

Cheers

Cristian

> --
> Regards,
> Sudeep