From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2061AC2D0E4 for ; Thu, 19 Nov 2020 12:03:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 972FA20709 for ; Thu, 19 Nov 2020 12:03:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wX8uiVXl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 972FA20709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bPJ8Hl6ewS59eyL6slBZ7PIYlpwb9swYP/87uyXmGrM=; b=wX8uiVXlqK6+R/E3e3rY8i+7a qbzIGdL8+LvFmjSMd7kZjp661PkVilb5nN4KaiYPFA4uMd7OKjqLTmP6vpPGvCu1qG4rsAvNAvVs0 AX0TlE4de35t76dn0TM5z6N3HoN6atASiLUN3r/nVfx2wGqjKKpoLrzz/qO1gAGdDxAd1r2AXVQNp jpA5whdiOP4Ll45nKjibAlAfxyWXHKpzMvnX9ZTOq2trDQj9FiWSeMvgxcgc22FmoqoJq0iB/pHuq zXhYscDgsOqEZNrKxv6+/EAmRDhdj3q9tIE7Xbr9IAhXRl3pzpIyG66UUVTbJ7ADssyVYZuNc22Sp 51HkZnvdw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfidV-0001tb-GY; Thu, 19 Nov 2020 12:02:01 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfidR-0001t3-UO for linux-arm-kernel@lists.infradead.org; Thu, 19 Nov 2020 12:01:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A53EF1396; Thu, 19 Nov 2020 04:01:54 -0800 (PST) Received: from bogus (unknown [10.57.54.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0AC033F718; Thu, 19 Nov 2020 04:01:52 -0800 (PST) Date: Thu, 19 Nov 2020 12:01:50 +0000 From: Sudeep Holla To: Cristian Marussi Subject: Re: [PATCH v3 5/6] firmware: arm_scmi: add SCMIv3.0 Sensor configuration support Message-ID: <20201119120150.kzerzz465ojgyunn@bogus> References: <20201118162905.10439-1-cristian.marussi@arm.com> <20201118162905.10439-6-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201118162905.10439-6-cristian.marussi@arm.com> User-Agent: NeoMutt/20171215 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_070158_229849_E768A593 X-CRM114-Status: GOOD ( 15.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mikhail.golubev@opensynergy.com, Igor.Skalkin@opensynergy.com, jbhayana@google.com, linux-kernel@vger.kernel.org, peter.hilber@opensynergy.com, linux-arm-kernel@lists.infradead.org, Jonathan.Cameron@Huawei.com, egranata@google.com, lukasz.luba@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 18, 2020 at 04:29:04PM +0000, Cristian Marussi wrote: > Add SCMIv3.0 Sensor support for CONFIG_GET/CONFIG_SET commands. > > Signed-off-by: Cristian Marussi > --- > drivers/firmware/arm_scmi/sensors.c | 75 +++++++++++++++++++++++++++++ > include/linux/scmi_protocol.h | 37 ++++++++++++++ > 2 files changed, 112 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/sensors.c b/drivers/firmware/arm_scmi/sensors.c > index 0adc545116a4..fa3385045361 100644 > --- a/drivers/firmware/arm_scmi/sensors.c > +++ b/drivers/firmware/arm_scmi/sensors.c > @@ -22,6 +22,8 @@ enum scmi_sensor_protocol_cmd { > SENSOR_READING_GET = 0x6, > SENSOR_AXIS_DESCRIPTION_GET = 0x7, > SENSOR_LIST_UPDATE_INTERVALS = 0x8, > + SENSOR_CONFIG_GET = 0x9, > + SENSOR_CONFIG_SET = 0xA, > }; > > struct scmi_msg_resp_sensor_attributes { > @@ -150,6 +152,19 @@ struct scmi_msg_set_sensor_trip_point { > __le32 value_high; > }; > > +struct scmi_msg_sensor_config_get { > + __le32 id; > +}; > + > +struct scmi_resp_sensor_config_get { > + __le32 sensor_config; > +}; > + Same comment about single element structure as in previous patch. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel