From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13340C388F9 for ; Thu, 19 Nov 2020 12:24:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B427246E0 for ; Thu, 19 Nov 2020 12:24:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rF6sJTvc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B427246E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n2NP1MuUnUdIeUBVK5W7rZoF+mNb/rMFnS1fM5ht+u4=; b=rF6sJTvcS6tncUK8Re9DMIURF g8v9EevaQs4aUX2AcXuOyfmsK5Oj0WPRaffZA5CMQiDvfTXgm48z2JC323YK4ID6PPNI5yXrDC1VS g41jNCMiqnuwdNjEC6GgMdwW179Gp/Vg9RdyWP+TQz14iHzI/kYfq+vUunKSoDFIoltFmFTGD7t2b 6kv9jd00msC9Tq7Q2sWQllODSF+ST09O+L4x63NdPdfF36wkzoWgECWD8jkxjSKJdMH2XMUlXq95C utkXqJ4lYpp79XMfjwZKsuKN2xwW4/wYpUmVTBCUj1mZLV1GpYdDoFJYZFVfK2qDnPaxkPmGW0qFB vZWALYLVQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfixq-0006db-VU; Thu, 19 Nov 2020 12:23:03 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfixo-0006d5-RW for linux-arm-kernel@lists.infradead.org; Thu, 19 Nov 2020 12:23:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1D3BA1396; Thu, 19 Nov 2020 04:22:57 -0800 (PST) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B29B03F718; Thu, 19 Nov 2020 04:22:55 -0800 (PST) Date: Thu, 19 Nov 2020 12:22:49 +0000 From: Cristian Marussi To: Sudeep Holla Subject: Re: [PATCH v3 3/6] hwmon: scmi: update hwmon internal scale data type Message-ID: <20201119122235.GB56553@e120937-lin> References: <20201118162905.10439-1-cristian.marussi@arm.com> <20201118162905.10439-4-cristian.marussi@arm.com> <20201119114029.w5hqcquhsyxcp5s3@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201119114029.w5hqcquhsyxcp5s3@bogus> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_072300_981577_78491B78 X-CRM114-Status: GOOD ( 19.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mikhail.golubev@opensynergy.com, Igor.Skalkin@opensynergy.com, jbhayana@google.com, linux-kernel@vger.kernel.org, peter.hilber@opensynergy.com, linux-arm-kernel@lists.infradead.org, Jonathan.Cameron@Huawei.com, egranata@google.com, lukasz.luba@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 19, 2020 at 11:40:29AM +0000, Sudeep Holla wrote: > On Wed, Nov 18, 2020 at 04:29:02PM +0000, Cristian Marussi wrote: > > Use an int to calculate scale values inside scmi_hwmon_scale() to match > > the updated scale data type in struct scmi_sensor_info. > > > > Signed-off-by: Cristian Marussi > > --- > > drivers/hwmon/scmi-hwmon.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c > > index 09ce30cba54b..17d064e58938 100644 > > --- a/drivers/hwmon/scmi-hwmon.c > > +++ b/drivers/hwmon/scmi-hwmon.c > > @@ -30,7 +30,7 @@ static inline u64 __pow10(u8 x) > > > > static int scmi_hwmon_scale(const struct scmi_sensor_info *sensor, u64 *value) > > { > > - s8 scale = sensor->scale; > > + int scale = sensor->scale; > > Can this go independent of the series ? You haven't cc-ed the hwmon maintainer > and the list. We need their ack if we have to take it as part of the series. > Sure, I did not know in fact what's better to in this case (maybe bouncing/fwd the single patch ? CC the whole series ? ). I'll split and send to the maintainer Cheers Cristian > -- > Regards, > Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel