From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E81CC2D0E4 for ; Thu, 19 Nov 2020 12:25:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0225246E0 for ; Thu, 19 Nov 2020 12:25:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2Jlmhf5n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0225246E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uxABPE9p/MGN5+65udrC6Tsyd/PRevlHGPIChGGABs4=; b=2Jlmhf5nF6663TllNf6l39a3d AlIgaf4lGPtkxeljmsc3GWEGtT8Oi/G1rVf6/6fxxFQgCj3nfNgorT/cPc8rQ+FAhQ6g1Zk/REa5/ tAPGmgeClfBaV83v0OhDAO4h8TDcAuwHhSnd9JQA/EWxqcEQ5goufSnC4vCxZ5J7kwWR9Krszr89v fLO9mATCVopUQ9G0W8FziTgRZnilNyGyzYtm4QwN/t4IiWKCD+AjyfL9JeZN9J4kPmoFFSbiiEoMt tJafYh3Xa+I78BdIFMlhq0GnORiX7+Ph4KIHYPk4sAuC1/2zbT/vuscTrK7kFZL/TZvoXIvcI0OnZ wigg60kIQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfizF-0006rL-SI; Thu, 19 Nov 2020 12:24:29 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfizC-0006qe-5e for linux-arm-kernel@lists.infradead.org; Thu, 19 Nov 2020 12:24:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0D0891396; Thu, 19 Nov 2020 04:24:25 -0800 (PST) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A594F3F718; Thu, 19 Nov 2020 04:24:23 -0800 (PST) Date: Thu, 19 Nov 2020 12:24:21 +0000 From: Cristian Marussi To: Sudeep Holla Subject: Re: [PATCH v3 4/6] firmware: arm_scmi: add SCMIv3.0 Sensors timestamped reads Message-ID: <20201119122421.GC56553@e120937-lin> References: <20201118162905.10439-1-cristian.marussi@arm.com> <20201118162905.10439-5-cristian.marussi@arm.com> <20201119114216.qqprw2rydmi2wfop@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201119114216.qqprw2rydmi2wfop@bogus> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_072426_322457_1E31C773 X-CRM114-Status: GOOD ( 19.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mikhail.golubev@opensynergy.com, Igor.Skalkin@opensynergy.com, jbhayana@google.com, linux-kernel@vger.kernel.org, peter.hilber@opensynergy.com, linux-arm-kernel@lists.infradead.org, Jonathan.Cameron@Huawei.com, egranata@google.com, lukasz.luba@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 19, 2020 at 11:42:16AM +0000, Sudeep Holla wrote: > On Wed, Nov 18, 2020 at 04:29:03PM +0000, Cristian Marussi wrote: > > Add new .reading_get_timestamped() method to sensor_ops to support SCMIv3.0 > > timestamped reads. > > > > Signed-off-by: Cristian Marussi > > --- > > V2 --> v3 > > - setting rx_size to 0 in sensor_reading_get to allow fw to send > > both v2 and v3 replies...even if sensor_reading_get() only handles > > v2 spec and returns one single value > > - using get_unaligned_le64 in lieu of le64_to_cpu > > - removed refs to v2.1 > > --- > > drivers/firmware/arm_scmi/sensors.c | 137 ++++++++++++++++++++++++++-- > > include/linux/scmi_protocol.h | 22 +++++ > > 2 files changed, 152 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/firmware/arm_scmi/sensors.c b/drivers/firmware/arm_scmi/sensors.c > > index 1c83aaae0012..0adc545116a4 100644 > > --- a/drivers/firmware/arm_scmi/sensors.c > > +++ b/drivers/firmware/arm_scmi/sensors.c > > @@ -156,6 +156,27 @@ struct scmi_msg_sensor_reading_get { > > #define SENSOR_READ_ASYNC BIT(0) > > }; > > > > +struct scmi_resp_sensor_reading_get { > > + __le64 readings; > > Generally I have avoided such single element structures so far. Any > particular reasons for having it ? > Just because there are a few of them so I found it easy and preferable to have some typing to distinguish them, but I can drop it. Cristian > -- > Regards, > Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel