From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B39DC63697 for ; Thu, 19 Nov 2020 17:01:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0080E221FB for ; Thu, 19 Nov 2020 17:01:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XzufITV9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="LkHwoaUy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0080E221FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ScofEi1e7Rvnj/pTTbzqaTxMzr0YPlZNxI7p/l/ik38=; b=XzufITV9tFrt4uBKQRUAnu1g0 9RxhvJ4GHTEHZk9n0S+haNqUoJtOyf0mzOko6P/k2QgHzYOuZCYQy+88yCX2rwgAIUfRAA9R4aUUr KmbpPN4dagmM4OsCVRfPlKm9Ay3a9DuYpZzRedy0q6SuRQjwJM4Yk9QZznK2Mugx/oT5S0YxpDO77 BWVucblHsiHaqiVDu4EKFz0iskeVvi2aWH9cT7OAdJqxdOsB9P6THCVk/j0pnY6qT0Aq2wPXuryMw CTLCGFRZfhBk3cU6DT24OQgjvJmRaclbulr+iTuaL4sJ+raHaT4wyg/bhcHarKkgUKshCLblvnNls kG8iIZx4g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfnGX-00066a-9g; Thu, 19 Nov 2020 16:58:37 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfnA7-0003BK-H0 for linux-arm-kernel@lists.infradead.org; Thu, 19 Nov 2020 16:52:09 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 67BA72222A; Thu, 19 Nov 2020 16:51:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605804717; bh=RFyifzzbOlzqjeSQXuFb5hOWTQ4MmRBvgLj1aJ/TrPI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LkHwoaUyQJoZSh39n3MIBLsq4d/YOYWRlbb6Ogc1OoA51WDUt3KBEKAqUzg7L9hrm qGw4S62Ow75kCfFDheE9yS3l56jAtcN8Q21vRNTm9Ie54xgWal4ZxTXE/dSl7JiQB/ rgMDfrVdB/cAtU32bAK9+gUrlRu8At+0EOQAr9BY= Date: Thu, 19 Nov 2020 16:51:51 +0000 From: Will Deacon To: Peter Zijlstra Subject: Re: [PATCH v3 08/14] arm64: exec: Adjust affinity for compat tasks with mismatched 32-bit EL0 Message-ID: <20201119165150.GA4665@willie-the-truck> References: <20201113093720.21106-1-will@kernel.org> <20201113093720.21106-9-will@kernel.org> <20201119092407.GB2416649@google.com> <20201119110603.GB3946@willie-the-truck> <20201119161956.GS3121392@hirez.programming.kicks-ass.net> <20201119163035.GB4582@willie-the-truck> <20201119164411.GV3121392@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201119164411.GV3121392@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_115206_516915_AB2C31BA X-CRM114-Status: GOOD ( 28.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Juri Lelli , kernel-team@android.com, Vincent Guittot , Quentin Perret , Catalin Marinas , Johannes Weiner , linux-kernel@vger.kernel.org, Qais Yousef , Ingo Molnar , Li Zefan , Greg Kroah-Hartman , Marc Zyngier , Tejun Heo , Suren Baghdasaryan , Morten Rasmussen , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 19, 2020 at 05:44:11PM +0100, Peter Zijlstra wrote: > On Thu, Nov 19, 2020 at 04:30:36PM +0000, Will Deacon wrote: > > On Thu, Nov 19, 2020 at 05:19:56PM +0100, Peter Zijlstra wrote: > > > On Thu, Nov 19, 2020 at 11:06:04AM +0000, Will Deacon wrote: > > > > On Thu, Nov 19, 2020 at 09:24:07AM +0000, Quentin Perret wrote: > > > > > On Friday 13 Nov 2020 at 09:37:13 (+0000), Will Deacon wrote: > > > > > > When exec'ing a 32-bit task on a system with mismatched support for > > > > > > 32-bit EL0, try to ensure that it starts life on a CPU that can actually > > > > > > run it. > > > > > > > > > > > > Signed-off-by: Will Deacon > > > > > > --- > > > > > > arch/arm64/kernel/process.c | 12 +++++++++++- > > > > > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c > > > > > > index 1540ab0fbf23..17b94007fed4 100644 > > > > > > --- a/arch/arm64/kernel/process.c > > > > > > +++ b/arch/arm64/kernel/process.c > > > > > > @@ -625,6 +625,16 @@ unsigned long arch_align_stack(unsigned long sp) > > > > > > return sp & ~0xf; > > > > > > } > > > > > > > > > > > > +static void adjust_compat_task_affinity(struct task_struct *p) > > > > > > +{ > > > > > > + const struct cpumask *mask = system_32bit_el0_cpumask(); > > > > > > + > > > > > > + if (restrict_cpus_allowed_ptr(p, mask)) > > > > > > + set_cpus_allowed_ptr(p, mask); > > > > > > > > > > My understanding of this call to set_cpus_allowed_ptr() is that you're > > > > > mimicking the hotplug vs affinity case behaviour in some ways. That is, > > > > > if a task is pinned to a CPU and userspace hotplugs that CPU, then the > > > > > kernel will reset the affinity of the task to the remaining online CPUs. > > > > > > > > Correct. It looks to the 32-bit application like all the 64-bit-only CPUs > > > > were hotplugged off at the point of the execve(). > > > > > > This doesn't respect cpusets though :/ > > > > How does that differ from select_fallback_rq()? > > That has that cpuset state it tries first, only if that fails does it do > the possible mask. Fair enough. Lemme try something similar here before overriding the mask entirely... Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel