From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 473F1C56201 for ; Thu, 19 Nov 2020 18:05:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9EB321D46 for ; Thu, 19 Nov 2020 18:05:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="M5nwoGCQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9EB321D46 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+3dD02b//0hzp23vVcVrduzFLwgrWnKV8PgpTNhlTEw=; b=M5nwoGCQrV2HIjVnxYExKUdFV +hc2AGkD2JVcm2+OlbF4ojv4eB/WXqMOP3328ynuB9H4VRls5Y628c7AWCxnorH4JtuQinImU8ics 5cgtHn6dxeBst2JsFFZ0TdW36Qr0b3rciFD7PjnF2+UdwsrYesf3JB1Peb4z+t1pQHnzIxOTkCDkp Zi9AJpBSz0clrRinfCzpzCNOIDnGAGdV0CRKhBV9URTvjhPGLX/FAw8kaUuWsRAibrcltOCAu5ULD 56NhKLdj18vwJqgHNJrUbRM2nfY+LepAJe3UOQ8nQlHO3E+tEwTCI1rZF8vxhSKJMma0F7rA5+0vh ooegNr0Aw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfoHj-0003PG-W8; Thu, 19 Nov 2020 18:03:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfoHh-0003OR-27 for linux-arm-kernel@lists.infradead.org; Thu, 19 Nov 2020 18:03:54 +0000 Received: from gaia (unknown [2.26.170.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D56AC21D46; Thu, 19 Nov 2020 18:03:49 +0000 (UTC) Date: Thu, 19 Nov 2020 18:03:47 +0000 From: Catalin Marinas To: Lorenzo Pieralisi Subject: Re: [PATCH 1/1] ACPI/IORT: Fix doc warnings in iort.c Message-ID: <20201119180346.GI4376@gaia> References: <20201014093139.1580-1-shiju.jose@huawei.com> <20201119180120.GA25142@e121166-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201119180120.GA25142@e121166-lin.cambridge.arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_130353_264830_70E5B04F X-CRM114-Status: GOOD ( 24.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guohanjun@huawei.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linuxarm@huawei.com, linux-acpi@vger.kernel.org, sudeep.holla@arm.com, lenb@kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org, Shiju Jose Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 19, 2020 at 06:01:20PM +0000, Lorenzo Pieralisi wrote: > [+Catalin - I hope it can go via arm64 tree, trivial doc fixup] Or Will if you want it in 5.10, otherwise I can pick it up for 5.11. > On Wed, Oct 14, 2020 at 10:31:39AM +0100, Shiju Jose wrote: > > Fix following warnings caused by mismatch between > > function parameters and function comments. > > > > drivers/acpi/arm64/iort.c:55: warning: Function parameter or member 'iort_node' not described in 'iort_set_fwnode' > > drivers/acpi/arm64/iort.c:55: warning: Excess function parameter 'node' description in 'iort_set_fwnode' > > drivers/acpi/arm64/iort.c:682: warning: Function parameter or member 'id' not described in 'iort_get_device_domain' > > drivers/acpi/arm64/iort.c:682: warning: Function parameter or member 'bus_token' not described in 'iort_get_device_domain' > > drivers/acpi/arm64/iort.c:682: warning: Excess function parameter 'req_id' description in 'iort_get_device_domain' > > drivers/acpi/arm64/iort.c:1142: warning: Function parameter or member 'dma_size' not described in 'iort_dma_setup' > > drivers/acpi/arm64/iort.c:1142: warning: Excess function parameter 'size' description in 'iort_dma_setup' > > drivers/acpi/arm64/iort.c:1534: warning: Function parameter or member 'ops' not described in 'iort_add_platform_device' > > > > Signed-off-by: Shiju Jose > > --- > > drivers/acpi/arm64/iort.c | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > Acked-by: Lorenzo Pieralisi > > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > > index 9929ff50c0c0..770d84071a32 100644 > > --- a/drivers/acpi/arm64/iort.c > > +++ b/drivers/acpi/arm64/iort.c > > @@ -44,7 +44,7 @@ static DEFINE_SPINLOCK(iort_fwnode_lock); > > * iort_set_fwnode() - Create iort_fwnode and use it to register > > * iommu data in the iort_fwnode_list > > * > > - * @node: IORT table node associated with the IOMMU > > + * @iort_node: IORT table node associated with the IOMMU > > * @fwnode: fwnode associated with the IORT node > > * > > * Returns: 0 on success > > @@ -673,7 +673,8 @@ static int iort_dev_find_its_id(struct device *dev, u32 id, > > /** > > * iort_get_device_domain() - Find MSI domain related to a device > > * @dev: The device. > > - * @req_id: Requester ID for the device. > > + * @id: Requester ID for the device. > > + * @bus_token: irq domain bus token. > > * > > * Returns: the MSI domain for this device, NULL otherwise > > */ > > @@ -1136,7 +1137,7 @@ static int rc_dma_get_range(struct device *dev, u64 *size) > > * > > * @dev: device to configure > > * @dma_addr: device DMA address result pointer > > - * @size: DMA range size result pointer > > + * @dma_size: DMA range size result pointer > > */ > > void iort_dma_setup(struct device *dev, u64 *dma_addr, u64 *dma_size) > > { > > @@ -1526,6 +1527,7 @@ static __init const struct iort_dev_config *iort_get_dev_cfg( > > /** > > * iort_add_platform_device() - Allocate a platform device for IORT node > > * @node: Pointer to device ACPI IORT node > > + * @ops: Pointer to IORT device config struct > > * > > * Returns: 0 on success, <0 failure > > */ > > -- > > 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel