From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85527C388F9 for ; Thu, 19 Nov 2020 23:17:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E84912100A for ; Thu, 19 Nov 2020 23:17:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1oPLaULv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="uNdjHuTE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E84912100A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=O5VnymUySLfehYt7sDnHdh5+tgMItiJyzsgEWeCcbpk=; b=1oPLaULvZ3xZ5YNalFRlNgpk7 qiAYKEhxz8aAP4BMsk6TpJz4Nf+rqvcf+rC6ionlafKo0wAUNHJsrizXID7YZGzbVX2dueXLi4dh9 V/B/ooVyQjUbYhUitsSMVivoi+JmAD32CmQnlcVxY4Cd+BmDWLoJbiCisnZ47Tm7TCcZhjYmUvnuf 1lOU1cUkoZZXuvO668aVT5pHxsUqlqDTtmqbuk99GL7pCJOGXNASq4hszZV2E0Kv19k/gXVcZISrH 8rRJSWLElaVTmmd07YAaXmDMox5dWd3ueHa+Pusa2MvDHneTLGQ2CmlGWtyfimE5GixU3SplbMuaL LJD/Fo5dA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kftAD-0005gy-Pe; Thu, 19 Nov 2020 23:16:29 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kftAB-0005gM-1i for linux-arm-kernel@lists.infradead.org; Thu, 19 Nov 2020 23:16:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=d04PQ9hXGMwnNf/9OpR576As/8xUL2kZEnoyB/i5tCw=; b=uNdjHuTE/A3AvtmDVttqqmNnG 9Ct4IRwdP2iBVy5pjZRLUf+MmIbvF6Z6MJQS2BMJ9WctbShL0lqI9KhRVyFDbo/fK84yaQqWb2VeN sI1TACgG3qjFks2Wyps5wnDJ0MVhYN9jFg9BZt4KP2LdL66CwqCWdF3r0A1x9xge26XZKpETaajd+ ZGTeJkNULS2lNzGjAxOOvlDCjm9H0NgqgdzXcv0vthfTglGugM3cAOPIOU7QuZVAx6t0B7KXV0B+I y4TIS/ZXLAG2EwLYvNOrlb4YwL/MTYAkLS/vG8FxPdc0gdlZBiKetANw2C7P2i20EF/xQMgj6o9RL gINsIsnLA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:33582) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kft9z-0002qm-F8; Thu, 19 Nov 2020 23:16:15 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kft9x-0002XJ-Nd; Thu, 19 Nov 2020 23:16:13 +0000 Date: Thu, 19 Nov 2020 23:16:13 +0000 From: Russell King - ARM Linux admin To: Tobias Waldekranz Subject: Re: net: phy: Dealing with 88e1543 dual-port mode Message-ID: <20201119231613.GN1551@shell.armlinux.org.uk> References: <20201119152246.085514e1@bootlin.com> <20201119145500.GL1551@shell.armlinux.org.uk> <20201119162451.4c8d220d@bootlin.com> <87k0uh9dd0.fsf@waldekranz.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87k0uh9dd0.fsf@waldekranz.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_181627_235444_4EA401B4 X-CRM114-Status: GOOD ( 20.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Florian Fainelli , netdev@vger.kernel.org, Antoine Tenart , Vivien Didelot , Thomas Petazzoni , Maxime Chevallier , "David S. Miller" , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 19, 2020 at 11:43:39PM +0100, Tobias Waldekranz wrote: > On Thu, Nov 19, 2020 at 16:24, Maxime Chevallier wrote: > > I don't think we have a way to distinguish from the DT if we are in > > SGMII-to-Fibre or in SGMII-to-{Copper + Fibre}, since the description is > > the same, we don't have any information in DT about wether or not the > > PHY is wired to a Copper RJ45 port. > > > > Maybe we should have a way to indicate if a PHY is wired to a Copper > > port in DT ? > > Do you mean something like: > > SGMII->SGMII (Fibre): > ethernet-phy@0 { > sfp = <&sfp0>; > }; > > SGMII->MDI (Copper): > ethernet-phy@0 { > mdi; > }; > > SGMII->Auto Media Detect > ethernet-phy@0 { > mdi; > sfp = <&sfp0>; > }; This isn't something we could realistically do - think about how many DT files are out there today which would not have this for an existing PHY. The default has to be that today's DT descriptions continue to work as-is, and that includes ones which already support copper and fibre either with or without a sfp property. So, we can't draw any conclusion about whether the fiber interface is wired from whether there is a sfp property or not. We also can't draw a conclusion about whether the copper side is wired using a "mdi" property, or whether there is a "sfp" property or not. The only thing we could realistically do today is to introduce a property like: mdi = "disabled" | "okay"; to indicate whether the copper port can be used, and maybe something similar for the fiber interface. Maybe as you suggest, not "okay" but specifying the number of connected pairs would be a good idea, or maybe that should be a separate property? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel