From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E3A5C5519F for ; Fri, 20 Nov 2020 07:55:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD274222BA for ; Fri, 20 Nov 2020 07:55:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Wx1qpj/Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD274222BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XUJDLQjtyXceqfSbxEokxJK0f4trJqwDOpb8y3+A5QM=; b=Wx1qpj/Yfc0bYvpjENAwJVlI+ 8ttkfqU5SarOGKMZYMnOey/I+/G7NcHpVyd8xQjZLVFW0IiihqvPnCDFMyi9/gA6MI6OruVCm5q+j coXnP56BcWtdSJ0kpvhTTE0H6xYdyDXY9GUYnbWdFzeUQd3IMs6q1yZaDEmFfSqF/1V2CUzy/vKPH 3Rt01JU+A3m6jguJZzgJ/OW9iTXzxhdk1SW2QQWFVOI5B8B/abf1oLm6PdA7Y9yRK1lqSLYmwvSz1 z2YVvEvnHIEWqk5/Fe6vyL5HwinBy9AqtYveOjlFy8cy+8go5AssrQzb8Nr6ebeH8+sUOHPmh1GLy l9w9JFqNA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg1Fm-0001cR-6N; Fri, 20 Nov 2020 07:54:46 +0000 Received: from mail-ej1-f68.google.com ([209.85.218.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg1Fk-0001bZ-7q for linux-arm-kernel@lists.infradead.org; Fri, 20 Nov 2020 07:54:45 +0000 Received: by mail-ej1-f68.google.com with SMTP id s25so11586153ejy.6 for ; Thu, 19 Nov 2020 23:54:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Eq/cujlUFAwrKQYzYbGEyGBEOnWSD/TTaG5voRoVQjE=; b=naMj2nt28mbQGdTlIq4+xObsxrAiHQITNK5KQly4nFXAKz5HOAkoFJGdekWiYsF1Cj iTwpvgukPz89t8h8oOcELlDKv88MTrFQSU0nGor1SOM8FFpuw82uLtQ48Sqxao+6l189 29+zWAUPDMSUuDIPLXP7IFeUKbT8P0agEBlUTF1wMv7CWoVVXkJSqDuGYuH/od2BZOcD CxzpBprR0/K0JLsTkdbg4+RKd085z9UnKfTTTcqEALMcmqGqKMztGgLrOO45zFJPXTCL 4nR7xwzv2616B7XmZFsalIOk0mWngYpKfKIPW8zm+NRS7zpfTtQJQV4HizQSlWgalN// CDwQ== X-Gm-Message-State: AOAM5307WP3EE217yt44L1MkZRmBhauerfXn6mn+HUogB3eMubWJFngG +V4oiVM97MVBS1h5PqlG2yA= X-Google-Smtp-Source: ABdhPJxuaR27wac9OpeJdOqiC/c4OeL2/B+cbpng51ZXhzx1PGawUYjtXR4G4tE9CeA6tkvySD65bg== X-Received: by 2002:a17:906:840e:: with SMTP id n14mr31661878ejx.147.1605858881515; Thu, 19 Nov 2020 23:54:41 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id la9sm771763ejb.121.2020.11.19.23.54.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2020 23:54:40 -0800 (PST) Date: Fri, 20 Nov 2020 08:54:38 +0100 From: Krzysztof Kozlowski To: Alice Guo Subject: Re: [EXT] Re: [PATCH v3 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Message-ID: <20201120075438.GA4750@kozik-lap> References: <20201117073609.GA3436@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201120_025444_306222_7FABAD14 X-CRM114-Status: GOOD ( 16.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Peng Fan , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , dl-linux-imx , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 20, 2020 at 06:21:55AM +0000, Alice Guo wrote: > > > + soc: > > > + type: object > > > + properties: > > > + compatible: > > > + oneOf: > > > + - description: new version DTS for i.MX8M SoCs > > > + items: > > > + - enum: > > > + - fsl,imx8mm-soc > > > + - fsl,imx8mn-soc > > > + - fsl,imx8mp-soc > > > + - fsl,imx8mq-soc > > > + - const: simple-bus > > > + > > > + - description: other SoCs and old version DTS for i.MX8M SoCs > > > + items: > > > + - const: simple-bus > > > + > > > + nvmem-cells: > > > + maxItems: 1 > > > + description: Phandle to the SOC Unique ID provided by a nvmem > > > + node > > > + > > > + nvmem-cells-names: > > > + const: soc_unique_id > > > + > > > + allOf: > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + enum: > > > + - fsl,imx8mm-soc > > > + - fsl,imx8mn-soc > > > + - fsl,imx8mp-soc > > > + - fsl,imx8mq-soc > > > + const: simple-bus > > > + > > > + then: > > > + required: > > > + - nvmem-cells > > > + - nvmem-cells-names > > > > > > The above is my modification. Is that ok? > > > > Does not look like solving anything. > > If restrict that the newly added DTS file must have "fsl,imx8mX-soc" attributes, it cannot pass make dtbs_check because > there are other DTS files which have soc node but are not used for i.mx8m family SoCs. You need to check whether boards with i.MX 8M compatible have the SoC node with one of above compatibles and nvmem-cells. Since the top select choses root node, then just check whether child exists with specific pattern and compatibles (for given root compatibles). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel