From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DB86C56202 for ; Fri, 20 Nov 2020 10:53:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5BFA20657 for ; Fri, 20 Nov 2020 10:53:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kMpANxCe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5BFA20657 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S0AH5Y8RQjDsQMscs2TtDVUvJi+D2XJz76t+rFOXFnY=; b=kMpANxCejdtjC5qw9j6fzbd9g it9p2gXA6YxjGZJ/4MI5dj1/cn/2HIKGC4kM/mSVUvGp0p8Aq84MY5dcuaxNl3hRglWfxmn0ebUrL EJnjd7WA2kjqocXJPMJxukwyZSotukn+JL8Vexk1f1x5kZ80X/fG9fPpzuJKwfwkmWihTo/fVokjY dEN6hSR55m+xAcCpizgZUbgLcowrCtRGNTAytPnCOhqfNI803QeBmwVlm4+JIiXrpwZPdhpE+BVKS adoAlCRpLpkJtLE7hxyOGLf3NJK2yMkPRgF4KxONQY9r8uWtcJ6f7VL6dfTLmLOmvoDoa9vUAj0Qy 2TAMRCJsQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg42o-0004Im-LE; Fri, 20 Nov 2020 10:53:34 +0000 Received: from mail-ej1-f65.google.com ([209.85.218.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg42m-0004I3-JY for linux-arm-kernel@lists.infradead.org; Fri, 20 Nov 2020 10:53:33 +0000 Received: by mail-ej1-f65.google.com with SMTP id o21so12248313ejb.3 for ; Fri, 20 Nov 2020 02:53:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=V3kEOLd2utFjzbmv50gNlqd+2n+lrD5UargnZ9h+es4=; b=JGJVzp/z+oyCklzT/qQ+NPkkRIkuOymRBnZskziX8EMWdInYM7sA/X+TR9zPTHxJoU M4rHVwsj4SiaNUbmI8VlHdsaMSBUUhFegxMOu9Rvqm4pL6qnZbgfom2k1EFXcvd0SGPt 6YNwV5ehjxs8o+M2cgkxaDX/7pPYyUgSGLG09CEAf2rj3zIBtLhwwUl4ObiOm0oScCDK Rm+PtaV6eIfz53Jx41JoeXYuvNd1vgEza3HmaF4ZvhQZ6KZGgotbsDwVu2c4/LjRaOvF fA9vTk09vSnMBWAR/5kfxjNvQlokk77po2F/WBslCiHuFlYX21UfTrfxnkYCzPmnOoBo NG6g== X-Gm-Message-State: AOAM531uylWGwUqfW5HxacipWZ4R17LkOLA+4GJxrUM/WnG5zGpceYVD s+KvAWeEH3HusEh/bR8VC5Y= X-Google-Smtp-Source: ABdhPJxtp/tR2wp7KDqe9HbHJKFxzlmWgj9mNs3miaUyBfYqNNhqPGNkOcDgkfRd68k23+zAjz6Apw== X-Received: by 2002:a17:906:d8a8:: with SMTP id qc8mr32002836ejb.149.1605869611481; Fri, 20 Nov 2020 02:53:31 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id u17sm987053eje.11.2020.11.20.02.53.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2020 02:53:30 -0800 (PST) Date: Fri, 20 Nov 2020 11:53:29 +0100 From: Krzysztof Kozlowski To: Alice Guo Subject: Re: [PATCH v4 3/4] arm64: dts: imx8m: add NVMEM provider and consumer to read soc unique ID Message-ID: <20201120105329.GB18581@kozik-lap> References: <20201120101112.31819-1-alice.guo@nxp.com> <20201120101112.31819-3-alice.guo@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201120101112.31819-3-alice.guo@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201120_055332_678669_1819F29F X-CRM114-Status: GOOD ( 19.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, peng.fan@nxp.com, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-imx@nxp.com, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 20, 2020 at 06:11:11PM +0800, Alice Guo wrote: > In order to be able to use NVMEM APIs to read soc unique ID, add the > nvmem data cell and name for nvmem-cells to the "soc" node, and add a > nvmem node which provides soc unique ID to efuse@30350000. > > v2: remove the subject prefix "LF-2571-3" > v3: convert register addresses and sizes to hex > v4: delete "stuff" in subject and commit message, add detailed > description > > Signed-off-by: Alice Guo > --- > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 6 ++++++ > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 6 ++++++ > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 6 ++++++ > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 6 ++++++ > 4 files changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > index d457ce815e68..0e0edd5db07b 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -261,6 +261,8 @@ > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x0 0x0 0x0 0x3e000000>; > + nvmem-cells = <&imx8mm_uid>; > + nvmem-cell-names = "soc_unique_id"; > > aips1: bus@30000000 { > compatible = "fsl,aips-bus", "simple-bus"; > @@ -518,6 +520,10 @@ > #address-cells = <1>; > #size-cells = <1>; > > + imx8mm_uid: unique_id@410 { Any reason why device node uses underscore, not a hyphen/dash? Other fields are proper (it's also naming convention of DT spec and dtc W=2 will point it). Best regards, Krzysztof > + reg = <0x4 0x8>; > + }; > + > cpu_speed_grade: speed-grade@10 { > reg = <0x10 4>; > }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel