From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8C03C56201 for ; Fri, 20 Nov 2020 19:17:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35F9522240 for ; Fri, 20 Nov 2020 19:17:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dcNN+omY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35F9522240 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vSfM9wHom2eW7t9oYdKrd/frwoCtGrhXvnJoryFbyA8=; b=dcNN+omYMWQXRXuX23XCiS25W pL5HyrnfgSuLBI4J9qXxjtFmFFkyUNmGRFNW0BhhxyeFhGyfErquho1CS4WzpzEjAhIFXlu2I/qBN Y5EOUAw6wEVYLIogiad39bcrOoAQjVCS8GDJeIx+g37NMCJLQ4aDPu54l/LCGiFA2PHQQB3g8Gh/u bnmIlZW4TZ8T+lMnaRpXSiK4fMQfgp07Orcoo+MhCyLHdgnkJt65D1C96YLNPyxtER+kJ4JwjHWh4 FN95Q1Gh9WVOH9O3lXpK6B6rXyuG9PbgCYWTpccXMQ0YnFzzB/LHSvYAOjLMJ8jehWl3tuRy78OtV teiKSwSkw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgBto-000376-CI; Fri, 20 Nov 2020 19:16:48 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgBtk-00035J-1n for linux-arm-kernel@lists.infradead.org; Fri, 20 Nov 2020 19:16:45 +0000 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 308AD22240; Fri, 20 Nov 2020 19:16:41 +0000 (UTC) Date: Fri, 20 Nov 2020 14:16:39 -0500 From: Steven Rostedt To: Marco Elver Subject: Re: linux-next: stall warnings and deadlock on Arm64 (was: [PATCH] kfence: Avoid stalling...) Message-ID: <20201120141639.3896a3c8@gandalf.local.home> In-Reply-To: <20201120181737.GA3301774@elver.google.com> References: <20201118225621.GA1770130@elver.google.com> <20201118233841.GS1437@paulmck-ThinkPad-P72> <20201119125357.GA2084963@elver.google.com> <20201119151409.GU1437@paulmck-ThinkPad-P72> <20201119170259.GA2134472@elver.google.com> <20201119184854.GY1437@paulmck-ThinkPad-P72> <20201119193819.GA2601289@elver.google.com> <20201119213512.GB1437@paulmck-ThinkPad-P72> <20201120141928.GB3120165@elver.google.com> <20201120102613.3d18b90e@gandalf.local.home> <20201120181737.GA3301774@elver.google.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201120_141644_433521_8124845A X-CRM114-Status: GOOD ( 22.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Anders Roxell , "Paul E. McKenney" , Jann Horn , Peter Zijlstra , Lai Jiangshan , Linux Kernel Mailing List , kasan-dev , rcu@vger.kernel.org, Linux-MM , Alexander Potapenko , linux-arm-kernel@lists.infradead.org, Tejun Heo , Andrew Morton , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 20 Nov 2020 19:17:37 +0100 Marco Elver wrote: > > > +++ b/kernel/rcu/Makefile > > > @@ -3,6 +3,13 @@ > > > # and is generally not a function of system call inputs. > > > KCOV_INSTRUMENT := n > > > > > > +ifdef CONFIG_FUNCTION_TRACER > > > +CFLAGS_REMOVE_update.o = $(CC_FLAGS_FTRACE) > > > +CFLAGS_REMOVE_sync.o = $(CC_FLAGS_FTRACE) > > > +CFLAGS_REMOVE_srcutree.o = $(CC_FLAGS_FTRACE) > > > +CFLAGS_REMOVE_tree.o = $(CC_FLAGS_FTRACE) > > > +endif > > > + > > > > Can you narrow it down further? That is, do you really need all of the > > above to stop the stalls? > > I tried to reduce it to 1 or combinations of 2 files only, but that > didn't work. I'm curious if this would help at all? diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 2a52f42f64b6..d020ecefd151 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -1094,7 +1094,7 @@ static void rcu_disable_urgency_upon_qs(struct rcu_data *rdp) * if the current CPU is not in its idle loop or is in an interrupt or * NMI handler, return true. */ -bool rcu_is_watching(void) +notrace bool rcu_is_watching(void) { bool ret; Although I don't see it in the recursion list. -- Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel