Re: net: phy: Dealing with 88e1543 dual-port mode

From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	netdev@vger.kernel.org, Antoine Tenart <atenart@kernel.org>,
	Russell King - ARM Linux admin <linux@armlinux.org.uk>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Tobias Waldekranz <tobias@waldekranz.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org,
	Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: net: phy: Dealing with 88e1543 dual-port mode
Date: Fri, 20 Nov 2020 15:18:52 +0100	[thread overview]
Message-ID: <20201120151852.369f6d23@bootlin.com> (raw)
In-Reply-To: <20201120135517.GH1804098@lunn.ch>

Hi Russell, Andrew,

On Fri, 20 Nov 2020 14:55:17 +0100
Andrew Lunn <andrew@lunn.ch> wrote:

>On Fri, Nov 20, 2020 at 10:25:38AM +0000, Russell King - ARM Linux admin wrote:
>> On Fri, Nov 20, 2020 at 10:36:01AM +0100, Maxime Chevallier wrote:  
>> > So maybe we could be a bit more generic, with something along these lines :
>> > 
>> >     ethernet-phy@0 {
>> >         ...
>> > 
>> >         mdi {
>> >             port@0 {
>> >                 media = "10baseT", "100baseT", "1000baseT";
>> >                 pairs = <1>;
>> > 	    };
>> > 
>> >             port@1 {
>> >                 media = "1000baseX", "10gbaseR"
>> >             };
>> >         };
>> >     };  
>> 
>> Don't forget that TP requires a minimum of two pairs.  
>
>Hi Russell
>
>Well, actually, there are automotive PHYs which use just one pair, so
>called T1 PHYs. We have drivers for i think two so far, with one more
>on the way.
>
>You also have to watch out for 'clever' PHYs. The Aquantia PHY can do
>1000Base-T2, i.e. 1G over two pairs. This might be a proprietary
>extension, rather than standardized, but it shows it can be done. So
>you have to be careful about assumptions based on the number of pairs.

You're right that the "pairs" property might not be needed, if we
have an appropriate media string for each mode ( maybe "1000baseT1" and
"1000baseT2" for the 2 modes you're referencing ? ).

I can also see other use-cases where having an indication of the nature
of the media interface we want to use for a PHY can be useful.

If the overall idea of having such a representation of the mdi info is
something that you can see being adopted, I'll work on a first draft
implementation to see what this looks like.

Thanks for you inputs !

Maxime

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel