From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D27BBC5519F for ; Fri, 20 Nov 2020 14:19:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A36E2222A for ; Fri, 20 Nov 2020 14:19:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YFa+a6iQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A36E2222A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Esp2sFZxIvKtB+S+xf4Q7Aun0B4KQIFS/LCNAmZSRJw=; b=YFa+a6iQjcD137vQLJcxJlkRM ACy+2XQL6Pzp0WqSLLUWK/b8jkuUwIvo92FAxTi3QyyX8plXXKBv844iMdi42025pMpqAOYwfnUnm C+iHITIUr5QNayi3m2ovcI5HnhB4rC1ncnWmLWg9fT1OOdDaGMB3MkeAqW/yxgo/nT9+JZPHJ6oP7 8abcu2P+iD/LFOjLnfnl0xKkYAH1VMMMDeJFu6s/IDn/0skFyhfRYNaZ1xWV97qJBvZUOKuWpEEE/ H8cB6KwrYONsl0BYtHqN3Q3v5nOb/hMAuLzxVPVmiI+I+/HoOZ9HWqskXsBoInIpZpKs0v++ChAVu QhwW9At2Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg7Fh-0000MQ-N4; Fri, 20 Nov 2020 14:19:05 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg7Fe-0000LX-Ko for linux-arm-kernel@lists.infradead.org; Fri, 20 Nov 2020 14:19:03 +0000 X-Originating-IP: 90.55.104.168 Received: from bootlin.com (atoulouse-258-1-33-168.w90-55.abo.wanadoo.fr [90.55.104.168]) (Authenticated sender: maxime.chevallier@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 21FF320007; Fri, 20 Nov 2020 14:18:55 +0000 (UTC) Date: Fri, 20 Nov 2020 15:18:52 +0100 From: Maxime Chevallier To: Andrew Lunn Subject: Re: net: phy: Dealing with 88e1543 dual-port mode Message-ID: <20201120151852.369f6d23@bootlin.com> In-Reply-To: <20201120135517.GH1804098@lunn.ch> References: <20201119152246.085514e1@bootlin.com> <20201119145500.GL1551@shell.armlinux.org.uk> <20201119162451.4c8d220d@bootlin.com> <87k0uh9dd0.fsf@waldekranz.com> <20201119231613.GN1551@shell.armlinux.org.uk> <87eekoanvj.fsf@waldekranz.com> <20201120103601.313a166b@bootlin.com> <20201120102538.GP1551@shell.armlinux.org.uk> <20201120135517.GH1804098@lunn.ch> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201120_091902_813990_7C85F34D X-CRM114-Status: GOOD ( 15.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , netdev@vger.kernel.org, Antoine Tenart , Russell King - ARM Linux admin , Vivien Didelot , Thomas Petazzoni , Tobias Waldekranz , "David S. Miller" , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Russell, Andrew, On Fri, 20 Nov 2020 14:55:17 +0100 Andrew Lunn wrote: >On Fri, Nov 20, 2020 at 10:25:38AM +0000, Russell King - ARM Linux admin wrote: >> On Fri, Nov 20, 2020 at 10:36:01AM +0100, Maxime Chevallier wrote: >> > So maybe we could be a bit more generic, with something along these lines : >> > >> > ethernet-phy@0 { >> > ... >> > >> > mdi { >> > port@0 { >> > media = "10baseT", "100baseT", "1000baseT"; >> > pairs = <1>; >> > }; >> > >> > port@1 { >> > media = "1000baseX", "10gbaseR" >> > }; >> > }; >> > }; >> >> Don't forget that TP requires a minimum of two pairs. > >Hi Russell > >Well, actually, there are automotive PHYs which use just one pair, so >called T1 PHYs. We have drivers for i think two so far, with one more >on the way. > >You also have to watch out for 'clever' PHYs. The Aquantia PHY can do >1000Base-T2, i.e. 1G over two pairs. This might be a proprietary >extension, rather than standardized, but it shows it can be done. So >you have to be careful about assumptions based on the number of pairs. You're right that the "pairs" property might not be needed, if we have an appropriate media string for each mode ( maybe "1000baseT1" and "1000baseT2" for the 2 modes you're referencing ? ). I can also see other use-cases where having an indication of the nature of the media interface we want to use for a PHY can be useful. If the overall idea of having such a representation of the mdi info is something that you can see being adopted, I'll work on a first draft implementation to see what this looks like. Thanks for you inputs ! Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel