From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58FDCC2D0E4 for ; Fri, 20 Nov 2020 20:30:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C22622223F for ; Fri, 20 Nov 2020 20:30:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qF4rzOZf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="slPQ//pe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C22622223F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h819iqAotZjB2SM+90PFBnwTf/qWwYa2h+9jXNfaQ5Y=; b=qF4rzOZftMF4Ic3SeMZoDWP5q T47AHEVJNWP6agXpmJWmXaLvpD54XRNRInkBbjRvp4FX/9glneX24ViC5VaAMYaONArabIeU91Dap B/uihFo18b5TSExvEfh9jxqygHIiECDXXBJyhbhhH/DsPwXKgQuiXEkGBz6XXwx6/oUE7qXdhiRqc UXelttkJOaCBDAEfNw26ByH1XuL835G3BtSzLa+fjBwJZgx0sR1zMYHakb7CQZz6tE9Za4yN3DqUR 91hNQqmeZQFcMgpxlfONsW36rWHf+8JYwwlR35pTVF91IrsxmUKVKLMAeR/QKzYtZnXQiu4MZWpyN peuup20FQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgD2O-0001xm-L6; Fri, 20 Nov 2020 20:29:44 +0000 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgD2L-0001wP-7o for linux-arm-kernel@lists.infradead.org; Fri, 20 Nov 2020 20:29:41 +0000 Received: by mail-qt1-x842.google.com with SMTP id g17so8108900qts.5 for ; Fri, 20 Nov 2020 12:29:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fWEyiKtLOwc5BKH8g+Q/g+4/sPbOaRfc0dXxralt2Mw=; b=slPQ//pemKZh9f5kkjudlch0CBWhSXQy2VCSu7HRkD1RW0Ao5+0ftQM2E6UPD3hccj qjQNNmRuGGdK3qOvq5NYurgRaP3hJJuevD4jAH/fmKo+acNl1pILRNLqMDFd7QZ+2prZ tmcUlDky6roTiagY+1Ks0VwGJwggfgRDYhMNyjlvUprVonMn9YqbkCKWYuYbATXQn2JP H9tN2HQsAdXChUj0afdmZW/4fCcfq/VPLcHKF5jmoDMHeF6P0ZDz4TumaSvPvAlnmbSp 9HEAzto9pPBh3Vc65NGET29HWmFU7wMfbtObL4BW7Zce7yCYVt0G+SkyUa9ICW+0aIqa CMtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fWEyiKtLOwc5BKH8g+Q/g+4/sPbOaRfc0dXxralt2Mw=; b=EIf2W1tul4X2OJQOT3D4Xoac57zSpbsyDLJqKBXkgpr1mJrYVqr1jcuCvg0hP4PMCN hqnxN3Gf7I7x2AJd6Xhe7vpLU5JjG3uLQaKPhMmvj9oILliz2fOre1sVoTsRNpcPHssE omcgOZuon56Pg2zbhxj8VFVPdRCLrbniYS8tZxtYGn9qHLWhOvde/nwqW8mdb++HXF/h kgtoLeT1XHIfpgcPid0jThOZDt5PKspSfMVFDHgXxNS63H9PnEzvRTkiPrceCov2DSkp jAywUg8X0nrZwrzEGNppw+xvrdJsIi+cZmQNRKeyL81hOGg91MnjviZ+uV6jKAg5Kfvb v/6A== X-Gm-Message-State: AOAM532BJ6dR1ryqQCoLNbPSB/fA6LWTMJqpxLsfUy5WpA7iDGSpoa0V /HHfM1BnVnoXN9A+robQeorCcnDJgKwbiQ== X-Google-Smtp-Source: ABdhPJyeXkg7uuNpc9skA29Vf8QCCxes8SLhmi9OBG/8zRZ22lxtrFLvm4CI1/fXBFji9v0sjbaDkA== X-Received: by 2002:ac8:3496:: with SMTP id w22mr17736541qtb.222.1605904178000; Fri, 20 Nov 2020 12:29:38 -0800 (PST) Received: from ubuntu-m3-large-x86 ([2604:1380:45f1:1d00::1]) by smtp.gmail.com with ESMTPSA id v32sm2850385qtb.42.2020.11.20.12.29.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2020 12:29:36 -0800 (PST) Date: Fri, 20 Nov 2020 13:29:35 -0700 From: Nathan Chancellor To: Kees Cook Subject: Re: [PATCH v7 02/17] kbuild: add support for Clang LTO Message-ID: <20201120202935.GA1220359@ubuntu-m3-large-x86> References: <20201118220731.925424-1-samitolvanen@google.com> <20201118220731.925424-3-samitolvanen@google.com> <202011201144.3F2BB70C@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202011201144.3F2BB70C@keescook> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201120_152941_326609_21CD7A3A X-CRM114-Status: GOOD ( 17.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , "Paul E. McKenney" , Kernel Hardening , Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , Linux Kbuild mailing list , Nick Desaulniers , LKML , Steven Rostedt , clang-built-linux , linux-pci@vger.kernel.org, Sami Tolvanen , Josh Poimboeuf , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 20, 2020 at 11:47:21AM -0800, Kees Cook wrote: > On Fri, Nov 20, 2020 at 08:23:11AM -0800, Sami Tolvanen wrote: > > Changing the ThinLTO config to a choice and moving it after the main > > LTO config sounds like a good idea to me. I'll see if I can change > > this in v8. Thanks! > > Originally, I thought this might be a bit ugly once GCC LTO is added, > but this could be just a choice like we're done for the stack > initialization. Something like an "LTO" choice of NONE, CLANG_FULL, > CLANG_THIN, and in the future GCC, etc. Having two separate choices might be a little bit cleaner though? One for the compiler (LTO_CLANG versus LTO_GCC) and one for the type (THINLTO versus FULLLTO). The type one could just have a "depends on CC_IS_CLANG" to ensure it only showed up when needed. Cheers, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel