From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: ohad@wizery.com, linux-remoteproc@vger.kernel.org,
bjorn.andersson@linaro.org, linux-mediatek@lists.infradead.org,
pihsun@chromium.org, matthias.bgg@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] remoteproc/mediatek: fix boundary check
Date: Fri, 20 Nov 2020 16:31:50 -0700 [thread overview]
Message-ID: <20201120233150.GG4137289@xps15> (raw)
In-Reply-To: <20201116084413.3312631-2-tzungbi@google.com>
On Mon, Nov 16, 2020 at 04:44:11PM +0800, Tzung-Bi Shih wrote:
> It is valid if offset+length == sram_size.
>
> For example, sram_size=100, offset=99, length=1. Accessing offset 99
> with length 1 is valid.
>
> Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
> ---
> drivers/remoteproc/mtk_scp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
> index a1e23b5f19b9..0abbeb62cf43 100644
> --- a/drivers/remoteproc/mtk_scp.c
> +++ b/drivers/remoteproc/mtk_scp.c
> @@ -408,11 +408,11 @@ static void *scp_da_to_va(struct rproc *rproc, u64 da, size_t len)
>
> if (da < scp->sram_size) {
> offset = da;
> - if (offset >= 0 && (offset + len) < scp->sram_size)
> + if (offset >= 0 && (offset + len) <= scp->sram_size)
> return (void __force *)scp->sram_base + offset;
> } else if (scp->dram_size) {
> offset = da - scp->dma_addr;
> - if (offset >= 0 && (offset + len) < scp->dram_size)
> + if (offset >= 0 && (offset + len) <= scp->dram_size)
Right, I had the same kind of conversation with the TI folks.
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> return scp->cpu_addr + offset;
> }
>
> --
> 2.29.2.299.gdc1121823c-goog
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-20 23:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 8:44 [PATCH v2 0/3] remoteproc/mediatek: read IPI buffer offset from FW binary Tzung-Bi Shih
2020-11-16 8:44 ` [PATCH v2 1/3] remoteproc/mediatek: fix boundary check Tzung-Bi Shih
2020-11-20 23:31 ` Mathieu Poirier [this message]
2020-11-16 8:44 ` [PATCH v2 2/3] remoteproc/mediatek: skip if filesz is 0 Tzung-Bi Shih
2020-11-20 23:35 ` Mathieu Poirier
2020-11-16 8:44 ` [PATCH v2 3/3] remoteproc/mediatek: read IPI buffer offset from FW Tzung-Bi Shih
2020-11-20 23:50 ` Mathieu Poirier
2020-11-23 3:03 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201120233150.GG4137289@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=ohad@wizery.com \
--cc=pihsun@chromium.org \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox