From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 477AAC5519F for ; Fri, 20 Nov 2020 23:36:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B106B2240B for ; Fri, 20 Nov 2020 23:36:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Bjd9s9c3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lSqmqi3Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B106B2240B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=51cIYajcNR/Hp3t6MZCbB7yKsOknza/dem5YueQbugM=; b=Bjd9s9c3BCkGcCJ+jbDu9GWP8 LKHp4TviKKKpk65BapF4heOsP4ZbyayOY3i54dNkhr/pyE4Id9fubx/8UjQiIZmDoVj5cFJB4elAp qEDmICRSMXYtMosEeAaTIXGLyxn/QcsDIIh/F3wKUJ0+Ft4UHuesctHkZU5X25Kj1lBlsDvBGw/jm v2mW4u30DMxVF1nZxcuKJCljli94u58pN/Q+PXsjFO2+4H6DcFA4I9ZRJqP4q+oT8wJ1h7XVmoYZV cSuIftcqo/u1112Ahj7Vxpu9jlwA6o99AbgKbKp8f0NMjyUBCYu/v4DwwrTqgkQGMc5C4lpuPoDlP MGPivPqOQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgFwR-0007Yf-Ow; Fri, 20 Nov 2020 23:35:47 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgFwN-0007XY-JV for linux-arm-kernel@lists.infradead.org; Fri, 20 Nov 2020 23:35:44 +0000 Received: by mail-pl1-x642.google.com with SMTP id 18so5657352pli.13 for ; Fri, 20 Nov 2020 15:35:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nRTceVwrQo7nc3Kc6KStQCnzuWIzRftiyAd8oL6fIFE=; b=lSqmqi3Q157w+EhxtXGbrkd4lSfMsE4CKVqKVirBli6bOwnZN6/opiV6vTd2uXQ1GF ApulU6IasNb58YkXkwLIvOkkYl4uS9NzMoYbUq14q9tMxncPbJ+OO+IA/Bn6rp0EIXx6 y6gDU7gvwPFzcYm5edJ2P5d9u6A43kcI4OZNgNImA8wALXcMAdTWQxsUlqx4ni1IrQHP yqs3cXCvS9TuRiFMvk29L+f0v7RuK+m08Z54n3lvu0X4OaZ4NL+E8oTDEsxSh423T4Sw rglb8cb16Uw6Wib/oV+A0/9scpXEvLN078NqrIwPPm5x6t66Y/Lr4sye6aUOSIU4iqN9 oLog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nRTceVwrQo7nc3Kc6KStQCnzuWIzRftiyAd8oL6fIFE=; b=gUz016ZBdD7ZjPYgkgUZSorCErdAfHTKfsqZrETXgFpfDZrBgAQnYIGX5O7iovk4qg EF+XNIUZHLWZpObg5IkUa8AoULityQO+C+MlkgpYyxi7pqmRUSQU3uoVYTpgwgAxbJCj htuAsypZsfkPxLzvcfJGUhkwmV1p4OxpbvYY4g20b4b394+wkmwNgjMVlPD2XRUhi0Ic uIPh3yGkZpE+B3wHt5lC+sHZnOfc0KiQ1u1vh323cMQ2nR6p/W4IVsA6b5srUAqP1OFB s/Mk/jvTG/pT+kC4/0tqSZrnkQOCIuJtlyhf1eIkei/BB7BLrVZGRjI3e9a+NRsna2ZE d1xA== X-Gm-Message-State: AOAM531mnFc4pegrIkYUgLNNG8Uls3jLwmbRrwKJkQson/LmYq8B8Uew pyBfS4Z5++hQzg3IfCez5gWRcQ== X-Google-Smtp-Source: ABdhPJz7jpiA+PzNI27E9IqxJ7o62Iz6jhCSYhdGO6EHIxHvY5p5FHzAXs1zPrxaX+LDxpqR6FO7sg== X-Received: by 2002:a17:902:b410:b029:d6:614b:679c with SMTP id x16-20020a170902b410b02900d6614b679cmr16035685plr.79.1605915339434; Fri, 20 Nov 2020 15:35:39 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id b3sm4721015pfd.66.2020.11.20.15.35.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2020 15:35:38 -0800 (PST) Date: Fri, 20 Nov 2020 16:35:37 -0700 From: Mathieu Poirier To: Tzung-Bi Shih Subject: Re: [PATCH v2 2/3] remoteproc/mediatek: skip if filesz is 0 Message-ID: <20201120233537.GH4137289@xps15> References: <20201116084413.3312631-1-tzungbi@google.com> <20201116084413.3312631-3-tzungbi@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201116084413.3312631-3-tzungbi@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201120_183543_793479_19162059 X-CRM114-Status: GOOD ( 24.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ohad@wizery.com, linux-remoteproc@vger.kernel.org, bjorn.andersson@linaro.org, linux-mediatek@lists.infradead.org, pihsun@chromium.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 16, 2020 at 04:44:12PM +0800, Tzung-Bi Shih wrote: > The main purpose of the loop is to load the memory to the SCP SRAM. > If filesz is 0, can go to next program header directly. > > We don't need to try to validate the FW binary for those filesz==0 > segments. > > Signed-off-by: Tzung-Bi Shih > --- > drivers/remoteproc/mtk_scp.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > index 0abbeb62cf43..74ed675f61a6 100644 > --- a/drivers/remoteproc/mtk_scp.c > +++ b/drivers/remoteproc/mtk_scp.c > @@ -234,12 +234,14 @@ static int scp_elf_load_segments(struct rproc *rproc, const struct firmware *fw) > u32 offset = phdr->p_offset; > void __iomem *ptr; > > - if (phdr->p_type != PT_LOAD) > - continue; > - > dev_dbg(dev, "phdr: type %d da 0x%x memsz 0x%x filesz 0x%x\n", > phdr->p_type, da, memsz, filesz); > > + if (phdr->p_type != PT_LOAD) > + continue; > + if (!filesz) > + continue; > + > if (filesz > memsz) { > dev_err(dev, "bad phdr filesz 0x%x memsz 0x%x\n", > filesz, memsz); > @@ -263,9 +265,7 @@ static int scp_elf_load_segments(struct rproc *rproc, const struct firmware *fw) > } > > /* put the segment where the remote processor expects it */ > - if (phdr->p_filesz) > - scp_memcpy_aligned(ptr, elf_data + phdr->p_offset, > - filesz); > + scp_memcpy_aligned(ptr, elf_data + phdr->p_offset, filesz); Reviewed-by: Mathieu Poirier > } > > return ret; > -- > 2.29.2.299.gdc1121823c-goog > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel