linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Wendy Liang <wendy.liang@xilinx.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: tejas.patel@xilinx.com, rajan.vaja@xilinx.com,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	manish.narani@xilinx.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] firmware: xlnx-zynqmp: fix compilation warning
Date: Fri, 20 Nov 2020 23:09:42 -0800	[thread overview]
Message-ID: <20201121070940.GA27301@wendy.liang@xilinx.com> (raw)
In-Reply-To: <f6719d16-9539-1046-28f4-7f9e82b8c6d1@xilinx.com>

On Fri, Nov 20, 2020 at 10:14:52AM +0100, Michal Simek wrote:
> 
> 
> On 18. 11. 20 23:31, Wendy Liang wrote:
> > Fix compilation warning when ZYNQMP_FIRMWARE is not defined.
> > 
> > include/linux/firmware/xlnx-zynqmp.h: In function
> > 'zynqmp_pm_get_eemi_ops':
> >  include/linux/firmware/xlnx-zynqmp.h:363:9: error: implicit
> >  declaration of function 'ERR_PTR'
> >  [-Werror=implicit-function-declaration]
> >      363 |  return ERR_PTR(-ENODEV);
> > 
> > include/linux/firmware/xlnx-zynqmp.h:363:18: note: each undeclared
> > identifier is reported only once for each function it appears in
> >    include/linux/firmware/xlnx-zynqmp.h: In function
> > 'zynqmp_pm_get_api_version':
> >    include/linux/firmware/xlnx-zynqmp.h:367:10: error: 'ENODEV'
> > undeclared (first use in this function)
> >      367 |  return -ENODEV;
> >          |          ^~~~~~
> 
> Are these issues caused by your AI driver?
> If not, can you please point me to .config which reports this issue?
It is from testbot, the ZYNQMP_FIMRWARE is not set.
The AI engine driver c file includes the firmware/xlnx-zynqmp.h. The file
doesn't include linux/err.h before including this xlnx-zynqmp.h file.
However, the AI engine driver includes other header which includes
linux/err.h.

It is good to include the linux/err.h explicitly too in the AI engine
file. But for the firmware/xlnx-zynqmp.h it will be better to include
linux/err.h as it is using it.

> 
> > 
> > Signed-off-by: Wendy Liang <wendy.liang@xilinx.com>
> > ---
> >  include/linux/firmware/xlnx-zynqmp.h | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h
> > index 5968df8..7b6f9fc 100644
> > --- a/include/linux/firmware/xlnx-zynqmp.h
> > +++ b/include/linux/firmware/xlnx-zynqmp.h
> > @@ -13,6 +13,10 @@
> >  #ifndef __FIRMWARE_ZYNQMP_H__
> >  #define __FIRMWARE_ZYNQMP_H__
> >  
> > +#if !IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE)
> 
> I don't think there is a real need to have this ifdef around.
> You can just ignore it and keep just below line.
[Wendy] if ZYNQMP_FIRMWARE is defined, this header doesn't need
linux/err.h shall we only include linux/err.h when it is required?

Thanks,
Wendy

> 
> > +#include <linux/err.h>
> > +#endif
> > +
> >  #define ZYNQMP_PM_VERSION_MAJOR	1
> >  #define ZYNQMP_PM_VERSION_MINOR	0
> >  
> > 
> 
> 
> Thanks,
> Michal

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-11-24  2:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-18 22:31 [PATCH] firmware: xlnx-zynqmp: fix compilation warning Wendy Liang
2020-11-20  9:14 ` Michal Simek
2020-11-21  7:09   ` Wendy Liang [this message]
2020-11-23  6:58     ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201121070940.GA27301@wendy.liang@xilinx.com \
    --to=wendy.liang@xilinx.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manish.narani@xilinx.com \
    --cc=michal.simek@xilinx.com \
    --cc=rajan.vaja@xilinx.com \
    --cc=tejas.patel@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).