From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_MULTIPLE_AT,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37BEFC56202 for ; Tue, 24 Nov 2020 02:50:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D44FE2071E for ; Tue, 24 Nov 2020 02:50:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="igEg/TLc"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="HMrQRz1j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D44FE2071E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dXfHAmdZ3BFEGa4O9CrBw1cA7eCEyMChzHEDGb5M+Mw=; b=igEg/TLcfQNuZJeHgi6FXgr5h LrIjEoagI9Kg3Z82+FNAIEi5UhJtEohSFnVy+Dg4QYL67OXCGjrTcUPsxjgMcpeCzDwq4t9f+wtNk EQkn067Cbs4b360Qhvqnf6rKeEiQhRbbWv75g6z7nPGtrX36y/RPSJnFz+r8SjrvXcNj/rvrRPL0C ziAhqlbxlsPzKlH9AvPXW8zYWs8rdSUZV/NxN4h8V6nvjcXiMhgPnlYhPDdxymy8BLqd0Dl2771NS XKtSNNHKgtNyR8x5A30qx4noeZMVZSgxFqkOCirpkuZpMVT67119ObOlhnSKyFRN8YIhmvCUNTcbt 4llaQJzLQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khOOT-0006eA-5j; Tue, 24 Nov 2020 02:49:25 +0000 Received: from mail-eopbgr750077.outbound.protection.outlook.com ([40.107.75.77] helo=NAM02-BL2-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khOOP-0006ck-94 for linux-arm-kernel@lists.infradead.org; Tue, 24 Nov 2020 02:49:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mQR/2R11WFaZAqjtyk+B7qAsLRFVTzc714L4+NhQVxy7Ud2Qb3g8JMx9ytUOuIsyk6RoaBuSjW0HZ0i/AbTzaLPSjLzyKTLqoKJBszqBg2jZyYI291zXmF5vPs5mpk0jM7MVnv6GeeWdzJXt61eNs0p771mW3XHJ8FPDVsT0kubEJMm/x+QSAkcXnx+4lHOJwh+uYEFgmC1gZLQq4bU7AW5UCm+tGoKBySpe62eostvz7FR8izm6uhIjAxZ6OSxM56TtJuxTrcqQHK4b5Zk3q7zKuMvNqpg3ioBnQtPqvZN7dZhMZwMgYQrl6XwSrsBRzU+PH3QYVXGctW9oq15HmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tbTAPa9FrO5uQzWHKVmb9rIePf2+pU4FaaeYwoxai3k=; b=japw+IJ7GcvrNaSSXYmdGvrMQSHTAt+aIcGOtl9fcHvk1PIl+N01BKRDMC1AXx1iaX8/bYazKMsIb2nmBmucfO2v3u0qAsXYwUgXAREiYWRm/2S9H3frxm67Vekr+J8RDKVD3S+uC9Q6opPEcbSeEojwzjd6isCxtSOQowFno9btbNoeUPmb7lII22qR8mf8yfbM6kroULHi2QzqpAM+dlMoY1eScXZi/jau2mFxGI+I2eVTqwtP6fTlxXYDaUaHoZxXhg6mJDaImgYQOMJ4pGwIoC1s1p192jn90eVQPIDMB8S+bRguFLf8IeQ04L6dg7LmS5HJesPM7LZbaUcECA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=linuxfoundation.org smtp.mailfrom=xilinx.com; dmarc=bestguesspass action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tbTAPa9FrO5uQzWHKVmb9rIePf2+pU4FaaeYwoxai3k=; b=HMrQRz1jw3+f/3ymu8IR3m40rbdr05B8KiFI6BdX5+vyFVCi7KlWQJi6lzYmorFMsRS2MlcCnKNpENWrN4ZG9W+BPLOqsLXcUtOO9no2t2QFkbA36uf18piSHC7qf7O4xZAOdditjbN090spRCtET6zbg4Gvbt9oYU1+nmqdB/s= Received: from SN4PR0401CA0043.namprd04.prod.outlook.com (2603:10b6:803:2a::29) by MWHPR02MB2879.namprd02.prod.outlook.com (2603:10b6:300:108::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.22; Tue, 24 Nov 2020 02:49:17 +0000 Received: from SN1NAM02FT018.eop-nam02.prod.protection.outlook.com (2603:10b6:803:2a:cafe::ac) by SN4PR0401CA0043.outlook.office365.com (2603:10b6:803:2a::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20 via Frontend Transport; Tue, 24 Nov 2020 02:49:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; linuxfoundation.org; dkim=none (message not signed) header.d=none;linuxfoundation.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT018.mail.protection.outlook.com (10.152.72.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3589.20 via Frontend Transport; Tue, 24 Nov 2020 02:49:17 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Mon, 23 Nov 2020 18:49:17 -0800 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.1913.5 via Frontend Transport; Mon, 23 Nov 2020 18:49:16 -0800 Received: from [172.19.2.167] (port=44362 helo=xsjjliang50.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from <"jliang@wendy.liang"@xilinx.com>) id 1khOOK-0003SF-Uh; Mon, 23 Nov 2020 18:49:16 -0800 Received: by xsjjliang50.xilinx.com (Postfix, from userid 13219) id B4CC61C054C; Fri, 20 Nov 2020 23:09:42 -0800 (PST) Date: Fri, 20 Nov 2020 23:09:42 -0800 From: Wendy Liang To: Michal Simek Subject: Re: [PATCH] firmware: xlnx-zynqmp: fix compilation warning Message-ID: <20201121070940.GA27301@wendy.liang@xilinx.com> References: <1605738706-375-1-git-send-email-wendy.liang@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b41690ab-6f66-47d2-944c-08d89023896e X-MS-TrafficTypeDiagnostic: MWHPR02MB2879: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p8PigK5eo0LwDdpBr5qi6V94F4SK2v4ot0i5ccGVPstO04foaURVz9UyorIpGoXDp/t6gW3OOocr10xLYHe/DtweGUfo3benvA4WrVWai2mtY1zYNJZaU8z+Gb9cwyYuVfspwGqMB8pnizuRHJMXOvgkN+JwGx/iH7f9pH6ZJGP4Pc01WA8JZKuOJg/HOG1Dlaq1XRf00Kga9do/Dt7NxJrIdgPE5YHCsUMfOrcbQy33H0r4hy2ESkoo3BMMkBk2Lu3D4I/iCi4u5EFNDts0ZvQ1C53KfGBJQ0cthnA401Mfjw0u+BinmP2YAAhWIgWvtYc9GNAxy7jbVkf+TpRjwSFKpmYvdt7MxCaVuKXaRm+pdFONc2/GRO6ecSgDfzLQZQuj/z4ZQn1asKb/7fT9lezJLEE5BnpNuSqPowJIYLY= X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch01.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(346002)(39860400002)(136003)(376002)(396003)(46966005)(54906003)(36756003)(36906005)(7636003)(8936002)(2906002)(316002)(82310400003)(9686003)(478600001)(42186006)(61793004)(82740400003)(83170400001)(356005)(44832011)(42882007)(336012)(6266002)(8676002)(6636002)(33656002)(47076004)(70586007)(426003)(26005)(83380400001)(4326008)(70206006)(6862004)(1076003)(5660300002)(186003)(102446001); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2020 02:49:17.6086 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b41690ab-6f66-47d2-944c-08d89023896e X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT018.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB2879 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_214921_395500_063E70B0 X-CRM114-Status: GOOD ( 22.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tejas.patel@xilinx.com, rajan.vaja@xilinx.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, manish.narani@xilinx.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 20, 2020 at 10:14:52AM +0100, Michal Simek wrote: > > > On 18. 11. 20 23:31, Wendy Liang wrote: > > Fix compilation warning when ZYNQMP_FIRMWARE is not defined. > > > > include/linux/firmware/xlnx-zynqmp.h: In function > > 'zynqmp_pm_get_eemi_ops': > > include/linux/firmware/xlnx-zynqmp.h:363:9: error: implicit > > declaration of function 'ERR_PTR' > > [-Werror=implicit-function-declaration] > > 363 | return ERR_PTR(-ENODEV); > > > > include/linux/firmware/xlnx-zynqmp.h:363:18: note: each undeclared > > identifier is reported only once for each function it appears in > > include/linux/firmware/xlnx-zynqmp.h: In function > > 'zynqmp_pm_get_api_version': > > include/linux/firmware/xlnx-zynqmp.h:367:10: error: 'ENODEV' > > undeclared (first use in this function) > > 367 | return -ENODEV; > > | ^~~~~~ > > Are these issues caused by your AI driver? > If not, can you please point me to .config which reports this issue? It is from testbot, the ZYNQMP_FIMRWARE is not set. The AI engine driver c file includes the firmware/xlnx-zynqmp.h. The file doesn't include linux/err.h before including this xlnx-zynqmp.h file. However, the AI engine driver includes other header which includes linux/err.h. It is good to include the linux/err.h explicitly too in the AI engine file. But for the firmware/xlnx-zynqmp.h it will be better to include linux/err.h as it is using it. > > > > > Signed-off-by: Wendy Liang > > --- > > include/linux/firmware/xlnx-zynqmp.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h > > index 5968df8..7b6f9fc 100644 > > --- a/include/linux/firmware/xlnx-zynqmp.h > > +++ b/include/linux/firmware/xlnx-zynqmp.h > > @@ -13,6 +13,10 @@ > > #ifndef __FIRMWARE_ZYNQMP_H__ > > #define __FIRMWARE_ZYNQMP_H__ > > > > +#if !IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE) > > I don't think there is a real need to have this ifdef around. > You can just ignore it and keep just below line. [Wendy] if ZYNQMP_FIRMWARE is defined, this header doesn't need linux/err.h shall we only include linux/err.h when it is required? Thanks, Wendy > > > +#include > > +#endif > > + > > #define ZYNQMP_PM_VERSION_MAJOR 1 > > #define ZYNQMP_PM_VERSION_MINOR 0 > > > > > > > Thanks, > Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel