From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A30C6C388F9 for ; Sat, 21 Nov 2020 23:13:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CE6621741 for ; Sat, 21 Nov 2020 23:13:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m7SgxwkJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="A+YJ2ig0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Oq3tI8Oz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CE6621741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4fFCKaigzLnQNXBDJJuXTsNLUCLlVT3ARNpN35ydodg=; b=m7SgxwkJ5O2VTIqFwHlKfm9xZ mjiaFqrtnpjsu717K4ZXTFzvUqt4ud9JB5VOXiKRdlXtihM1fCdOhNPDhFXOWJamIBMAcOL67a4Ho f/KY96p2J16gqZEHOa4Ik+awMTVFNUBXwT0boC6PmHwdoYYxZWqMwSqedPJ3+mFpjmyVZDs4coIcd gukPOGiynRXzpr+5mc3pg6zb352K0TkuItPgx9csCaOxgz50h1DgH0EN8e6uNVEh9ng0KXLTWNQOA HK/lhCxbvDveTuJenFX/bRgv65L3EWdRedr+RP7EyGQQmWZzUpj5/KmSF9P94qk3iw0Am8PILg2nc PHATV79vA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgc2w-0007ta-28; Sat, 21 Nov 2020 23:11:58 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgc2o-0007rg-3K for linux-arm-kernel@merlin.infradead.org; Sat, 21 Nov 2020 23:11:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description; bh=DtoX+1SRn0VFFP6K1lVSXhxvuiD/JSSM8kb4jv38uq0=; b=A+YJ2ig0Y7sNC4CBN4HnakqVO3 03uLWiT8jucprSQl4kGyCp0kJePKVMLtFnTc9XthnYhrR+a+Bc02gQDhdvQrAw3YLRZA43iLEFFmV mmuKbxUduq46wPSdSLUf8TQ/i2gZO2sVoQ+YbWiKU6dROnvsxPy4C/wJkZpmILBFoEXZcRJjzFMYg kV1/4cQeiddPGDFbd6hipUANqJLvZsPXG/Q3GPgBENYqb26+fw4q9IUqcQMD/ZUcEXriiGrUj7cpQ 4gXU8t52MvQ60F5oL3Nx/p4nX6QhgF70z2mHX1CjmkCiHN+RWUYg9YPwanKeO8WG/vce8NI3AjAZP 59Jx2dkg==; Received: from mail.kernel.org ([198.145.29.99]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgVny-0001vh-8Q for linux-arm-kernel@lists.infradead.org; Sat, 21 Nov 2020 16:32:09 +0000 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E8E9522206; Sat, 21 Nov 2020 16:32:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605976323; bh=hvZKMfDT45SrrDndTb88nBfj/K+dMn9SERmCh1poRBU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Oq3tI8Oz4rEXwir+kMVZH4uUSC7r4JxdX82Fi3ATqi4vr+Scc/oeUSxJyRGELne6v nabUVSzoXO0peaa0KabLXJmrdkKYWLhEFWh4JBY3H5h10VsIliDa5mt1JqWtbQTnXP cxi76GPl/rZeZny8fKb5bG11F9BSFj+Zyizb+md8= Date: Sat, 21 Nov 2020 16:31:57 +0000 From: Jonathan Cameron To: Kamel Bouhara Subject: Re: [PATCH v2] counter: microchip-tcb-capture: Fix CMR value check Message-ID: <20201121163157.086ae03b@archlinux> In-Reply-To: <20201115152617.GB2233@kb-xps> References: <20201114232805.253108-1-vilhelm.gray@gmail.com> <20201115152617.GB2233@kb-xps> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201121_163206_863578_515502FD X-CRM114-Status: GOOD ( 20.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, linux-iio@vger.kernel.org, William Breathitt Gray , linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 15 Nov 2020 16:26:17 +0100 Kamel Bouhara wrote: > On Sat, Nov 14, 2020 at 06:28:05PM -0500, William Breathitt Gray wrote: > > The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible values > > for CMR. This patch fixes the action_get() callback to properly check > > for these values rather than mask them. > > > > Fixes: 106b104137fd ("counter: Add microchip TCB capture counter") > > Cc: Kamel Bouhara > > Acked-by: Alexandre Belloni > > Signed-off-by: William Breathitt Gray > > --- > > Acked-by: Kamel Bouhara > Applied to the fixes-togreg branch of iio.git and marked for stable. Thanks, Jonathan > > drivers/counter/microchip-tcb-capture.c | 16 ++++++++++------ > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c > > index 039c54a78aa5..710acc0a3704 100644 > > --- a/drivers/counter/microchip-tcb-capture.c > > +++ b/drivers/counter/microchip-tcb-capture.c > > @@ -183,16 +183,20 @@ static int mchp_tc_count_action_get(struct counter_device *counter, > > > > regmap_read(priv->regmap, ATMEL_TC_REG(priv->channel[0], CMR), &cmr); > > > > - *action = MCHP_TC_SYNAPSE_ACTION_NONE; > > - > > - if (cmr & ATMEL_TC_ETRGEDG_NONE) > > + switch (cmr & ATMEL_TC_ETRGEDG) { > > + default: > > *action = MCHP_TC_SYNAPSE_ACTION_NONE; > > - else if (cmr & ATMEL_TC_ETRGEDG_RISING) > > + break; > > + case ATMEL_TC_ETRGEDG_RISING: > > *action = MCHP_TC_SYNAPSE_ACTION_RISING_EDGE; > > - else if (cmr & ATMEL_TC_ETRGEDG_FALLING) > > + break; > > + case ATMEL_TC_ETRGEDG_FALLING: > > *action = MCHP_TC_SYNAPSE_ACTION_FALLING_EDGE; > > - else if (cmr & ATMEL_TC_ETRGEDG_BOTH) > > + break; > > + case ATMEL_TC_ETRGEDG_BOTH: > > *action = MCHP_TC_SYNAPSE_ACTION_BOTH_EDGE; > > + break; > > + } > > > > return 0; > > } > > -- > > 2.29.2 > > > > -- > Kamel Bouhara, Bootlin > Embedded Linux and kernel engineering > https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel