From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6037CC388F9 for ; Sat, 21 Nov 2020 23:48:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE4DE20A8B for ; Sat, 21 Nov 2020 23:48:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="udAzQKj+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE4DE20A8B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jic23.retrosnub.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vSV9FAgUpxEb7V9KTG29Tpa+tjnSLpqYrU1iBLZZIQo=; b=udAzQKj+e9xmRTWdaf5ioboO9 NkRy7gKerDrGRRMZ8Rb6n8mp5nAKryhczdypsu0D6y99Wx0P8zPXt8ni2fCQeKdLAa4WNvhVASpfZ KSGFXCUWGMPvfDimpQt+8z2H0CuF4xECowqtmvekptMIupIPtMXdu8+ET8BUkrOgN/Zdoct5VxieX tijyg2Ke6Z0tNn5mKSbt7MoeO4f9SP8dIGKNRSKsaLorStsJhuZK7fuk0HXX0qs2p4Oi2XD8rxWrq um0L7OuF2tBrrQDmzh+s3jkFjZCLmaf3TwpGxQNz1H8F8u55UmPSHlEaL2GHLzUAh2Zu4rUcEg9af 1hSQHtJBQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgcba-0007Lk-V4; Sat, 21 Nov 2020 23:47:46 +0000 Received: from saturn.retrosnub.co.uk ([2a00:1098:86::1:1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgcbX-0007Jr-Jx; Sat, 21 Nov 2020 23:47:44 +0000 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) by saturn.retrosnub.co.uk (Postfix; Retrosnub mail submission) with ESMTPSA id 44EAF9E0076; Sat, 21 Nov 2020 16:39:21 +0000 (GMT) Date: Sat, 21 Nov 2020 16:39:19 +0000 From: Jonathan Cameron To: Qinglang Miao Subject: Re: [PATCH v2] iio: adc: rockchip_saradc: fix missing clk_disable_unprepare() on error in rockchip_saradc_resume Message-ID: <20201121163919.2fcb9e71@archlinux> In-Reply-To: <20201108154128.57f4162f@archlinux> References: <20201103120743.110662-1-miaoqinglang@huawei.com> <20201108154128.57f4162f@archlinux> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201121_184743_775435_F2673BBB X-CRM114-Status: GOOD ( 22.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lars-Peter Clausen , Heiko Stuebner , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Peter Meerwald-Stadler , Robin Murphy , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 8 Nov 2020 15:41:28 +0000 Jonathan Cameron wrote: > On Tue, 3 Nov 2020 20:07:43 +0800 > Qinglang Miao wrote: > > > Fix the missing clk_disable_unprepare() of info->pclk > > before return from rockchip_saradc_resume in the error > > handling case when fails to prepare and enable info->clk. > > > > Fixes: 44d6f2ef94f9 ("iio: adc: add driver for Rockchip saradc") > > Suggested-by:Robin Murphy > > Signed-off-by: Qinglang Miao > > Looks good to me. I'll just give it a little longer on the list so Heiko > and others have a chance to sanity check it. > Applied to the fixes-togreg branch of iio.git and marked for stable. Thanks, Jonathan > Thanks, > > Jonathan > > > --- > > v2: remove useless braces because early return is pointless. > > > > drivers/iio/adc/rockchip_saradc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c > > index 1f3d7d639..12584f163 100644 > > --- a/drivers/iio/adc/rockchip_saradc.c > > +++ b/drivers/iio/adc/rockchip_saradc.c > > @@ -462,7 +462,7 @@ static int rockchip_saradc_resume(struct device *dev) > > > > ret = clk_prepare_enable(info->clk); > > if (ret) > > - return ret; > > + clk_disable_unprepare(info->pclk); > > > > return ret; > > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel