From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E123EC56201 for ; Sun, 22 Nov 2020 04:46:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 858462078D for ; Sun, 22 Nov 2020 04:46:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="3J8eA457"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LhkL/kdy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 858462078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Dpvq6pOGgxkrB4PgddcRh1lDV3gPcZu7kgTFq06ikhs=; b=3J8eA457e0jIFZFyZAyG9SDHR 12dMpWZghUakfLCbpIrUP5TS8dzwNLF8+oPE/cBV6dY4/iDO1sP3WxISI6v2TsAS60q4xkZbGmBop jSTCqroeP5P1cL6mv1aKzcKblH8Ipg88pU8hSN18itlQyzKLqzf2bANtTnlCz7/5bVm6cLB3hTw1o O/Rtg1ewviW9RR+LMZvkpO5gSxfk6SWfBV8n/TynltQZWua/StEit2mlNTCPrN3XhtA/7lHzr4NFl Rxs8gWg+kidY5TXtYcAzV2XDcvvWHIdANTA4Woeo4lB1NFSOzfVNr1XoucKn93u9xGk82bdo8GO6L QoOVqi0ag==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kghEz-0002Ya-BY; Sun, 22 Nov 2020 04:44:45 +0000 Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kghEw-0002Xt-63 for linux-arm-kernel@lists.infradead.org; Sun, 22 Nov 2020 04:44:43 +0000 Received: by mail-ot1-x343.google.com with SMTP id o3so12825365ota.8 for ; Sat, 21 Nov 2020 20:44:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=ofKTU8s93Yu2rM/fmGaOrrNeXKEZaodPNsHLyk7YFKc=; b=LhkL/kdyA5u95rH07pm/9mhJeB0WBhvhTtcGxY3w7nA40Rb7/tKY/SEvi2brBOO2b2 yL0LLjPcEpenC0C8UcwXjtO4tDg29+JUIJO6Fr4LLctEKdCL68wVoihefre/nVFMTTgK t9TDVRa5Lp2x21kJd3tdJ8JKXVjw2a0ELRISJfn9kTF7+ahWpl7YHbo4ygWqAl3eowfm 46cZi48/sEl8Bxv3IpTlUkU75fzasnDqvimKl3pajwGqyriJIMpyXWyUSUjQJaqk1Xze cJmHdGH2Kwb+lmtZ45yaxvSZMyrd8OivvxMm5idQRwDrVumhIZYwNmhzobQxGldTSca0 IeJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ofKTU8s93Yu2rM/fmGaOrrNeXKEZaodPNsHLyk7YFKc=; b=DOe8ASYAfwXNlQ7gCVEl6Y+T0tekkqm9nLx/dJNobGM3fwugNukc2lWzNrKzF9fvTH otpBmSxT9QrFI0O4pT7abBWu79UxMtpq5/dxgUN+ANkG4Rt2kuSGMVjGvzLeDyxpkM9x 3TsR/Q24n0jAG0ZeYWhK6PuF1qli0Pf/xbohB3dsj+oaPvwhBN/RSFwa7QcuRJ4+ln5h jjSSF3lg4IA+ZWqokj+VZUrLecUzkJ0tAuXM3KBwHwE8KAANcubbPfGbfgSiDJyyuPi8 32VMM2MKVn6kXMRfbQK8ar1k6XsBRjPCg8leozB6cuVWYZ7NlnxSQjgf9sEijdoomCfW phlg== X-Gm-Message-State: AOAM530fyihimXEKvETsV1uMd8TR11bQBg39fP3S2BQ1y6JRQY+CHT36 1xtzj3phspeUQWTeRyF62wgkvw== X-Google-Smtp-Source: ABdhPJyu8MOKaGOM4pcmWlx5aDi5lhHtms/5L7yJ6jZ8ns80O/XzxBRa6aCQ8cGCi4Jt6TalL/Sxqg== X-Received: by 2002:a9d:1a6:: with SMTP id e35mr19589299ote.238.1606020279605; Sat, 21 Nov 2020 20:44:39 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id t5sm4382777oth.16.2020.11.21.20.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Nov 2020 20:44:38 -0800 (PST) Date: Sat, 21 Nov 2020 22:44:34 -0600 From: Bjorn Andersson To: "N?colas F. R. A. Prado" Subject: Re: [RFC PATCH 1/3] leds: Add driver for QPNP flash led Message-ID: <20201122044434.GG95182@builder.lan> References: <20201106165737.1029106-1-nfraprado@protonmail.com> <20201106165737.1029106-2-nfraprado@protonmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201106165737.1029106-2-nfraprado@protonmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201121_234442_532090_1AE96D1E X-CRM114-Status: GOOD ( 18.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, lkcamp@lists.libreplanetbr.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross , Russell King , Luca Weiss , Rob Herring , linux-leds@vger.kernel.org, Pavel Machek , andrealmeid@collabora.com, Brian Masney , Georgi Djakov , linux-arm-kernel@lists.infradead.org, Dan Murphy Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri 06 Nov 10:58 CST 2020, N?colas F. R. A. Prado wrote: > Add driver for the QPNP flash LED. It works over SPMI and is part of the > PM8941 PMIC. > = > Signed-off-by: N=EDcolas F. R. A. Prado > --- > drivers/leds/Kconfig | 9 + > drivers/leds/Makefile | 1 + > drivers/leds/leds-qpnp.c | 1351 ++++++++++++++++++++++++++++++++++++++ > 3 files changed, 1361 insertions(+) > create mode 100644 drivers/leds/leds-qpnp.c > = > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > index 849d3c5f908e..ca5f6e81c064 100644 > --- a/drivers/leds/Kconfig > +++ b/drivers/leds/Kconfig > @@ -928,6 +928,15 @@ config LEDS_ACER_A500 > This option enables support for the Power Button LED of > Acer Iconia Tab A500. > = > +config LEDS_QPNP > + tristate "Support for QPNP LEDs" > + depends on SPMI > + help > + This driver supports the flash/torch led of Qualcomm PNP PMIC. > + > + To compile this driver as a module, choose M here: the module will > + be called leds-qpnp. > + Downstream they seem to have a single "led driver" dealing with all the LED related interfaces in the PMIC. We have WLED upstream already and I've been poking at an "LPG" driver. So as you look into Jacek's request please make this a "qcom spmi flash driver", instead of a "qpnp leds" driver. Regards, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel