From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E1D4C2D0E4 for ; Mon, 23 Nov 2020 04:04:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B833E2074B for ; Mon, 23 Nov 2020 04:04:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fs+yeMoy"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="UzncrOzD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B833E2074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4IStUQanEHC8AMegfhHdDCAdEoFjpky04HAs5cn3fYg=; b=fs+yeMoyLM/gfQ6QWpPEF0NU+ J2Um3+Tx88mHrX6AKR7kDmsp0t9KD9joJTeifmlDzPMWmuBAw5DLXnIIYOR9TPjvLHNbzfMlBLJ6z uSUHdpWv9sawlAmeJsXKNpGUbaHLDul65S594tqdG20J4Gy1ViMfyp90rJfJYlSGEXHwNIQOQVtNO aV0Agwi7bmEv05eFyvbveBTxg3JTVYCYqiZaiUrL+I5zWeJw5n0l71/wVAqMgihQN3nzRkuxCF4tT 8uoSiH61/c3b4JB3kP/H+5GJGGoBuIFRNGF53bEJCsZ6wRDt0aWLUUMhGjuwdcT40kUZmC1e8Ur+Z 8hLr7uMgQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kh33x-0005DH-M6; Mon, 23 Nov 2020 04:02:49 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kh33u-0005C2-3t for linux-arm-kernel@lists.infradead.org; Mon, 23 Nov 2020 04:02:47 +0000 Received: by mail-pg1-x543.google.com with SMTP id 81so13036545pgf.0 for ; Sun, 22 Nov 2020 20:02:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yR5CqZG96T7B8FOyDG6DEb0BKOLXt2vj8oVOlshnWBU=; b=UzncrOzDAnf6+OdZfi3ny2MkrTnhc8VldtziLzNK8bgMM3LmlxOVpo9O16sGU+cuh8 Y90K4iWZ4PpNvLJYIUd+hAeeoXt7glhzQrpAbJOUoXAwIY+48LhN0BWP//3yEGxnAwXc 5+qaYlGlk9fI1Z2DJ8o97O58CQfUL9zuR5KdE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yR5CqZG96T7B8FOyDG6DEb0BKOLXt2vj8oVOlshnWBU=; b=dIrG4Fj+RsO+3NES2AzyseErQfBAXp275DfDIze+N3Dl6EIfoJQRyvXBWSsdnEn02z CcNUIWxicpQpyM2GdAu9oI674YavE3vAH6L5KpuEW04KPjz3coDS6iMlnFzvcjqffP0W /fzCNC9h/+rkiYefGNbmf/Ab0n4J2NGDWh47HeQm6x3ckd1LOAnXQ3capK3ZOwJbH7Pt MgYBu2PKoQ+ZPBmMlT+hhr4+xGWheWoTEFSl6m8jya0ycQ4GyYUK8lz3GzL7crzRHtAC KeUnxNbluFURFkHWKQOwBLkRwoHlgMJSHPgOy6eHm7A+Ey9GYVzIhGp2yEtF0KVu9ujc YoSw== X-Gm-Message-State: AOAM532F5KwC3eW4idDSYqkwMUaja5rmUxlFY5y0a2TVCEeNin3+qtvm 8ElbLnqZ8xy6KVz/Zfm2Uni7Sg== X-Google-Smtp-Source: ABdhPJzQ1fPZRBdR6Uv8knK7dPKl+RmDLBbZB8Wy/U5bnUBV5Jc9w+Uc2rBiKh2kQvaAX9GJNz6Whw== X-Received: by 2002:a63:c00b:: with SMTP id h11mr25323450pgg.7.1606104162288; Sun, 22 Nov 2020 20:02:42 -0800 (PST) Received: from chromium.org ([2401:fa00:1:b:f693:9fff:fef4:a8fc]) by smtp.gmail.com with ESMTPSA id s21sm8942192pgm.65.2020.11.22.20.02.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Nov 2020 20:02:41 -0800 (PST) Date: Mon, 23 Nov 2020 12:02:37 +0800 From: Ikjoon Jang To: Weiyi Lu Subject: Re: [PATCH v5 23/24] arm64: dts: mediatek: Add mt8192 clock controllers Message-ID: <20201123040237.GA3013347@chromium.org> References: <1604887429-29445-1-git-send-email-weiyi.lu@mediatek.com> <1604887429-29445-24-git-send-email-weiyi.lu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1604887429-29445-24-git-send-email-weiyi.lu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201122_230246_211664_BF5CD520 X-CRM114-Status: GOOD ( 20.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Nicolas Boichat , srv_heupstream@mediatek.com, Stephen Boyd , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Yingjoe Chen , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 09, 2020 at 10:03:48AM +0800, Weiyi Lu wrote: > Add clock controller nodes for SoC mt8192 > > Signed-off-by: Weiyi Lu > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 163 +++++++++++++++++++++++++++++++ > 1 file changed, 163 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > index e12e024..92dcfbd 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > @@ -5,6 +5,7 @@ > */ > > /dts-v1/; > +#include > #include > #include > #include > @@ -213,6 +214,24 @@ > }; > }; > > + topckgen: syscon@10000000 { > + compatible = "mediatek,mt8192-topckgen", "syscon"; > + reg = <0 0x10000000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + infracfg: syscon@10001000 { > + compatible = "mediatek,mt8192-infracfg", "syscon"; > + reg = <0 0x10001000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + pericfg: syscon@10003000 { > + compatible = "mediatek,mt8192-pericfg", "syscon"; > + reg = <0 0x10003000 0 0x1000>; > + #clock-cells = <1>; > + }; > + There are 26 new bindings for mt8192 clock providers, "mediatek,mt8192-*'. I guess the one reason of doing this is that those mmio blocks are just scattered all around over different memory regions. I wonder if there could be a simpler way of merging them into one binding of "mediatek,mt8192-clocks" and converting all new bindings into generic syscon: mt8192-clocks: mt8192_clocks { compatible = "mediatek,mt8192-clocks"; #clock-cells = <1>; infracfg: clk_infracfg { syscon = <&syscon_infracfg>; }; pericfg: clk_pericfg { syscon = <&syscon_pericfg>: }; }; syscon_pericfg: syscon@10003000 { compatible = "syscon"; reg = <0 0x10003000 0 0x1000>; }; ... > pio: pinctrl@10005000 { > compatible = "mediatek,mt8192-pinctrl"; > reg = <0 0x10005000 0 0x1000>, > @@ -238,6 +257,12 @@ > #interrupt-cells = <2>; > }; > > + apmixedsys: syscon@1000c000 { > + compatible = "mediatek,mt8192-apmixedsys", "syscon"; > + reg = <0 0x1000c000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > systimer: timer@10017000 { > compatible = "mediatek,mt8192-timer", > "mediatek,mt6765-timer"; > @@ -247,6 +272,12 @@ > clock-names = "clk13m"; > }; > > + scp_adsp: syscon@10720000 { > + compatible = "mediatek,mt8192-scp_adsp", "syscon"; > + reg = <0 0x10720000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > uart0: serial@11002000 { > compatible = "mediatek,mt8192-uart", > "mediatek,mt6577-uart"; > @@ -267,6 +298,12 @@ > status = "disabled"; > }; > > + imp_iic_wrap_c: syscon@11007000 { > + compatible = "mediatek,mt8192-imp_iic_wrap_c", "syscon"; > + reg = <0 0x11007000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > spi0: spi@1100a000 { > compatible = "mediatek,mt8192-spi", > "mediatek,mt6765-spi"; > @@ -379,6 +416,12 @@ > status = "disabled"; > }; > > + audsys: syscon@11210000 { > + compatible = "mediatek,mt8192-audsys", "syscon"; > + reg = <0 0x11210000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > i2c3: i2c3@11cb0000 { > compatible = "mediatek,mt8192-i2c"; > reg = <0 0x11cb0000 0 0x1000>, > @@ -392,6 +435,12 @@ > status = "disabled"; > }; > > + imp_iic_wrap_e: syscon@11cb1000 { > + compatible = "mediatek,mt8192-imp_iic_wrap_e", "syscon"; > + reg = <0 0x11cb1000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > i2c7: i2c7@11d00000 { > compatible = "mediatek,mt8192-i2c"; > reg = <0 0x11d00000 0 0x1000>, > @@ -431,6 +480,12 @@ > status = "disabled"; > }; > > + imp_iic_wrap_s: syscon@11d03000 { > + compatible = "mediatek,mt8192-imp_iic_wrap_s", "syscon"; > + reg = <0 0x11d03000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > i2c1: i2c1@11d20000 { > compatible = "mediatek,mt8192-i2c"; > reg = <0 0x11d20000 0 0x1000>, > @@ -470,6 +525,12 @@ > status = "disabled"; > }; > > + imp_iic_wrap_ws: syscon@11d23000 { > + compatible = "mediatek,mt8192-imp_iic_wrap_ws", "syscon"; > + reg = <0 0x11d23000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > i2c5: i2c5@11e00000 { > compatible = "mediatek,mt8192-i2c"; > reg = <0 0x11e00000 0 0x1000>, > @@ -483,6 +544,12 @@ > status = "disabled"; > }; > > + imp_iic_wrap_w: syscon@11e01000 { > + compatible = "mediatek,mt8192-imp_iic_wrap_w", "syscon"; > + reg = <0 0x11e01000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > i2c0: i2c0@11f00000 { > compatible = "mediatek,mt8192-i2c"; > reg = <0 0x11f00000 0 0x1000>, > @@ -508,5 +575,101 @@ > #size-cells = <0>; > status = "disabled"; > }; > + > + imp_iic_wrap_n: syscon@11f02000 { > + compatible = "mediatek,mt8192-imp_iic_wrap_n", "syscon"; > + reg = <0 0x11f02000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + msdc_top: syscon@11f10000 { > + compatible = "mediatek,mt8192-msdc_top", "syscon"; > + reg = <0 0x11f10000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + msdc: syscon@11f60000 { > + compatible = "mediatek,mt8192-msdc", "syscon"; > + reg = <0 0x11f60000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + mfgcfg: syscon@13fbf000 { > + compatible = "mediatek,mt8192-mfgcfg", "syscon"; > + reg = <0 0x13fbf000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + mmsys: syscon@14000000 { > + compatible = "mediatek,mt8192-mmsys", "syscon"; > + reg = <0 0x14000000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + imgsys: syscon@15020000 { > + compatible = "mediatek,mt8192-imgsys", "syscon"; > + reg = <0 0x15020000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + imgsys2: syscon@15820000 { > + compatible = "mediatek,mt8192-imgsys2", "syscon"; > + reg = <0 0x15820000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + vdecsys_soc: syscon@1600f000 { > + compatible = "mediatek,mt8192-vdecsys_soc", "syscon"; > + reg = <0 0x1600f000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + vdecsys: syscon@1602f000 { > + compatible = "mediatek,mt8192-vdecsys", "syscon"; > + reg = <0 0x1602f000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + vencsys: syscon@17000000 { > + compatible = "mediatek,mt8192-vencsys", "syscon"; > + reg = <0 0x17000000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + camsys: syscon@1a000000 { > + compatible = "mediatek,mt8192-camsys", "syscon"; > + reg = <0 0x1a000000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + camsys_rawa: syscon@1a04f000 { > + compatible = "mediatek,mt8192-camsys_rawa", "syscon"; > + reg = <0 0x1a04f000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + camsys_rawb: syscon@1a06f000 { > + compatible = "mediatek,mt8192-camsys_rawb", "syscon"; > + reg = <0 0x1a06f000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + camsys_rawc: syscon@1a08f000 { > + compatible = "mediatek,mt8192-camsys_rawc", "syscon"; > + reg = <0 0x1a08f000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + ipesys: syscon@1b000000 { > + compatible = "mediatek,mt8192-ipesys", "syscon"; > + reg = <0 0x1b000000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + mdpsys: syscon@1f000000 { > + compatible = "mediatek,mt8192-mdpsys", "syscon"; > + reg = <0 0x1f000000 0 0x1000>; > + #clock-cells = <1>; > + }; > }; > }; > -- > 1.8.1.1.dirty > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel