From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E52A4C63777 for ; Mon, 23 Nov 2020 06:49:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 798C720773 for ; Mon, 23 Nov 2020 06:49:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NaU+SVwq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XYMS5tzY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 798C720773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VhmhMdt571WSGUanyQMpB8lIAmY/UZMLZSn/HruAnLg=; b=NaU+SVwqzDVWBqPOIe+gukLup dXewMC+ojtTJa0FL4rGf2OCmLq/6p/eodJEKnPC7i9mAXzfO5O0o4uYsbiJhPqG0dnzb22FkYcbXl e5W6xAmicwnf1rqWdddf7lG75N2TTFyS61EVhXlyF2TAPZ5AGL9+nHrxx15310io4A4ZK38lizZVw gmGftFvwKaKJmLTW3COQEf3yGVKdQY2qMzb8yTZEewO5cPn8wzrpUnu01YfiD2GmWEya6ee07CqMc mLBVUjHJUJYuKtOfQTQ+RJR9tfeJG0MFdZgXVB3e9/Fmo3BcTUtf/7Usfr9ZrXzcuvaT8cV4F9+4C opOjL+Qtg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kh5eT-00077f-Gm; Mon, 23 Nov 2020 06:48:41 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kh5eQ-00076Y-Pl for linux-arm-kernel@lists.infradead.org; Mon, 23 Nov 2020 06:48:39 +0000 Received: by mail-pl1-x642.google.com with SMTP id s2so8367480plr.9 for ; Sun, 22 Nov 2020 22:48:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PJ6JaHRxor/ka0JdqIrqxbD/WGFaxB9On6PE/7mwuFQ=; b=XYMS5tzYB1db+4HRLPGMZ6FL5f1juIfSv/FApljURg0meQvGkiDEuFZ54vN5rtTgEj rKKcf25pAoLQEKlcFKjsYOpw21tUMZgdY/WqxMyiDNf0wfDyjHju0OMSm56n4Sfq6pA/ nt1BmRy2l5WXG5fmjeaBP80o8M4/dz29UbJn6atWupWnL+lZGVbd6cgfF3NUfYbRGuMD G2cYiAUh1mK/WxX9PW8VZD5SOmE5MCWhji+AYddIo9aeOpR5pls5YyOoVyWPpTgU1R5f 1kSOmRSEGs8TW6Wojj6NS13uktjjbeWPfjNzDOqZdM1v6n8yLhgeKj6ebdT8rvQp8wag HpPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PJ6JaHRxor/ka0JdqIrqxbD/WGFaxB9On6PE/7mwuFQ=; b=YqRI6DPzGUwh0bekKujqOeYCEQwEYP8JXPHUeFT6bCM7GA1FW1kxvYX6zIxNm+uI+n Qs1lTFZ1hs7zHPz/qJs88cJiki9gOwqCwXXM/Civm5yO+ZtuxB0dxGZKCyelWjeMLNeh /DtdvtjIL0ntrgP6zjEJP8gDG5CvXrR8ikRj3GSKt0qaXTYC2vviPpFgE81PseN7XkX8 hY4zQIixHyDZ8/DcC7Msbxzl7EUfo9g/2M5kPgpdDrp5EJ+5tKYKR1rOPUn9ol/ll0Hq Mlda0tEpULW6SChDod94GnSdpPfHzHcJqnV2KZEEGN2QTxu6Md9luTtIFOpgTGno/p9y 2Wxg== X-Gm-Message-State: AOAM530Qwu93hRFilrGpMqk+7qJOBYtUOR3pvBdajTBEuPAyKBtAacos XCUA7T/O4gx0enOQTG2cNas= X-Google-Smtp-Source: ABdhPJy/4jDe0Ku9Pn49P4SSO2HrfayI73kSBKrChviAZvZl4QhUhlWxRpjvJa9Ahc8AwXb0XUbvDQ== X-Received: by 2002:a17:902:a9c7:b029:d6:da66:253c with SMTP id b7-20020a170902a9c7b02900d6da66253cmr22954681plr.19.1606114114340; Sun, 22 Nov 2020 22:48:34 -0800 (PST) Received: from dtor-ws ([2620:15c:202:201:a6ae:11ff:fe11:fcc3]) by smtp.gmail.com with ESMTPSA id b29sm9660730pgn.87.2020.11.22.22.48.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Nov 2020 22:48:33 -0800 (PST) Date: Sun, 22 Nov 2020 22:48:31 -0800 From: Dmitry Torokhov To: Linus Walleij Subject: Re: [PATCH 1/3 v2] Input: atmel_mxt_ts - Fix up inverted RESET handler Message-ID: <20201123064831.GZ2034289@dtor-ws> References: <20201104153032.1387747-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201104153032.1387747-1-linus.walleij@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_014838_859941_41AB189F X-CRM114-Status: GOOD ( 17.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , NXP Linux Team , Pengutronix Kernel Team , linux-input@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 04, 2020 at 04:30:30PM +0100, Linus Walleij wrote: > This driver uses GPIO descriptors to drive the touchscreen > RESET line. In the existing device trees this has in > conflict with intution been flagged as GPIO_ACTIVE_HIGH > and the driver then applies the reverse action by > driving the line low (setting to 0) to enter > reset state and driving the line high (setting to 1) to > get out of reset state. > > The correct way to handle active low GPIO lines is to > provide the GPIO_ACTIVE_LOW in the device tree (thus > properly describing the hardware) and letting the GPIO > framework invert the assertion (driving high) to a low > level and vice versa. > > This is considered a bug since the device trees are > incorrectly mis-specifying the line as active high. > > Fix the driver and all device trees specifying a reset > line. > > Cc: Krzysztof Kozlowski > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-tegra@vger.kernel.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: NXP Linux Team > Cc: Pengutronix Kernel Team > Signed-off-by: Linus Walleij Applied, thank you. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel