From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17371C2D0E4 for ; Mon, 23 Nov 2020 14:55:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A46EC20658 for ; Mon, 23 Nov 2020 14:55:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Uo57k6/S"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="UboGT20O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A46EC20658 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w1ynaVDedUWclgp9BgGTOu3dBHjMnjjpwBcLd2qelUs=; b=Uo57k6/SxCT4OEOLYy6u7B3KD 9rK2ROUNC/ryaDTEfBhGn4B3ikk22Rr1ZTJKzfEVIOVvGsVCNRvcLfxc6sbA4PP2QXb3VduHEuI1r Dl5VS1Bj+M/1xcQ/dIxNNaFmgrvC3y5K3NDvfSIBX9Udc2cTib4SplC6vpAdzPATAWAQEYUKXL/4Q HgD9B/oV4IH4dHCT5Ty90ycYyKRji5X1TRsQXRg9TuS3MEEsOZwTAhqAJswd6FG8nLupH1b6fcurN T/hinZqHmhWfN/1cDROvx1ZMC5ENQn3Spl93FY/+GTMZMNyyPZ9z2JRiOPJqqPdUPBRTUL0pizPlp EoKFrIUXQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khDEb-00031D-KK; Mon, 23 Nov 2020 14:54:29 +0000 Received: from mail-oo1-xc44.google.com ([2607:f8b0:4864:20::c44]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khDEZ-0002zh-51 for linux-arm-kernel@lists.infradead.org; Mon, 23 Nov 2020 14:54:27 +0000 Received: by mail-oo1-xc44.google.com with SMTP id i30so1772778ooh.9 for ; Mon, 23 Nov 2020 06:54:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ypQOivTTwdFzb+/3Z+R/AYhQITc/BOXMPX6lQujmA4Y=; b=UboGT20Ox8squh3d2ZnQggVw2BtXqKOdT/s+tMz0g3csU8VHrONyW5B1YMIwVnvOpJ BVhxs2al+NwQ7/SMb4AlCm1HMMGJIkJ4dUHbEsfPSfhv/PIufUJTEUVTBAPFNlUKZ9Zi VKFmopTXQh23vKUrupe0vcmMB14nl3Hn7cotKcM8aBbzk456BuyKe5yx9hTMYsX63paI 4j7Ui6K4z4tm29cT38tR4eWypwKe4Xidf2ELMd1Qpxa2/nRlkTKR0TWiestlDZlqI08W sKPIQQJFrEgp6sIsBBB9itZyqPLE01pGzbEgFzuhnLBxKeAzPwL09o/fP2akKmeTbh+d TzSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ypQOivTTwdFzb+/3Z+R/AYhQITc/BOXMPX6lQujmA4Y=; b=o8vjJIpkMUg61sZ4te8so9OxRYXY92C0WHdCiU21+qFMnUeAkUs8EldWvcfJLRtJzk 2X4l6YQrtB4xYSKo3+OVb5wkrhpL7AN4cF5vv9ZTmNlfd2W173QFPEAMxbnb2z8OxPzR lmOmHGL1AXDdWcE60gK284yYjwEMupEePsN7fcolcnEwd+6KJR/twI/RzeQ1KMN2LRoW wPHDHhw+UbrCaU1vQ5ZFRyJVMK/aEROfy+fTbIUXOpQgOP+KT8MYZb45dsPyAyzWjDkf mSkmp6TYzR0yfEbWuiwb6fjo6YYRDxxF8zBHZf01FIQm0Vl5J8AHPU/jbyrV+zYIxx5O M1gQ== X-Gm-Message-State: AOAM532YzTV4SGtcNQ5kwpMjps7QNFvOpNevSSwTlcBvyBFkSQMl9Ivf 5bv2GGOVNo0F5A/p+4HvJmtF7A== X-Google-Smtp-Source: ABdhPJzgVQxYNSqFrGNwH41jxDIJClFraR7USL+/G1e6AcGi818QPZSMAXsn1Sq3067Whhx8WgkjEw== X-Received: by 2002:a4a:eac1:: with SMTP id s1mr23273490ooh.15.1606143264324; Mon, 23 Nov 2020 06:54:24 -0800 (PST) Received: from google.com ([2a01:4b00:8523:2d03:acac:b2ef:c7d:fd8a]) by smtp.gmail.com with ESMTPSA id 43sm6858710otf.28.2020.11.23.06.54.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 06:54:23 -0800 (PST) Date: Mon, 23 Nov 2020 14:54:20 +0000 From: David Brazdil To: Quentin Perret Subject: Re: [RFC PATCH 09/27] KVM: arm64: Allow using kvm_nvhe_sym() in hyp code Message-ID: <20201123145420.hjl24xp6p2nn26u2@google.com> References: <20201117181607.1761516-1-qperret@google.com> <20201117181607.1761516-10-qperret@google.com> <20201123125723.4mnodg3tnal4q4v2@google.com> <20201123140250.GB490744@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201123140250.GB490744@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_095427_211070_EE5AE8C3 X-CRM114-Status: GOOD ( 21.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" , kernel-team@android.com, Frank Rowand , Suzuki K Poulose , android-kvm@google.com, Catalin Marinas , open list , Rob Herring , James Morse , "moderated list:ARM64 PORT \(AARCH64 ARCHITECTURE\)" , Marc Zyngier , Will Deacon , "open list:KERNEL VIRTUAL MACHINE FOR ARM64 \(KVM/arm64\)" , Julien Thierry Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 23, 2020 at 02:02:50PM +0000, 'Quentin Perret' via kernel-team wrote: > On Monday 23 Nov 2020 at 12:57:23 (+0000), David Brazdil wrote: > > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > > > index 882eb383bd75..391cf6753a13 100644 > > > --- a/arch/arm64/kvm/arm.c > > > +++ b/arch/arm64/kvm/arm.c > > > @@ -1369,7 +1369,7 @@ static void cpu_prepare_hyp_mode(int cpu) > > > > > > params->vector_hyp_va = kern_hyp_va((unsigned long)kvm_ksym_ref(__kvm_hyp_host_vector)); > > > params->stack_hyp_va = kern_hyp_va(per_cpu(kvm_arm_hyp_stack_page, cpu) + PAGE_SIZE); > > > - params->entry_hyp_va = kern_hyp_va((unsigned long)kvm_ksym_ref(__kvm_hyp_psci_cpu_entry)); > > > + params->entry_hyp_va = kern_hyp_va((unsigned long)kvm_ksym_ref_nvhe(__kvm_hyp_psci_cpu_entry)); > > > > Why is this change needed? > > You mean this line specifically or the whole __kvm_hyp_psci_cpu_entry > thing? > > For the latter, it is to avoid having the compiler complain about > __kvm_hyp_psci_cpu_entry being re-defined as a different symbol. If > there is a better way to solve this problem I'm happy to change it -- I > must admit I got a little confused with the namespacing along the way. Yeah, we do need a more robust approach. It's getting out of control. > > Thanks, > Quentin > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel