From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D978C56202 for ; Mon, 23 Nov 2020 16:24:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C8DE2083E for ; Mon, 23 Nov 2020 16:24:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lolOyJYq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C8DE2083E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jF2fgx1k8/Z6qQzpSLnkXLBRYze9mB7FkpUYn3G7J2g=; b=lolOyJYqReLOGnfL87U359RfK wL43bg9RhtApbRuq67hgPJLKvYWkrobgtj0otdou5zlsv7NKqtjwcy/j7m6gy3r5sb697RiKzC1RX oT3+otXsTAlhGe+l3XHfAQw1hxdnj7Tufw9oB5VgYdVdzNCibp9qpgJyU1cP+ViZ8psZX1rTUhSwB wANv6VDJ1OiMunEi2YHYnZcMPxr59ZUNhRGa9L+Xej49OG1Sm3IUGm7CyddUbgaW8RY5GV78j3SEB cq/Z7+79eUEOA2lGCB/ZNsFHxNfd2GwV9lG7iVUkxtRVgdX8X3NF0671azNG9HK5acJp1HNYvfvQb sk+xB4nTw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khEct-0006Ae-Nx; Mon, 23 Nov 2020 16:23:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khEcq-00069o-O7 for linux-arm-kernel@lists.infradead.org; Mon, 23 Nov 2020 16:23:37 +0000 Received: from gaia (unknown [95.146.230.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 40A342080A; Mon, 23 Nov 2020 16:23:33 +0000 (UTC) Date: Mon, 23 Nov 2020 16:23:30 +0000 From: Catalin Marinas To: "Eric W. Biederman" Subject: Re: [PATCH v21 1/2] signal: define the SA_EXPOSE_TAGBITS bit in sa_flags Message-ID: <20201123162329.GB2438@gaia> References: <13cf24d00ebdd8e1f55caf1821c7c29d54100191.1605904350.git.pcc@google.com> <87h7pj1ulp.fsf@x220.int.ebiederm.org> <20201123114935.GD17833@gaia> <87y2isysra.fsf@x220.int.ebiederm.org> <20201123155946.GA2438@gaia> <87sg90xd2n.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87sg90xd2n.fsf@x220.int.ebiederm.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_112336_927004_756FB3F0 X-CRM114-Status: GOOD ( 29.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Collingbourne , Helge Deller , Kevin Brodsky , Oleg Nesterov , linux-api@vger.kernel.org, "James E.J. Bottomley" , Kostya Serebryany , Linux ARM , Andrey Konovalov , David Spickett , Vincenzo Frascino , Will Deacon , Dave Martin , Evgenii Stepanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 23, 2020 at 10:17:20AM -0600, Eric W. Biederman wrote: > Catalin Marinas writes: > > On Mon, Nov 23, 2020 at 09:53:13AM -0600, Eric W. Biederman wrote: > >> Catalin Marinas writes: > >> > On Fri, Nov 20, 2020 at 05:22:58PM -0600, Eric W. Biederman wrote: > >> >> Peter Collingbourne writes: > >> >> > Architectures that support address tagging, such as arm64, may want to > >> >> > expose fault address tag bits to the signal handler to help diagnose > >> >> > memory errors. However, these bits have not been previously set, > >> >> > and their presence may confuse unaware user applications. Therefore, > >> >> > introduce a SA_EXPOSE_TAGBITS flag bit in sa_flags that a signal > >> >> > handler may use to explicitly request that the bits are set. > >> >> > > >> >> > The generic signal handler APIs expect to receive tagged addresses. > >> >> > Architectures may specify how to untag addresses in the case where > >> >> > SA_EXPOSE_TAGBITS is clear by defining the arch_untagged_si_addr > >> >> > function. > >> >> > > >> >> > Signed-off-by: Peter Collingbourne > >> >> > Acked-by: "Eric W. Biederman" > >> >> > Link: https://linux-review.googlesource.com/id/I16dd0ed2081f091fce97be0190cb8caa874c26cb > >> >> > --- > >> >> > To be applied on top of: > >> >> > https://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git signal-for-v5.11 > >> >> > >> >> I have merged this first patch into signal-for-v5.11 and pushed > >> >> everything out to linux-next. > >> > > >> > Thank you Eric. Assuming this branch won't be rebased, I'll apply the > >> > arm64 changes on top (well, if you rebase it, just let me know so that > >> > we don't end up with duplicate commits in mainline). > >> > >> No. I won't be rebasing it. Not unless something serious problem shows > >> up, and at that point I will be more likely to apply a corrective change > >> on top that you can also grab. > > > > Thanks Eric. During the merging window, I'll probably wait for you to > > send the pull request first just to keep the arm64 diffstat simpler. > > > > BTW, did you mean to base them on v5.10-rc3-391-g9cfd9c45994b or just > > v5.10-rc3? It doesn't matter much as I'll generate the diffstat manually > > anyway in my pull request as I have different bases in other branches. > > Crap. How did that happen? I thought for certain I had based them on > v5.10-rc3. Some random git commit is not a good base. I think the > better part of valor is to just admit I goofed and not rebase even now. > > It it would make your life easier I will be happy to rebase (onto > v5.10-rc3?). I just wanted to get these into my tree so that we could > incremetnally commit to the changes that makes sense and be certain not > to loose them. Please rebase onto -rc3 if there's not much hassle. Thanks. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel