From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EC81C56202 for ; Mon, 23 Nov 2020 16:50:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADA5020717 for ; Mon, 23 Nov 2020 16:50:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YZ8lH/Bm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="eZkzFwIb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADA5020717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yA2ASllpmbOH5WIvz0C8c/M8yfkbI+NvRjFF8BIyVnU=; b=YZ8lH/Bmabzl9WSVdUPn58Xum lAC1JFEdxLK5GN4Q7fhbKyn9ktVDgGKZqHeBUF39uVBo8z+basZ3+qVE4zt8eAzP/eTG+A4/k67Ag gALM3lsG6Oynkl1oG61MNEYRs8oVS40XTdet1JFGpXjnO9a5oUsG/GABWY1WsOlPn9piGRButr4j4 oWtpHxVssV3a5HEr5YdRsHE6jzI4uLD4gV/i3PXzw+l0lGcIxikmz12JAkr4WuKDAMvTHb1+wJIlV /t17qDUMBzSqcuLlhnRtlrvi19hFvHrfGNRyKRo77Ru/DWKAv8+4qzC64lo3ANeX53gTsJvLn3Piw DmuHFBGLw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khF1J-0002Bd-7B; Mon, 23 Nov 2020 16:48:53 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khF1H-0002Ae-2c for linux-arm-kernel@lists.infradead.org; Mon, 23 Nov 2020 16:48:51 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 82EA520717; Mon, 23 Nov 2020 16:48:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606150130; bh=ARuPgpdEJcSeF2gm4TH6D3zIPUtJVSXUazCL6eofvtY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eZkzFwIbcGWn1pF2cCwkM9QWKaWhbBLfrlR5scjzuLzYN7EuBE9PNsmCz/sd62Bd2 ol1J06dGh4Gnthl8GuICOurG5vhJZhQ+lnmvTBWlDQz0s3desFT3sncQu1b7JunKpc LArLadFWviiaTBFBU7BuAPj9MaR2PIgD/mDK5zTE= Date: Mon, 23 Nov 2020 16:48:45 +0000 From: Will Deacon To: Linus Torvalds Subject: Re: [PATCH 3/6] tlb: mmu_gather: Remove unused start/end arguments from tlb_finish_mmu() Message-ID: <20201123164844.GB11494@willie-the-truck> References: <20201120143557.6715-1-will@kernel.org> <20201120143557.6715-4-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_114851_243328_034A376F X-CRM114-Status: GOOD ( 17.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yu Zhao , Anshuman Khandual , Peter Zijlstra , Catalin Marinas , Linux Kernel Mailing List , Linux-MM , Minchan Kim , Android Kernel Team , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 20, 2020 at 09:20:43AM -0800, Linus Torvalds wrote: > On Fri, Nov 20, 2020 at 6:36 AM Will Deacon wrote: > > > > tlb_finish_mmu() takes two confusing and unused 'start'/'end' address > > arguments. Remove them. > > Ack, but please add the history to it. > > Those arguments were used, up until 7a30df49f63a ("mm: mmu_gather: > remove __tlb_reset_range() for force flush"). > > And the thing is, using a range flush in theory might be better, but > for simplicity it's now doing a "fullmm" one, which is why those > arguments no longer matter. > > (And I think we track the range better now too, which may be another > reason they aren't needed) Yes, thanks for digging that up. I'll add it to the commit message in v2. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel