From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 368B8C2D0E4 for ; Mon, 23 Nov 2020 17:00:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B978420727 for ; Mon, 23 Nov 2020 17:00:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GPTpNwvb"; dkim=temperror (0-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="uk9OY4nH"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="aoDKlIpj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B978420727 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=etSTY8sHsUwa8lsmbLa75p8zCyjKmFSuMQE8ch0PjPg=; b=GPTpNwvbh/OW1u/DSc2FdjbFU NiygmpVLP916FITNyF6AeawIwCIU/CX2PWmc0pd/1bA5msfOLqHxa8DARMveMW4Admz7dkdMEY898 62F/2QzqxIgbR1f/0cQV9In4wjnVdo7dSAY7fCulT+RsLHvDEOS+f0OGYA/5RquULxcO30doHoy3J VSIFo8VS/9ZiUBPJr3q5OAGx5nAizScJQkSrzeX4s2B9rDlfW9e30WlDtJNwgXmHh9MbUOwkkYTaA SmLKFig1359/aiMyEjc/35onvdYGu8gkON86A7GzAcIkA0UTXzX0oYKF+BSYaXw5qhc3Fv5ceX0gE bHxdhL7CQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khFC1-0005bI-Sk; Mon, 23 Nov 2020 16:59:57 +0000 Received: from wnew1-smtp.messagingengine.com ([64.147.123.26]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khFBz-0005ZN-4z; Mon, 23 Nov 2020 16:59:56 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id C342A1B18; Mon, 23 Nov 2020 11:59:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 23 Nov 2020 11:59:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=wgFC61OjVWSeDUPQwJ2H5QF9kkH 3TAPaV4Y3u3AaIYg=; b=uk9OY4nHe2ExPoPigh2ddXjV69rW60dkum2bzVcDef2 Dm/JMZ5/tgeJ39N7W1YCrL3QvfJt5kZ6GLmX8wBfT/ZG58vjmj3GsVy6PAm6ANaV VKLX0QlQ4ZJMbhWK6A6hULHdphoP5mX26MPCI6wyNl+zYcmhYZMSBwL9Uj6/9W33 JD2WXoL7fZRCXPO0dqZWjBN1Zk+dWaalzU3eXVJxPH194gNvG1yZw5yoQFiVqOFI IrmkpvQEmqn9wfsGtrLyk+iMV6JyU4vzOoqclRC6fgcqhLJ5sijHYUT83voW2nqC MvIcVQ/j/MAARaUEDM4F578n3etNBIIn/3QsGBbFaEA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=wgFC61 OjVWSeDUPQwJ2H5QF9kkH3TAPaV4Y3u3AaIYg=; b=aoDKlIpjcMWlJtqpoPxaVl 0F8HJSpzV5GMDJoehG1jPfOO/UKuQXIAQ/eTjPayrB7l3q2YfCg5PuhnVro7ArA2 B3GFTAYAERioaujunp3503c1zPGaXXdwN7tW6LXyG1G03SqLpXNlfV7jORp1DlPA fOUXBPjQ+ye7srByG795GaoUS5KKYZCSrvmjL+qYblIgUYOYJv3w6LCp8C6ubqCc i5zDZznJC52Ql9gB5A3wT8/K4vnEyalgq4zGtUnSnBqEl0pVZicFntXO5asryLBT 3ODHifhR0dYjDy66dZJkqfnfLag+UFbTPMBQOc4/csCAgBf31ka2ZJ+JWlrenA8w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudegiedgleejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 261B23064AB0; Mon, 23 Nov 2020 11:59:45 -0500 (EST) Date: Mon, 23 Nov 2020 17:59:44 +0100 From: Maxime Ripard To: Thomas Zimmermann Subject: Re: [PATCH v4 2/2] drm/vc4: kms: Don't disable the muxing of an active CRTC Message-ID: <20201123165944.bl3544yiehlg65ma@gilmour> References: <20201120144245.398711-1-maxime@cerno.tech> <20201120144245.398711-3-maxime@cerno.tech> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_115955_533187_DF6EF7CB X-CRM114-Status: GOOD ( 16.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Gover , Dave Stevenson , David Airlie , Maarten Lankhorst , dri-devel@lists.freedesktop.org, Phil Elwell , Eric Anholt , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Daniel Vetter , Hoegeun Kwon , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============4571642709759762131==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4571642709759762131== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="u3w37pnpjw7z6bqw" Content-Disposition: inline --u3w37pnpjw7z6bqw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 23, 2020 at 08:50:49AM +0100, Thomas Zimmermann wrote: >=20 >=20 > Am 20.11.20 um 15:42 schrieb Maxime Ripard: > > The current HVS muxing code will consider the CRTCs in a given state to > > setup their muxing in the HVS, and disable the other CRTCs muxes. > >=20 > > However, it's valid to only update a single CRTC with a state, and in t= his > > situation we would mux out a CRTC that was enabled but left untouched by > > the new state. > >=20 > > Fix this by setting a flag on the CRTC state when the muxing has been > > changed, and only change the muxing configuration when that flag is the= re. > >=20 > > Fixes: 87ebcd42fb7b ("drm/vc4: crtc: Assign output to channel automatic= ally") > > Reviewed-by: Hoegeun Kwon > > Tested-by: Hoegeun Kwon > > Signed-off-by: Maxime Ripard >=20 > Reviewed-by: Thomas Zimmermann Applied both, thanks! Maxime --u3w37pnpjw7z6bqw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX7vqgAAKCRDj7w1vZxhR xROsAP0aZVtxJjmk1by+aRI2aZyJtkL2fvYypDyiv6PRTsJRhAD/Rzd7SP6uc72O LrpebYd2FmmHTG+tN75O1WB2c7Db8wg= =a2y6 -----END PGP SIGNATURE----- --u3w37pnpjw7z6bqw-- --===============4571642709759762131== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4571642709759762131==--