From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CC2CC388F9 for ; Mon, 23 Nov 2020 22:00:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A75A0206CA for ; Mon, 23 Nov 2020 22:00:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HtmjJbHP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A75A0206CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oBgMMcw2yoQm6y/t4F44xyCFBcxasyHo90EsvS35Wc4=; b=HtmjJbHPM0YYAZ7nkWjatM6+k 1ENl7gPoQ475JLumCTl2HFZw5Q4zd45JAgJd6hUp9Ot+FLF/GTYuB1a4pJsQGNGAzvegR4UFREVm1 mnZOmU6WpCAsz/JI+SgOqIte5qebj64yCSmK1ZFUU71Mk1PIv3ro+OdTNK8LPJG8X6ULn+vNJGLoM 3Re+09j8MynQ+Syad5zxmwttL1FMTe9jYtPz1oqpK5cpWmGk66/kWW+zc24xL/yr0mpsbP02Sr8ZR jvu4AmNDbX25KYXnsKL2T10sAMNVfuo+M1lHvR1470nrNcXcsm7NmA5En30qQryWgXkXKAI7RJFEE t3e/i5ljg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khJrb-0008Jz-6X; Mon, 23 Nov 2020 21:59:11 +0000 Received: from asavdk3.altibox.net ([109.247.116.14]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khJrY-0008JJ-Bt for linux-arm-kernel@lists.infradead.org; Mon, 23 Nov 2020 21:59:09 +0000 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 203A920060; Mon, 23 Nov 2020 22:59:06 +0100 (CET) Date: Mon, 23 Nov 2020 22:59:04 +0100 From: Sam Ravnborg To: Linus Walleij Subject: Re: [PATCH] drm/mcde: Fix RGB/BGR bug Message-ID: <20201123215904.GA676783@ravnborg.org> References: <20201117175413.869871-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201117175413.869871-1-linus.walleij@linaro.org> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VbvZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=VwQbUJbxAAAA:8 a=j8Cu_9a8AAAA:8 a=KKAkSRfTAAAA:8 a=7gkXJVJtAAAA:8 a=sngfz7gVtQOnW0fYQYUA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=A2jcf3dkIZPIRbEE90CI:22 a=cvBusfyB2V15izCimMoJ:22 a=E9Po1WZjFZOl8hwRPBS3:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_165908_520024_DD11735D X-CRM114-Status: GOOD ( 16.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephan Gerhold , Maarten Lankhorst , Maxime Ripard , dri-devel@lists.freedesktop.org, phone-devel@vger.kernel.org, Sean Paul , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Linus. On Tue, Nov 17, 2020 at 06:54:13PM +0100, Linus Walleij wrote: > I was confused when the graphics came out with blue > penguins on the DPI panel. > > It turns out that the so-called "packed RGB666" mode > on the DSI formatter is incorrect: this mode is the > actual RGB888 mode, and the mode called RGB888 is > BGR888. > > The claims that the MCDE had inverse RGB/BGR buffer > formats was wrong, so correct this and the buggy > register and everything is much more consistent, and > graphics look good on all targets, both DPI and > DSI. > > Cc: phone-devel@vger.kernel.org > Cc: Stephan Gerhold > Signed-off-by: Linus Walleij Looks fine and seems to do what you write it should do. I do not understand why this part: > case DRM_FORMAT_BGR888: > val |= MCDE_EXTSRCXCONF_BPP_RGB888 << > MCDE_EXTSRCXCONF_BPP_SHIFT; > + val |= MCDE_EXTSRCXCONF_BGR; > break; does not use MCDE_EXTSRCXCONF_BPP_BGR888 But maybe there is no counterpart to MCDE_DSICONF0_PACKING_BGR888? Assuming all is good despite my confusion: Reviewed-by: Sam Ravnborg _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel