From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBAA7C2D0E4 for ; Tue, 24 Nov 2020 10:32:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23DA4206D4 for ; Tue, 24 Nov 2020 10:32:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="F1x+B6Yf"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="ETh0HkMA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23DA4206D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lcjsq8HgabJ0cMZPZKP0rhFhCRqrP5GhKwApEwiijY8=; b=F1x+B6YfuG6P4LG4RQ616Zzqt Tr1AuSkgO43gYVDdUrt5qrw148Ds+9CVPOloQxCH05RlytR/I9Tw1WlXVjHuFPWnur7eSpnFsjwUi RWSzX7QxxJMPLiOKuYOaOmbSCUTv8um+Qlwqp5Q13Ok9aoandrjps/9iOv6ENapFixLTLPwwYT5QN G887Ichxk7SWt0PxAHwXbUHRB9Kh0rlmW4liGmhHXu7VLedVp29lqKBQJPNqiI/1ecjPmWjvc7sj7 6Dm7KRU4RJmTnOvfDYDxIraIk8Y+lUhMhCUmOYYJaClME2DRF6O/ZYePGTn9fQ6Z397jez0pRSMXG JQTyHqwIg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khVbo-0000E5-VU; Tue, 24 Nov 2020 10:31:41 +0000 Received: from mail-eopbgr60043.outbound.protection.outlook.com ([40.107.6.43] helo=EUR04-DB3-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khVbm-0000Bq-7m for linux-arm-kernel@lists.infradead.org; Tue, 24 Nov 2020 10:31:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U/Dlwd+dXnOzioQDCWbg2WZ+HhAOBnWeY2PCJAtKdp2bIRp46hXNFjWyiiGfQ3Ewkv860EcjnGlMnkVK3w5RUpTJPJM3nii2OPhEwiwNXiNFlVWelFXIMhPja78npouwFwCXJ8FCJcx0TE+e0AEMqYgSNRkWqWmQbZhVdWOZrs4YUdxlH7nG9+RaG5q0eLJKhdJCGhtu8+KNCtIoGoHyyEVqSXwB/ZRzEQKcMjmgqwAX8J2wZzWW919/g5oT8dS2dhB7Rz9195bSn1KYBfoQhagdQz/K5nqlXRjOjOd/peCoXF4ajioD5ZjOmTIrZ3bl7xX1Rz1QJzXP+EffbuK9nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EmYcCYfBJi0ZncfTxnmmV04EAAzsmluPoEzy14sUg68=; b=VD2nTKAVYlbXych8NIWp4a1ZIDsGzrs+T2y2F9eXLyecM51lEqioOre5sFVNhBsYVVP8xZ37ejaPS+t81vPxAmjlOugTNGbXtt2Mh4O/nNEbHS1Sdkph22gFhFYJtRCmdislMMEwrUCvQJJIVFG94PnnCgPuMdA+5k51GNMoukQr1C+k1c8KKQsSuqm9qhAlU0EDpyxCGZ0RzhmI/N1Bj8kNuqyVs2jY6Zcd/FsEjIED3S86PMrhG/FrUVpxXJxbD1+DM2VxbfqT37CzPq2gvlMIq/KiThdB9f4Se57FzPJ6hcZSIVm4PONtYHX4KDotaSoRNyFH2FQqpiAq6LqUbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EmYcCYfBJi0ZncfTxnmmV04EAAzsmluPoEzy14sUg68=; b=ETh0HkMAiKwhXT7ZIQnMZd+Z9Jr88W4F+XwopmCo6QxkVM/SI8+ud+hyLFEg3cjTgmWzckHzivPj4CKL1g/xwsAEfhe8nF5cBf3bd+EGfA9fPdtBRBvwcanjyoC1CmJvRfpo08SHcAMo7VxXjouMBXCC1U19o1hc0SYk9LWgec0= Received: from VI1PR04MB5696.eurprd04.prod.outlook.com (2603:10a6:803:e7::13) by VI1PR0402MB2800.eurprd04.prod.outlook.com (2603:10a6:800:b8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20; Tue, 24 Nov 2020 10:31:29 +0000 Received: from VI1PR04MB5696.eurprd04.prod.outlook.com ([fe80::2dd6:8dc:2da7:ad84]) by VI1PR04MB5696.eurprd04.prod.outlook.com ([fe80::2dd6:8dc:2da7:ad84%5]) with mapi id 15.20.3589.030; Tue, 24 Nov 2020 10:31:29 +0000 From: Vladimir Oltean To: "Y.b. Lu" Subject: Re: [PATCH] arm64: dts: ls1028a: make the eMMC and SD card controllers use fixed indices Thread-Topic: [PATCH] arm64: dts: ls1028a: make the eMMC and SD card controllers use fixed indices Thread-Index: AQHWvovBrojMBFt1EECB86LxwqdSo6nQRb0AgAB8rICABirOgIAABiUAgAAMfQCAAAInAIAAAhyAgAAYuwA= Date: Tue, 24 Nov 2020 10:31:29 +0000 Message-ID: <20201124103128.zucizod344dgme4o@skbuf> References: <20201119155025.965941-1-vladimir.oltean@nxp.com> <20201120093015.duel3yx63cbya77w@skbuf> <71a86b0fbc95892f8fd240e0919e7e23@walle.cc> <3293d698bf26ecf08f22e7e2ffe55e74@walle.cc> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [188.25.2.120] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 1839ef6a-70f2-4ceb-fbdc-08d890641aba x-ms-traffictypediagnostic: VI1PR0402MB2800: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JEsV4vo6UkGD/1YbVDbPL1HsSy44EBYJ1e+RjyN5S/ACfNiegg6jAQ/joi8bWB2Qs+WGR0ESOAN14x9b6a7eYguUK/CXMoW79JqVcdMicUlIO3blyc7moWKU3nLW177T2TFwHigtODJeN7gj+zFbFtaj6KUZkS1MAMk+I3J41Vrwe8BOGmWnkl+cuFc12Eo8LZt2/oBiUbcWeSze/P/mJEiAoMILTd1SBh8cI3u9ERLUCmu/oNM0OGOj31CLqxxtXBV4Od8YVS98PO7532bAcmVWw54+lSx8xi41ROFJJbX0l2/6OBCYtiWSYfh8hvne1hWKQ5ynnh0dGSw2Ugh3vA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5696.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(7916004)(4636009)(346002)(39860400002)(136003)(396003)(376002)(366004)(33716001)(6862004)(26005)(316002)(44832011)(1076003)(4326008)(8936002)(478600001)(71200400001)(86362001)(6486002)(6636002)(66476007)(66946007)(9686003)(8676002)(66446008)(64756008)(76116006)(54906003)(6506007)(66556008)(6512007)(5660300002)(186003)(4001150100001)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: MvvHGRBD7llVtFN3H28T4LjebPHi2IAlC9VJrDtdU74OmMRkxyGMSD+qmT7FpifYQviuxTCcxwmmISjeqlPPGX86vHd8pSlPVFuujohIyhAX0e39TgPEeyyRI4U+hrueJzvWQFHNXCBMjXgy6igtKP3XiRocgXGVMZ4wwhsU9NERxDsUa4TmBHhaHvUaJRGE6z+2qGp/9zUP4Ztdy/2RI3+mLWU6Dus515hjTDN9W13OcTwX2IVL9lkumEan0C0jNYf9RrQUSjxhCEYe7B2D+e2+rs/R3PpUCcHTPpiILuFxwdTQNwovvonNIdnfCOqJ+lETLoI261+5a9h89QKzHjLWpKbaIwuqDeBiR2U8K7+QQb1KUcosDJqcb2xBGWZhDMZtPI9r0jGQvY5+sVIXt8RSpFUDmUdguXm6GmRCuRLSPk3k20bZ+yVXuPeqpc3Z/qTVQgfA1M6dQa5o9E1JM7dU6pkKMZ1RPU/DsQZGfwzHhtXaRweEG5rHtfHbz6CiqbBTc9uv3rzAl3nhGJrSqIEMIXE1FWuhTkChKsWUipupPdRBORWMthslrfv2oJbtW0/RCPladK0FWtFxYDNcWMlGzJrIckbJzpOGql/Qnwnk8YaYNhE3BIWSb7mTAAje4dHAdpDKiPa25xEcEoA1VoMtyOxi4clyGE6zFQ2eFvLK5PYJF1vyMaCn2K3X+9ylVEHuRxQjXCqezRYBzst2Ezfe7qZHNMZvHxRcw6cOBnzq8Q4yozJ/CUq/glfOiNMYOgkmV2sXj6IBXeNoo1IH+UYuebeksI8ZqIMC4Cs8P1SNjAni3c7X03yLBpAJIAXmfCGr6ohpYXkVZ3aqLWQ9HK/awJ8TsrKmcqjH3BiSy1MbO+SlrvocnHsdzCDC83nsCuKljsjcu8bkux2e+sbARA== Content-ID: <85D12CB16FCD95419E232278741C5556@eurprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5696.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1839ef6a-70f2-4ceb-fbdc-08d890641aba X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2020 10:31:29.1137 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cEjM3f6ReCWQD/A5yBhUIXyCpjHOHgo5zO5XB0I+64dCBpleSez9TyjLAi7EbjDmi/5KcUnMb7lPqT6ooV0uXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2800 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201124_053138_310051_0E84A7E0 X-CRM114-Status: GOOD ( 25.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Ulf Hansson , Ashish Kumar , "linux-kernel@vger.kernel.org" , "linux-mmc@vger.kernel.org" , Adrian Hunter , Leo Li , Michael Walle , Rob Herring , Shawn Guo , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Yangbo, On Tue, Nov 24, 2020 at 09:02:57AM +0000, Y.b. Lu wrote: > > Am 2020-11-24 09:47, schrieb Y.b. Lu: > > > Hi Michael, > > >> > I don't think it's a problem in board dts to define board specific > > >> > thing, like re-defining alias, and disabling any IP it not using. > > >> > > >> First, why would you put it in the architecture include anyway? That > > >> is really board-specific. That is like you would say, we enable all > > >> devices and a board could potentially disable it. TBH it seems that > > >> this will fit your reference boards and you don't care about the > > >> other ones which uses that include. > > > > > > In soc dtsi, this is giving default alias for two esdhc controllers. > > > This is not board specific. > > > That's natural esdhc0 is mmc0 and esdhc1 is mmc1. > > > > How could this be not board specific if there are at least three > > different use cases the board can choose from - and needs three > > different configurations: > > > > (1) eMMC at /dev/mmcblk0, SD card at /dev/mmcblk1 > > (2) SD card at /dev/mmcblk0, eMMC at /dev/mmcblk1 > > (3) no eMMC at all, SD card at /dev/mmcblk0 > > Not matter it's SD card or eMMC card, if it's on esdhc0, use /dev/mmcblk0. > Not matter it's SD card or eMMC card, if it's on esdhc1, use /dev/mmcblk1. With the note here that you can't actually connect an SD card to eSDHC1, due to the lack of pins for CD/WP. > It's not related to board and card type, it's only related to esdhc interface in use. I understand the hardware-centric view that you are coming from. It may be natural for you that eSDHC0 is for the SD card and eSDHC1 is for eMMC, because these are the designations in the SoC. But it is also natural for a customer to define the indices according to their schematics and what they use. If, say, there is a board that only uses eMMC, I would expect that for the lay person, no one would even bat an eye if that was called /dev/mmcblk0. Whereas, if it was called /dev/mmcblk1 (and there was no /dev/mmcblk0 in the system), maybe you'd have to come up with some explanations which could be avoided. I am only a passerby when it comes to the MMC subsystem. But in networking/DSA, it is frequent that the board designer comes up with their own numbering scheme, which has nothing to do with the numbering of the chip. Consider this extreme case from arch/arm/boot/dts/ls1021a-tsn.dts: sja1105: ethernet-switch@1 { ports { port@0 { /* ETH5 written on chassis */ label = "swp5"; }; port@1 { /* ETH2 written on chassis */ label = "swp2"; }; port@2 { /* ETH3 written on chassis */ label = "swp3"; }; port@3 { /* ETH4 written on chassis */ label = "swp4"; }; }; }; You just have to go along with how the hardware is being used in the product. I could have insisted that hardware switch port 0 is named as swp0, but that would have not helped anybody. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel