From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6601C56201 for ; Tue, 24 Nov 2020 11:29:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A4612073C for ; Tue, 24 Nov 2020 11:29:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gcwFIhav"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="n1gpM2Nl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A4612073C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pXPgcotSeO1vKiLug9cEgzH2XQB0pY2qw04WZQU9SIE=; b=gcwFIhavwJbAwhJgdOpcXUAJk Yof+8j+0aLWp+DZhp/O41akcJjfJMMr+9WdzA22ee7j/ulkXevXTCcNP8Xfr8cXc70AH46EKaWMwf wvm4DXHE1A5+8U6AzFXP6ow+mNNUVogdBWQ8eRjUNQS3SdKKW28TG2tVvgL5BFqHslxo2kxQeY1Ph eGWCn3jYwDswXVHxV5Z3kYY8FEqZR2PqJvatBAoxLt1p8xUtkeo/kYedsCtL4BDBC34hQX6EvqqZ4 ED7nkbYoDpZmI0GvEZBupgEofH52/n1e6dsb+/hx7WrZCgfrp3JeoV+NktVs6IKKYBtyan0N/U002 4RGxQ3OKQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khWUo-0002P1-P6; Tue, 24 Nov 2020 11:28:30 +0000 Received: from mail-vi1eur05on2061.outbound.protection.outlook.com ([40.107.21.61] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khWUk-0002OG-LP for linux-arm-kernel@lists.infradead.org; Tue, 24 Nov 2020 11:28:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hwrfn5N7plgdlz11hyjnfdF4I06UTYUio4hDGvm1X5sFKf6EaR4CkGXo92r8aUMErGKu40rnGy6tgXa+iLJxiwTVuIhnaa8dWyb825y88az8IhawF5yfabMY5c/GhG2bF6PdlpznkD7/6eyNQEHjh1uaTRPgbB6/rkjYhINIpVnPZ59Zq55wKb9AmOjJE2jhMuIF4mz4K6QllphDW1Jrl5/pfoIQJ9Uzn0l0izDMjVPs4yjMuQs67aE5RHLbVIS4wZ8SpzQEnfFQeWtST/UOjyPXDQqDa8doaO1vmMiwNy27wsOAw763QBTj4pnznlP6LdQGT7H2OlOnzNpvGDa1mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D1MALWwujwbNysiYh9YDyT7LXmxOl5+zy3PgRyCjRdA=; b=jfolN6WOF5bqJ834aCAhRJwx1ioJW6A69g6Uq5eu8TGYUF2EJMJD9AV+8JDJZD0Xhs9moAjD0woJ6WYD7GobgvVS5voHSqjFCqE3npoUkRTnMdQeihhMQM4+Hoq3O28axXkFHzekc3DDliaSiVfKXODRykjk0Tg5tcpcr5jsYQaivlU7mFYLKrwMxfh15PDgFksXWjrH+btzHzxews1JqectmkokNNXGnWndoCvrLmxVZCctksJuGXkN0n1BZzQVIBaN2Aoa0fqTLubgbK1SDt+b8Aln5xli9Z1VJBW5fe6X1gpoIiNlGJkVpbnitizctKy65rYjsJBQAWo8qYa23g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D1MALWwujwbNysiYh9YDyT7LXmxOl5+zy3PgRyCjRdA=; b=n1gpM2NlcDKJdbPgabKVkkDpArwnfjoe6+LianflGZFg1B1EFq4cgT6XrutrCS1vxMdxvyEaLnw+IdalNHlGY8S22NSU8c16LkST0uG0jdPOTFG9uieqEYa2ZqmbBZCgq7b9e4aSx3oIFRZkvKtZKB0Xk1v/094XxJKyTDVCD8c= Received: from VI1PR04MB5696.eurprd04.prod.outlook.com (2603:10a6:803:e7::13) by VI1PR0402MB2798.eurprd04.prod.outlook.com (2603:10a6:800:ae::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20; Tue, 24 Nov 2020 11:28:22 +0000 Received: from VI1PR04MB5696.eurprd04.prod.outlook.com ([fe80::2dd6:8dc:2da7:ad84]) by VI1PR04MB5696.eurprd04.prod.outlook.com ([fe80::2dd6:8dc:2da7:ad84%5]) with mapi id 15.20.3589.030; Tue, 24 Nov 2020 11:28:22 +0000 From: Vladimir Oltean To: "Y.b. Lu" Subject: Re: [PATCH] arm64: dts: ls1028a: make the eMMC and SD card controllers use fixed indices Thread-Topic: [PATCH] arm64: dts: ls1028a: make the eMMC and SD card controllers use fixed indices Thread-Index: AQHWvovBrojMBFt1EECB86LxwqdSo6nQRb0AgAB8rICABirOgIAABiUAgAAMfQCAAAInAIAAAhyAgAAYuwCAAAxAgIAAA6YA Date: Tue, 24 Nov 2020 11:28:22 +0000 Message-ID: <20201124112822.2ui57jmoc73top35@skbuf> References: <20201119155025.965941-1-vladimir.oltean@nxp.com> <20201120093015.duel3yx63cbya77w@skbuf> <71a86b0fbc95892f8fd240e0919e7e23@walle.cc> <3293d698bf26ecf08f22e7e2ffe55e74@walle.cc> <20201124103128.zucizod344dgme4o@skbuf> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [188.25.2.120] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: cd422aab-e6a4-49cd-cbc1-08d8906c0d58 x-ms-traffictypediagnostic: VI1PR0402MB2798: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qHfKnBVv/CFKupf0Z8hH87eD2m1wlBg/8y14PEdTa5Pz6j+MFgNivbVjCEE0KEUL/F8WV05uQAQ94IK8/PCjtgQsv3fIb8na5yZpmjeidVcC4iLLZmuV9VA1aihM+D/93lPhTK0rpF/ZtB+ioVn8HeJmNwuDQiDCnYU0W3hoYFMDoSCZHPsBUYR/ocB3/4KyQfIpoL0E2anYcsKghDAfeXkeVAzwcbJKfIpkniUVxXZ07qDejpvKxIHjzyf9bE2XwfQUAiZBOTFxOT3F9Uw/XE6GXdUqY6JzE8ofw4LjgYfcD6GjIotDwL6GGCiEYs1mENXVF46Nzdby3EsyFB5N3A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5696.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(7916004)(346002)(376002)(136003)(366004)(396003)(39860400002)(6486002)(186003)(86362001)(9686003)(26005)(2906002)(54906003)(6512007)(316002)(5660300002)(8676002)(71200400001)(4326008)(6506007)(83380400001)(6862004)(8936002)(1076003)(44832011)(33716001)(478600001)(66946007)(6636002)(76116006)(66446008)(64756008)(66556008)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: sBQ9fthYuh/z+j1Dzl9JnhzL8M7+3ledOvsEbLXAbWTv5OqNflZZ0cJkMYars8bnZlOtbcR5gMGFJ5MxmyyIbitNJGhR4p9FbT/sZ8uGeZT+OEeK7tpbcZpki09+/PNFBumJPfxS3HIEzMgEGiqBezdCjCGEkKHnYGZbIACuoAAGK7TvdeNHHhNzldjBKgb1KZp8SHz+4CSM/wcnmTRVCthFQiu7O40lwlFgu9R1PyzxJ4439YqaMMA1TPGMPG5Bfgzwe/F+JRiRgLV19cmNuoBxy/ZXo3L7HvaMosWpKlruk5mX4BKEsfku2H9yFMZ7Beqjf7GLfk9Zc0zcRLhMOJKVMYTzohh1HoB6iuY5lhc+sZLoQdBvojAkfWUskTAaa6+eqIXThXnqdamW4x3Wjma5QWPAhGuEvcfKlnBgPe9mS30ldOjexR6zLaUGCY3ap+mOMVc4pqTflvE4EwRuOj4xNmSvuYAS8OXAa2I5SNAUHTaJCF66HTQidi0PWbLi1NNzF9cHYdMEan2PCp83Y4AXWNrqvatOfsm/ix+YdANleeVjQOGP3qtZ5XSra24GMMUbWGOxrSEKGUH4+j7oM5POtUmO90JpVBsBana2PFl4oq2+smlWeAl+3t/Oem8FbcxNgzmfWcbLX0RO+STn5ZtYN3ms07Uh/rM3WEIvERfEgXVckw5C2DGwvKQWdHpErSnqIVY6KjEEHrztfTNuJ+pEklfckMyDDpr38jpmt8PU2NG6XQbgdHR8VH+BoQmmDnb6QqUNAxeRu18JL1iJgUHia2RQ2Gtf5jqYx0iza6YZ/QPvQYBGzodVUiYaC9/gThHNKqWklg0ktwYnU4NeHLRHtHQQ8KpDTB6O1Eb9d+7diBabK88nWyJAYaVf9GumkseLvKrwAKZH0TuMiSdj0Q== Content-ID: <39B62B368FDE7E45AE289D15C1B5D774@eurprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5696.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd422aab-e6a4-49cd-cbc1-08d8906c0d58 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2020 11:28:22.7126 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gpkoe+9NepFdi81/1NYrLetf9vzOFnzg6EfaMfuGCjrsto3x2NmpmVcXkrbnxKS0Uwe5FyJH8r5ViLidz3GLzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2798 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201124_062827_030140_2FD96748 X-CRM114-Status: GOOD ( 19.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Ulf Hansson , Ashish Kumar , "linux-kernel@vger.kernel.org" , "linux-mmc@vger.kernel.org" , Adrian Hunter , Leo Li , Michael Walle , Rob Herring , Shawn Guo , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 24, 2020 at 11:15:19AM +0000, Y.b. Lu wrote: > > > Not matter it's SD card or eMMC card, if it's on esdhc0, use /dev/mmcblk0. > > > Not matter it's SD card or eMMC card, if it's on esdhc1, use /dev/mmcblk1. > > > > With the note here that you can't actually connect an SD card to eSDHC1, > > due to the lack of pins for CD/WP. > > CD/WP is not essential to support SD card. Both SD/eMMC are supported on both eSDHC controllers. Let's keep that discussion separate. While in theory you might be right, I think the real-life complications associated with connecting an eMMC to eSDHC0 and an SD card to eSDHC1 will make everyone avoid that. So in practice they are still single-purpose. > > But it is also natural for a customer to define the indices according to > > their schematics and what they use. If, say, there is a board that only > > uses eMMC, I would expect that for the lay person, no one would even bat > > an eye if that was called /dev/mmcblk0. Whereas, if it was called > > /dev/mmcblk1 (and there was no /dev/mmcblk0 in the system), maybe you'd > > have to come up with some explanations which could be avoided. > > To make a product friendly to users, it makes sense to define different alias for controller in board dts. > But it's not the reason to remove the default/natural alias in soc dtsi for two controllers. > What needs to be done after removing them? Add the same to all other board files? Yes. In fact, this is also the reason why we prefer to have: /soc { esdhc: mmc@2140000 { status = "disabled"; }; }; in fsl-ls1028a.dtsi and &esdhc { status = "okay"; }; in fsl-ls1028a-rdb.dts and not the other way around: /soc { esdhc: mmc@2140000 { status = "okay"; }; }; in fsl-ls1028a.dtsi and &esdhc { status = "disabled"; }; in fsl-ls1028a-rdb.dts So, in line with that, I think that the entity that enables the node should also define the alias. It's weird to use /delete-property/ if it can be avoided. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel