From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C37ACC2D0E4 for ; Tue, 24 Nov 2020 22:05:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21CA6205ED for ; Tue, 24 Nov 2020 22:05:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wLqEaKR/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="mMLjin9x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21CA6205ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n+klRmL5Rb2czJ8URKITjy/Wf4uAWioj3VJ0bit24nU=; b=wLqEaKR/rYI/b/lZDFJNibnnF 5KDjCcQ/qoXsPQncwUcEOl4jrgn6FhZN0Yg4t3pPv0/vLLsZNx7cV3wmBnUurQyXJxQnkAbHfHWQY a7OHHieQAQEwQqxu/BmD4Ps78PQ/fLDfajRg6sbc2CiK0CmGovHkZ7X944CosC/S78zcoUYceQdAJ 6qVrbqnJvtaiug7/9RR0EhcfqASAakkylAcGk1AQQwWI0mY1CiKRj/XTlpPjjIdyekWKBbybifaJp Un+9PREBSDUXrZH9/8kYVOZR1btZfm0I6KyekJoqVqrR0jxuj5KtKE8nPN4eZAH9G0ITuaXILF+aU dplI1qDvg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khgQ0-00075F-DP; Tue, 24 Nov 2020 22:04:12 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khgPy-00074d-6Z for linux-arm-kernel@lists.infradead.org; Tue, 24 Nov 2020 22:04:11 +0000 Received: by mail-pl1-x644.google.com with SMTP id t18so29214plo.0 for ; Tue, 24 Nov 2020 14:04:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mprkldjb7CjnHozwqyjj+Jl9qcuDOi72QFxjdMqMlao=; b=mMLjin9xvm7UjvLFOvfEmfJpDOC7c85RswKHc8n121a3BqSZ429co2QEMkq09h7PGD /pnHcRwf9Yq7g07bYgg2AV8/2vndniTYuQlEM0X0PKI6Yfy3FvpLfdwPZSS7j/jxp4vd LOeKHavDBHSg6VuZ+W191jH1sHCsHkaBVq9IA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mprkldjb7CjnHozwqyjj+Jl9qcuDOi72QFxjdMqMlao=; b=CtmKaSQ9LEA4UnNGU21OxLPKU63kxt1IkpTRrSj5oNOxycl/0suhmmUu5MVAPjjRRw JgLbpqOaWEBvdpkd+EatBJ/aB9B4VwfEDwdDhDo8IDpdLnt4nCFO9EfjmQ2ygJy+zr7d j3tM08oGJjVlPs/54MBVDrUcWdVq22hhQn9BQjPDBr61sraLZMarX0GFsLIKU1rN08G4 gJhssZ+FKo+9rBTodY3tcAdFC9vPXcteRJFX/iaYDuZpkAfpkLcyOQK1IE5OmhvS/65Y ChBeakX5HMuQ2R2NclZFGtokmi3B5BeS7nlpCE2qcmzGRI+cwnnuXCRto7ihoWrb1MX0 CEWA== X-Gm-Message-State: AOAM532kPOHDn6Q/NJ84C41KbaEqz/prdNqRsnbbEsN7gX9kclnq/eA3 UJn9j1M/QiMTiflZmpIEuijc1g== X-Google-Smtp-Source: ABdhPJwWsNzP3VcgbsHBRHePZyiD5EvmfBK/FQikTLooHtKWBj3ykTgPDCTI0MdKcQzupXKJ75E4ZQ== X-Received: by 2002:a17:902:bc46:b029:d6:d98a:1a68 with SMTP id t6-20020a170902bc46b02900d6d98a1a68mr276371plz.63.1606255447027; Tue, 24 Nov 2020 14:04:07 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id ne22sm184262pjb.45.2020.11.24.14.04.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 14:04:06 -0800 (PST) Date: Tue, 24 Nov 2020 14:04:05 -0800 From: Kees Cook To: Sami Tolvanen Subject: Re: [PATCH v2 1/2] scs: switch to vmapped shadow stacks Message-ID: <202011241404.9EA7F5F@keescook> References: <20201124195940.27061-1-samitolvanen@google.com> <20201124195940.27061-2-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201124195940.27061-2-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201124_170410_343318_FD88295D X-CRM114-Status: GOOD ( 13.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ard Biesheuvel , Catalin Marinas , linux-kernel@vger.kernel.org, James Morse , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 24, 2020 at 11:59:39AM -0800, Sami Tolvanen wrote: > The kernel currently uses kmem_cache to allocate shadow call stacks, > which means an overflows may not be immediately detected and can > potentially result in another task's shadow stack to be overwritten. > > This change switches SCS to use virtually mapped shadow stacks for > tasks, which increases shadow stack size to a full page and provides > more robust overflow detection, similarly to VMAP_STACK. > > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel