From: Lee Jones <lee.jones@linaro.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Mark Brown" <broonie@kernel.org>,
"Sascha Hauer" <kernel@pengutronix.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Maxime Ripard" <maxime.ripard@free-electrons.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] bus: sunxi-rsb: make remove callback return void
Date: Thu, 26 Nov 2020 08:03:16 +0000 [thread overview]
Message-ID: <20201126080316.GA2455276@dell> (raw)
In-Reply-To: <CAGb2v66rD3Z71Row8uOOtM-sEVaxY-EUcxrmAugJkpgSt7Sn+A@mail.gmail.com>
On Thu, 26 Nov 2020, Chen-Yu Tsai wrote:
> On Thu, Nov 26, 2020 at 3:41 PM Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> >
> > The driver core ignores the return value of struct device_driver::remove
> > because there is only little that can be done. To simplify the quest to
> > make this function return void, let struct sunxi_rsb_driver::remove
> > return void, too. All users already unconditionally return 0, this
> > commit makes this obvious and ensures future users don't behave
> > differently. To simplify even further, make axp20x_device_remove()
> > return void instead of returning 0 unconditionally, too.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Looks good to me.
>
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
>
> Since this touches the mfd tree as well, we either need an Ack from Lee,
> the mfd maintainer (CC-ed), or let Lee take it in his tree. For the latter,
Right. Thank you Chen-Yu.
Uwe, did you run get_maintainer.pl?
Please re-submit this with the proper people on Cc.
> Acked-by: Chen-Yu Tsai <wens@csie.org>
>
> AFAIK we (sunxi) don't have anything regarding RSB queued up, so there
> won't be any conflicts.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-26 8:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 7:41 [PATCH] bus: sunxi-rsb: make remove callback return void Uwe Kleine-König
2020-11-26 7:55 ` Chen-Yu Tsai
2020-11-26 8:03 ` Lee Jones [this message]
2020-11-26 10:35 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126080316.GA2455276@dell \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maxime.ripard@free-electrons.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox