From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2892C63798 for ; Thu, 26 Nov 2020 21:33:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4406B20872 for ; Thu, 26 Nov 2020 21:33:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Kei4pKQq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D8RjchmY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4406B20872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pVumlBdfJDyJmzktWH7kBq7KKqWXHDRI3xIsT7TWvag=; b=Kei4pKQqXR+J5tF/y90jV89RK 5EGTkv1L9vEXGaxmiCwyjlE9NxhXmEj0nXdh+unYETUAqQhkLqD1In9RXPGNGPV+EuLKKlPZU0x8r xgU1W2OK4gOYIXe0V5SZFaRwIg2DG6+sS2M9aSh7O05sYxEKzesz7/uoZ8y99OHSMx3NB+hQ/BXUe NS4MiyVSxZHHbzS1KbiLvf39ROnEEM53HM61xDzGNKYMP0vD6NGyQlBi8LiychjZTnjCawtdfi8sH NsAyAhgw5tfFolxiQolyiSYEiDHzFImRaXikwbv9CF51mSiUZ3Bdr3GP38wnSy+X9d8E+uAHfPECJ MNhTTt1Xg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiOrY-0000Lz-7H; Thu, 26 Nov 2020 21:31:36 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiOrU-0000K3-RY for linux-arm-kernel@lists.infradead.org; Thu, 26 Nov 2020 21:31:33 +0000 Received: by mail-pl1-x642.google.com with SMTP id l1so1692056pld.5 for ; Thu, 26 Nov 2020 13:31:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=a/Yr17tyVZOzPtpOMI6fU0OKHLM5WkCR0ljB5tvI8jA=; b=D8RjchmY2vqGT3P9AVhnqgY6EZOeq5cUgZpsHcPFeUzhReI1umerghInJIQ7fsZX7y jpcgvmy9kxP+ovXVLd6vlQcb7tBfZcmRSNhQcdDZyMFDsEvpOKhvDR/VVDMAMRFwKDgx Z/x5PB3DT65GTn10vW1G27KSi7ZjSQE9HQ5UqpZ78W7roIMluo5XD1smqy1kT72lEVih QoNP6BRnQVftg6p8tfQf+twOMTJWGBeVgjSDebHhMaAoZ85Wwt2MTOGQctjQOfcj3gS8 jpLDxChoIVIZWoTQHdk/gzeeOeqjLlVmuVmtiZKhXN0VViCaBc754mBSpelZv9Bt35SG qyeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=a/Yr17tyVZOzPtpOMI6fU0OKHLM5WkCR0ljB5tvI8jA=; b=qioiivmYadgy9TfotTjWbQ7NkPPkW43iWpTD5qwYZuXhof8WsB6P+mILCtH/aClYLy WfLNVdinE52f4amsoxTSR4ko+DPUPagUYcZPTLOU1unEMFqlaDSznwkx83OnBUgj8nwF zr7sIXLt9EnXKl+ENsOuCRG02xvdZ1Kgu+xdkvYHIHHFinMVyL2KuhtteqHFsSXHAwUT 3KhzfqEBAwbBmx7J20exZF1untAi9Hnxv5XJ0ong5zsizr1vPHKBp1EQLvBN2cH4bV71 suyQ/PCFqz30rqN+8n1+02MDiKlzBuOVnEFnNW35H4dllbRTdJhEJ52PBGdN99YiX6AM Cnsw== X-Gm-Message-State: AOAM530pvJ6/gVqhRgMQwGnMmSBJGifdwIkCV8n/GG2Kj8VVasqIO0mx eOV4qKv82oukHuVR4/htaSA= X-Google-Smtp-Source: ABdhPJwuTomeS7EFZhxZjn+m3VhPp+c1DdvHAF7qsX3/hB+phfqkRw3jbd2Tx7pvOzhRY+UkbU64mA== X-Received: by 2002:a17:902:7606:b029:da:246c:5bd8 with SMTP id k6-20020a1709027606b02900da246c5bd8mr4236748pll.27.1606426288824; Thu, 26 Nov 2020 13:31:28 -0800 (PST) Received: from dtor-ws ([2620:15c:202:201:a6ae:11ff:fe11:fcc3]) by smtp.gmail.com with ESMTPSA id o133sm5409402pfg.97.2020.11.26.13.31.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 13:31:27 -0800 (PST) Date: Thu, 26 Nov 2020 13:31:25 -0800 From: Dmitry Torokhov To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] ARM: locomo: make locomo bus's remove callback return void Message-ID: <20201126213125.GG2034289@dtor-ws> References: <20201126110140.2021758-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201126110140.2021758-1-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201126_163133_082762_CFB38769 X-CRM114-Status: GOOD ( 18.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Thompson , kernel@pengutronix.de, Bartlomiej Zolnierkiewicz , Jingoo Han , Russell King , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-input@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 26, 2020 at 12:01:40PM +0100, Uwe Kleine-K=F6nig wrote: > The driver core ignores the return value of struct bus_type::remove > because there is only little that can be done. To simplify the quest to > make this function return void, let struct locomo_driver::remove return > void, too. All users already unconditionally return 0, this commit makes > it obvious that returning an error code is a bad idea and ensures future > users behave accordingly. > = > Signed-off-by: Uwe Kleine-K=F6nig > --- > Hello, > = > if desired the change to arch/arm/mach-sa1100/collie.c can be split out > of this patch. The change of prototype then doesn't affect this driver > any more. There is one locomo-driver that is already now unaffected: > drivers/leds/leds-locomo.c. This driver doesn't have a remove callback. > = > Best regards > Uwe > = > arch/arm/common/locomo.c | 5 ++--- > arch/arm/include/asm/hardware/locomo.h | 2 +- > arch/arm/mach-sa1100/collie.c | 6 ------ > drivers/input/keyboard/locomokbd.c | 4 +--- Acked-by: Dmitry Torokhov > drivers/video/backlight/locomolcd.c | 3 +-- > 5 files changed, 5 insertions(+), 15 deletions(-) Thanks. -- = Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel