* [PATCH] hwrng: exynos - fix reference leak in exynos_trng_probe @ 2020-11-27 9:44 ` Qinglang Miao 2020-11-27 9:44 ` Krzysztof Kozlowski 2020-11-27 14:26 ` Lukasz Stelmach 0 siblings, 2 replies; 5+ messages in thread From: Qinglang Miao @ 2020-11-27 9:44 UTC (permalink / raw) To: Łukasz Stelmach, Krzysztof Kozlowski Cc: Qinglang Miao, linux-samsung-soc, linux-crypto, linux-arm-kernel, linux-kernel pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in a reference leak here. A new function pm_runtime_resume_and_get is introduced in [0] to keep usage counter balanced. So We fix the reference leak by replacing it with new funtion. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: 6cd225cc5d8a ("hwrng: exynos - add Samsung Exynos True RNG driver") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com> --- drivers/char/hw_random/exynos-trng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c index 8e1fe3f8d..666246bc8 100644 --- a/drivers/char/hw_random/exynos-trng.c +++ b/drivers/char/hw_random/exynos-trng.c @@ -132,7 +132,7 @@ static int exynos_trng_probe(struct platform_device *pdev) return PTR_ERR(trng->mem); pm_runtime_enable(&pdev->dev); - ret = pm_runtime_get_sync(&pdev->dev); + ret = pm_runtime_resume_and_get(&pdev->dev); if (ret < 0) { dev_err(&pdev->dev, "Could not get runtime PM.\n"); goto err_pm_get; -- 2.23.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] hwrng: exynos - fix reference leak in exynos_trng_probe 2020-11-27 9:44 ` [PATCH] hwrng: exynos - fix reference leak in exynos_trng_probe Qinglang Miao @ 2020-11-27 9:44 ` Krzysztof Kozlowski 2020-11-30 13:03 ` Qinglang Miao 2020-11-27 14:26 ` Lukasz Stelmach 1 sibling, 1 reply; 5+ messages in thread From: Krzysztof Kozlowski @ 2020-11-27 9:44 UTC (permalink / raw) To: Qinglang Miao Cc: linux-samsung-soc, Łukasz Stelmach, linux-crypto, linux-arm-kernel, linux-kernel On Fri, Nov 27, 2020 at 05:44:46PM +0800, Qinglang Miao wrote: > pm_runtime_get_sync will increment pm usage counter even it > failed. Forgetting to putting operation will result in a > reference leak here. > > A new function pm_runtime_resume_and_get is introduced in > [0] to keep usage counter balanced. So We fix the reference > leak by replacing it with new funtion. > > [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Do not put such dependencies into the commit message - it does not bring useful information to the history. Store it under '---' separator. > > Fixes: 6cd225cc5d8a ("hwrng: exynos - add Samsung Exynos True RNG driver") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com> > --- > drivers/char/hw_random/exynos-trng.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c > index 8e1fe3f8d..666246bc8 100644 > --- a/drivers/char/hw_random/exynos-trng.c > +++ b/drivers/char/hw_random/exynos-trng.c > @@ -132,7 +132,7 @@ static int exynos_trng_probe(struct platform_device *pdev) > return PTR_ERR(trng->mem); > > pm_runtime_enable(&pdev->dev); > - ret = pm_runtime_get_sync(&pdev->dev); > + ret = pm_runtime_resume_and_get(&pdev->dev); This cannot be applied. Fix it by replacing err_clock label with this one. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwrng: exynos - fix reference leak in exynos_trng_probe 2020-11-27 9:44 ` Krzysztof Kozlowski @ 2020-11-30 13:03 ` Qinglang Miao 0 siblings, 0 replies; 5+ messages in thread From: Qinglang Miao @ 2020-11-30 13:03 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: linux-samsung-soc, Łukasz Stelmach, linux-crypto, linux-arm-kernel, linux-kernel 在 2020/11/27 17:44, Krzysztof Kozlowski 写道: > On Fri, Nov 27, 2020 at 05:44:46PM +0800, Qinglang Miao wrote: >> pm_runtime_get_sync will increment pm usage counter even it >> failed. Forgetting to putting operation will result in a >> reference leak here. >> >> A new function pm_runtime_resume_and_get is introduced in >> [0] to keep usage counter balanced. So We fix the reference >> leak by replacing it with new funtion. >> >> [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") > > Do not put such dependencies into the commit message - it does not bring > useful information to the history. Store it under '---' separator. > >> >> Fixes: 6cd225cc5d8a ("hwrng: exynos - add Samsung Exynos True RNG driver") >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com> >> --- >> drivers/char/hw_random/exynos-trng.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c >> index 8e1fe3f8d..666246bc8 100644 >> --- a/drivers/char/hw_random/exynos-trng.c >> +++ b/drivers/char/hw_random/exynos-trng.c >> @@ -132,7 +132,7 @@ static int exynos_trng_probe(struct platform_device *pdev) >> return PTR_ERR(trng->mem); >> >> pm_runtime_enable(&pdev->dev); >> - ret = pm_runtime_get_sync(&pdev->dev); >> + ret = pm_runtime_resume_and_get(&pdev->dev); > > This cannot be applied. Fix it by replacing err_clock label with this > one. > > Best regards, > Krzysztof > > . Hi Krzysztof, I realize that there's a mistake in this patch through your reply. There's two way to fix this one: 1) replace err_pm_get with err_clock label when pm_runtime_get_sync fails. 2) replace pm_runtime_get_sync with pm_runtime_resume_and_get and remove redundant label(err_clock). I take 2) on v2 for it makes codes more clearer in a way. Thanks. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwrng: exynos - fix reference leak in exynos_trng_probe 2020-11-27 9:44 ` [PATCH] hwrng: exynos - fix reference leak in exynos_trng_probe Qinglang Miao 2020-11-27 9:44 ` Krzysztof Kozlowski @ 2020-11-27 14:26 ` Lukasz Stelmach 2020-11-30 13:05 ` Qinglang Miao 1 sibling, 1 reply; 5+ messages in thread From: Lukasz Stelmach @ 2020-11-27 14:26 UTC (permalink / raw) To: Qinglang Miao Cc: linux-arm-kernel, linux-samsung-soc, linux-crypto, Krzysztof Kozlowski, linux-kernel [-- Attachment #1.1: Type: text/plain, Size: 1563 bytes --] It was <2020-11-27 pią 17:44>, when Qinglang Miao wrote: > pm_runtime_get_sync will increment pm usage counter even it > failed. Forgetting to putting operation will result in a > reference leak here. > > A new function pm_runtime_resume_and_get is introduced in > [0] to keep usage counter balanced. So We fix the reference > leak by replacing it with new funtion. > > [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") > > Fixes: 6cd225cc5d8a ("hwrng: exynos - add Samsung Exynos True RNG driver") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com> > --- > drivers/char/hw_random/exynos-trng.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c > index 8e1fe3f8d..666246bc8 100644 > --- a/drivers/char/hw_random/exynos-trng.c > +++ b/drivers/char/hw_random/exynos-trng.c > @@ -132,7 +132,7 @@ static int exynos_trng_probe(struct platform_device *pdev) > return PTR_ERR(trng->mem); > > pm_runtime_enable(&pdev->dev); > - ret = pm_runtime_get_sync(&pdev->dev); > + ret = pm_runtime_resume_and_get(&pdev->dev); > if (ret < 0) { > dev_err(&pdev->dev, "Could not get runtime PM.\n"); > goto err_pm_get; Thanks. I suppose you may use the new function exynos_trng_resume(), remove everything and leave only return pm_runtime_resume_and_get(dev); -- Łukasz Stelmach Samsung R&D Institute Poland Samsung Electronics [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwrng: exynos - fix reference leak in exynos_trng_probe 2020-11-27 14:26 ` Lukasz Stelmach @ 2020-11-30 13:05 ` Qinglang Miao 0 siblings, 0 replies; 5+ messages in thread From: Qinglang Miao @ 2020-11-30 13:05 UTC (permalink / raw) To: Lukasz Stelmach Cc: linux-arm-kernel, linux-samsung-soc, linux-crypto, Krzysztof Kozlowski, linux-kernel 在 2020/11/27 22:26, Lukasz Stelmach 写道: > It was <2020-11-27 pią 17:44>, when Qinglang Miao wrote: >> pm_runtime_get_sync will increment pm usage counter even it >> failed. Forgetting to putting operation will result in a >> reference leak here. >> >> A new function pm_runtime_resume_and_get is introduced in >> [0] to keep usage counter balanced. So We fix the reference >> leak by replacing it with new funtion. >> >> [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") >> >> Fixes: 6cd225cc5d8a ("hwrng: exynos - add Samsung Exynos True RNG driver") >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com> >> --- >> drivers/char/hw_random/exynos-trng.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c >> index 8e1fe3f8d..666246bc8 100644 >> --- a/drivers/char/hw_random/exynos-trng.c >> +++ b/drivers/char/hw_random/exynos-trng.c >> @@ -132,7 +132,7 @@ static int exynos_trng_probe(struct platform_device *pdev) >> return PTR_ERR(trng->mem); >> >> pm_runtime_enable(&pdev->dev); >> - ret = pm_runtime_get_sync(&pdev->dev); >> + ret = pm_runtime_resume_and_get(&pdev->dev); >> if (ret < 0) { >> dev_err(&pdev->dev, "Could not get runtime PM.\n"); >> goto err_pm_get; > > Thanks. I suppose you may use the new function exynos_trng_resume(), > remove everything and leave only > > return pm_runtime_resume_and_get(dev); Hi, Lukasz I sent a v2 on this one. But I'm not really sure about what does 'remove everything' mean. for example, should I remove exynos_trng_resume in this patch? Thanks. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-30 13:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20201127142637eucas1p1746be156c43e789b48b5b78b9b212a33@eucas1p1.samsung.com>
2020-11-27 9:44 ` [PATCH] hwrng: exynos - fix reference leak in exynos_trng_probe Qinglang Miao
2020-11-27 9:44 ` Krzysztof Kozlowski
2020-11-30 13:03 ` Qinglang Miao
2020-11-27 14:26 ` Lukasz Stelmach
2020-11-30 13:05 ` Qinglang Miao
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).