From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8246BC2D0E4 for ; Fri, 27 Nov 2020 10:16:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D789206CA for ; Fri, 27 Nov 2020 10:16:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SCTKEt5b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D789206CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=34PUgs6uxnUMj+BU3lZt1q44hEPBuX1ePM3lIhFOQVo=; b=SCTKEt5bDPI6V3Qh3LwXxkJMn CkPRNKp+PHMzMvpcx1APXHGJ1DNp9nsJWUEyIyeWvM6W3c4NyX46y2PATIC6YBk7IbK3NdbhGSMML V5AH4xXJiwIN7O9TGqWR9SXGT1ENIJKcRHP2xz0qTGri9ZuAm6kccLdn7MF5cafgAI7iD8LkBNq6f NjOF6kuffVcftn4gcIFV98Ze+cQkFxh6OCycN12heOOPtTJ/9B92QN4b/kG/AbDwRRJhZeTYAX2Pv tjRNVDVauY4AgR1PtxsiUD+3ZsTsodFulCioyRYmQWL+HwqnjsUtSqM5V0lYCCCRFuc7XR/nIh2Y+ +mBSav0Hw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiam8-00057w-K2; Fri, 27 Nov 2020 10:14:48 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiam5-00057O-TS for linux-arm-kernel@lists.infradead.org; Fri, 27 Nov 2020 10:14:46 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D965E1516; Fri, 27 Nov 2020 02:14:41 -0800 (PST) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A809E3F71F; Fri, 27 Nov 2020 02:14:39 -0800 (PST) Date: Fri, 27 Nov 2020 10:14:33 +0000 From: Lorenzo Pieralisi To: David Brazdil Subject: Re: [PATCH v3 16/23] kvm: arm64: Forward safe PSCI SMCs coming from host Message-ID: <20201127101433.GA1061@e121166-lin.cambridge.arm.com> References: <20201126155421.14901-1-dbrazdil@google.com> <20201126155421.14901-17-dbrazdil@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201126155421.14901-17-dbrazdil@google.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201127_051446_053041_4762AF8D X-CRM114-Status: GOOD ( 26.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Sudeep Holla , kernel-team@android.com, Jonathan Corbet , Catalin Marinas , Suzuki K Poulose , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, James Morse , linux-arm-kernel@lists.infradead.org, Marc Zyngier , Tejun Heo , Dennis Zhou , Christoph Lameter , Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 26, 2020 at 03:54:14PM +0000, David Brazdil wrote: > Forward the following PSCI SMCs issued by host to EL3 as they do not > require the hypervisor's intervention. This assumes that EL3 correctly > implements the PSCI specification. > > Only function IDs implemented in Linux are included. > > Where both 32-bit and 64-bit variants exist, it is assumed that the host > will always use the 64-bit variant. > > * SMCs that only return information about the system > * PSCI_VERSION - PSCI version implemented by EL3 > * PSCI_FEATURES - optional features supported by EL3 > * AFFINITY_INFO - power state of core/cluster > * MIGRATE_INFO_TYPE - whether Trusted OS can be migrated > * MIGRATE_INFO_UP_CPU - resident core of Trusted OS > * operations which do not affect the hypervisor > * MIGRATE - migrate Trusted OS to a different core > * SET_SUSPEND_MODE - toggle OS-initiated mode > * system shutdown/reset > * SYSTEM_OFF > * SYSTEM_RESET > * SYSTEM_RESET2 What about SYSTEM_SUSPEND ? Lorenzo > Signed-off-by: David Brazdil > --- > arch/arm64/kvm/hyp/nvhe/psci-relay.c | 43 +++++++++++++++++++++++++++- > 1 file changed, 42 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/nvhe/psci-relay.c b/arch/arm64/kvm/hyp/nvhe/psci-relay.c > index e7091d89f0fc..7aa87ab7f5ce 100644 > --- a/arch/arm64/kvm/hyp/nvhe/psci-relay.c > +++ b/arch/arm64/kvm/hyp/nvhe/psci-relay.c > @@ -57,14 +57,51 @@ static bool is_psci_call(u64 func_id) > } > } > > +static unsigned long psci_call(unsigned long fn, unsigned long arg0, > + unsigned long arg1, unsigned long arg2) > +{ > + struct arm_smccc_res res; > + > + arm_smccc_1_1_smc(fn, arg0, arg1, arg2, &res); > + return res.a0; > +} > + > +static unsigned long psci_forward(struct kvm_cpu_context *host_ctxt) > +{ > + return psci_call(cpu_reg(host_ctxt, 0), cpu_reg(host_ctxt, 1), > + cpu_reg(host_ctxt, 2), cpu_reg(host_ctxt, 3)); > +} > + > +static __noreturn unsigned long psci_forward_noreturn(struct kvm_cpu_context *host_ctxt) > +{ > + psci_forward(host_ctxt); > + hyp_panic(); /* unreachable */ > +} > + > static unsigned long psci_0_1_handler(u64 func_id, struct kvm_cpu_context *host_ctxt) > { > - return PSCI_RET_NOT_SUPPORTED; > + if (func_id == kvm_host_psci_function_id[PSCI_FN_CPU_OFF]) > + return psci_forward(host_ctxt); > + else if (func_id == kvm_host_psci_function_id[PSCI_FN_MIGRATE]) > + return psci_forward(host_ctxt); > + else > + return PSCI_RET_NOT_SUPPORTED; > } > > static unsigned long psci_0_2_handler(u64 func_id, struct kvm_cpu_context *host_ctxt) > { > switch (func_id) { > + case PSCI_0_2_FN_PSCI_VERSION: > + case PSCI_0_2_FN_CPU_OFF: > + case PSCI_0_2_FN64_AFFINITY_INFO: > + case PSCI_0_2_FN64_MIGRATE: > + case PSCI_0_2_FN_MIGRATE_INFO_TYPE: > + case PSCI_0_2_FN64_MIGRATE_INFO_UP_CPU: > + return psci_forward(host_ctxt); > + case PSCI_0_2_FN_SYSTEM_OFF: > + case PSCI_0_2_FN_SYSTEM_RESET: > + psci_forward_noreturn(host_ctxt); > + unreachable(); > default: > return PSCI_RET_NOT_SUPPORTED; > } > @@ -73,6 +110,10 @@ static unsigned long psci_0_2_handler(u64 func_id, struct kvm_cpu_context *host_ > static unsigned long psci_1_0_handler(u64 func_id, struct kvm_cpu_context *host_ctxt) > { > switch (func_id) { > + case PSCI_1_0_FN_PSCI_FEATURES: > + case PSCI_1_0_FN_SET_SUSPEND_MODE: > + case PSCI_1_1_FN64_SYSTEM_RESET2: > + return psci_forward(host_ctxt); > default: > return psci_0_2_handler(func_id, host_ctxt); > } > -- > 2.29.2.454.gaff20da3a2-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel