From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09345C2D0E4 for ; Fri, 27 Nov 2020 11:54:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F7F921D46 for ; Fri, 27 Nov 2020 11:54:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rntV0rSr"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fDqlxhg0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F7F921D46 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mLIcn+g1UmXtXqGdw5jri2vTk456a0FMeYBMzlbMtxc=; b=rntV0rSrkWLEqNVkWJW+9Fmhe nvlormTMiigX0CDIilmh9GjNpompTrhkTH4RilB8abAcM8RvHaDHOigq0GrkBk0WhwfIx2sRoan+b SZgyHIx9Or5kftV3LusSBXUozXwSeGfWYOJbSHZL93jKHL5RB+EBkEot7IIwGuDN5f7zDTfI5AGEB LSnBnwMby8KIprwom40XzXftoOqaZGsVINFf/MBLBUe9+qhOId8qWOnt/hl48FNj+fpj53Wi0d0jM vOc0oCHJOrZjV07584msPWXWDQ456FeimKvwVd2cTo2tAIM2TQal7H1PnyFUwfXoeD29BEyvj6KLl m6rS/ggEQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kicJP-0005Do-Nz; Fri, 27 Nov 2020 11:53:15 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kicJM-0005D0-VF for linux-arm-kernel@lists.infradead.org; Fri, 27 Nov 2020 11:53:14 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D728821D46; Fri, 27 Nov 2020 11:53:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606477991; bh=iRowjQfwiQpVHUf5+VNrejatl3jHns8UFqG/fY0lA64=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fDqlxhg0s8I0lbubTcM0KCHwdQ5Jm6b4//0Z144munNg+uAsO9SfKes4f3FiFafg6 lAjcNtv7ZpDmchUtH/zWKAHaB1tPAac0SuUp2XQbWK/yruSh3QdkHZDTae0hZhU55t rH4IdTGP0Q4Y9DdwQ4WMRTRoLzqccezgT1m48lk8= Date: Fri, 27 Nov 2020 11:53:05 +0000 From: Will Deacon To: Marc Zyngier Subject: Re: [PATCH v4 03/14] KVM: arm64: Kill 32-bit vCPUs on systems with mismatched EL0 support Message-ID: <20201127115304.GB20564@willie-the-truck> References: <20201124155039.13804-1-will@kernel.org> <20201124155039.13804-4-will@kernel.org> <9bd06b193e7fb859a1207bb1302b7597@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9bd06b193e7fb859a1207bb1302b7597@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201127_065313_167533_D48A8439 X-CRM114-Status: GOOD ( 27.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Juri Lelli , kernel-team@android.com, Vincent Guittot , Quentin Perret , Peter Zijlstra , Catalin Marinas , Johannes Weiner , linux-kernel@vger.kernel.org, Qais Yousef , Ingo Molnar , Li Zefan , Greg Kroah-Hartman , Tejun Heo , Suren Baghdasaryan , Morten Rasmussen , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 27, 2020 at 10:26:47AM +0000, Marc Zyngier wrote: > On 2020-11-24 15:50, Will Deacon wrote: > > If a vCPU is caught running 32-bit code on a system with mismatched > > support at EL0, then we should kill it. > > > > Acked-by: Marc Zyngier > > Signed-off-by: Will Deacon > > --- > > arch/arm64/kvm/arm.c | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > > index 5750ec34960e..d322ac0f4a8e 100644 > > --- a/arch/arm64/kvm/arm.c > > +++ b/arch/arm64/kvm/arm.c > > @@ -633,6 +633,15 @@ static void check_vcpu_requests(struct kvm_vcpu > > *vcpu) > > } > > } > > > > +static bool vcpu_mode_is_bad_32bit(struct kvm_vcpu *vcpu) > > +{ > > + if (likely(!vcpu_mode_is_32bit(vcpu))) > > + return false; > > + > > + return !system_supports_32bit_el0() || > > + static_branch_unlikely(&arm64_mismatched_32bit_el0); > > +} > > + > > /** > > * kvm_arch_vcpu_ioctl_run - the main VCPU run function to execute > > guest code > > * @vcpu: The VCPU pointer > > @@ -816,7 +825,7 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu) > > * with the asymmetric AArch32 case), return to userspace with > > * a fatal error. > > */ > > - if (!system_supports_32bit_el0() && vcpu_mode_is_32bit(vcpu)) { > > + if (vcpu_mode_is_bad_32bit(vcpu)) { > > /* > > * As we have caught the guest red-handed, decide that > > * it isn't fit for purpose anymore by making the vcpu > > Given the new definition of system_supports_32bit_el0() in the previous > patch, > why do we need this patch at all? I think the check is still needed, as this is an unusual case where we want to reject the mismatched system. For example, imagine 'arm64_mismatched_32bit_el0' is true and we're on a mismatched system: in this case system_supports_32bit_el0() will return 'true' because we allow 32-bit applications to run, we support the 32-bit personality etc. However, we still want to terminate 32-bit vCPUs if we spot them in this situation, so we have to check for: !system_supports_32bit_el0() || static_branch_unlikely(&arm64_mismatched_32bit_el0) so that we only allow 32-bit vCPUs when all of the physical CPUs support it at EL0. I could make this clearer either by adding a comment, or avoiding system_supports_32bit_el0() entirely here and just checking the sanitised SYS_ID_AA64PFR0_EL1 register directly instead. What do you prefer? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel